| Message ID | 20220801022521.1594464-1-ye.xingchen@zte.com.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [linux-next] macintosh:adb:recordmcount:use !E in conditional statements | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | fail | kernel (ppc44x, ubuntu-21.10, ppc64) failed at step build. |
cgel.zte@gmail.com writes: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Use !E to replace the type of x == 0. This change is just to > simplify the code, no actual functional changes. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/macintosh/adb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The subject is wrong, why does it mention recordmcount? But in general this is very old code which is best left alone unless there's an actual bug, it doesn't need these sort of style refactorings done to it IMO. cheers > diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c > index 1bbb9ca08d40..368ab25db234 100644 > --- a/drivers/macintosh/adb.c > +++ b/drivers/macintosh/adb.c > @@ -673,7 +673,7 @@ static int adb_open(struct inode *inode, struct file *file) > goto out; > } > state = kmalloc(sizeof(struct adbdev_state), GFP_KERNEL); > - if (state == 0) { > + if (!state) { > ret = -ENOMEM; > goto out; > } > -- > 2.25.1
diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c index 1bbb9ca08d40..368ab25db234 100644 --- a/drivers/macintosh/adb.c +++ b/drivers/macintosh/adb.c @@ -673,7 +673,7 @@ static int adb_open(struct inode *inode, struct file *file) goto out; } state = kmalloc(sizeof(struct adbdev_state), GFP_KERNEL); - if (state == 0) { + if (!state) { ret = -ENOMEM; goto out; }