| Message ID | 20220622061652.4095330-1-windhl@126.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | macintosh: Add missing of_node_get() in do_attach() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
On Wed, 22 Jun 2022 14:16:52 +0800, Liang He wrote: > We need a of_node_get() for of_find_compatible_node() to keep refcount > balance. > > Applied to powerpc/next. [1/1] macintosh: Add missing of_node_get() in do_attach() https://git.kernel.org/powerpc/c/d208d8c2cde513b94ae3b8b97663656079004555 cheers
diff --git a/drivers/macintosh/therm_windtunnel.c b/drivers/macintosh/therm_windtunnel.c index 9226b74fa08f..bee0510ab1df 100644 --- a/drivers/macintosh/therm_windtunnel.c +++ b/drivers/macintosh/therm_windtunnel.c @@ -317,6 +317,7 @@ static void do_attach(struct i2c_adapter *adapter) if (x.running || strncmp(adapter->name, "uni-n", 5)) return; + of_node_get(adapter->dev.of_node); np = of_find_compatible_node(adapter->dev.of_node, NULL, "MAC,ds1775"); if (np) { of_node_put(np); @@ -325,6 +326,7 @@ static void do_attach(struct i2c_adapter *adapter) i2c_new_scanned_device(adapter, &info, scan_ds1775, NULL); } + of_node_get(adapter->dev.of_node); np = of_find_compatible_node(adapter->dev.of_node, NULL, "MAC,adm1030"); if (np) { of_node_put(np);
We need a of_node_get() for of_find_compatible_node() to keep refcount balance. Signed-off-by: Liang He <windhl@126.com> --- drivers/macintosh/therm_windtunnel.c | 2 ++ 1 file changed, 2 insertions(+)