From patchwork Fri Jun 3 12:15:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 1638711 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=cFOF6qQS; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LF20r6yFgz9sFs for ; Fri, 3 Jun 2022 22:16:12 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LF20p6Dpbz3bsr for ; Fri, 3 Jun 2022 22:16:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=cFOF6qQS; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::430; helo=mail-pf1-x430.google.com; envelope-from=linmq006@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=cFOF6qQS; dkim-atps=neutral Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LF20W33f7z307n for ; Fri, 3 Jun 2022 22:15:54 +1000 (AEST) Received: by mail-pf1-x430.google.com with SMTP id bo5so7066138pfb.4 for ; Fri, 03 Jun 2022 05:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a9U3qsBSVaLdxBGwysRPnWNY0hSOW5bqS3fMTtRWlOU=; b=cFOF6qQSycOAg+gIAm34Ht6pACgpcLc5A505loomEOpN92Mvqy9AKHANFvo1LeIseH TQV7gpyd2J8BkQT/qSveitZGLV5UoZXMPoR3f0aJArnGeB4ufeVzCN1yvq8bsGUxonD1 YdcYdCWfxufluBuZzcb3L3MqHcpEKqr7RdDUHnWDumNGdghvFLJtvJJI56Z3s0lxFxvu T2VF48gcILXr+DG8X1OhDunUj1p87J8vaLHFtOmGKRkrB+CltTsjFwleOHXYtNlvCYcI bq+nLcz+m98PqzqkNqMD54IGMTy3SmbfqZQwxitiKUw3fG60dgqLfbk48eCf5EDMTrgp qCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a9U3qsBSVaLdxBGwysRPnWNY0hSOW5bqS3fMTtRWlOU=; b=oLXM4aQRKZNvzQphyQQoQSa55J3/1q+YbzzxO1lvfbNRBbHaS/LiMwhR6D4z5hcmc1 6VttkWKzj3vDKVQ+HMbKmFf2ixFcKbdCgQvt9tnYUbUFbULLKebam9u8u2IHmNE6fsUE 7nUCNX0+woTPpwkrOBIYm7tNXU1FlcnOFwDe3plgYKd6mssSGtXgIoVSQOjlW2Ten4tg e8r3gHzXSCDD6tijZzoT4Go4ATCfgHW6quOvV2UMD+3uHihasDh/YtlO27dX7XvPjjsn c5bsWGIekMBg8CzMoeU/p88Jx315EcxC3Vi2gik5axR3MXlNPtFPmAh71cMnWwBt191C NfDQ== X-Gm-Message-State: AOAM532ql2oBo0QC6TCIKk5vTp/WEIs434TXOoTDhJ4DsaJp+PshZsbo K7urh4THStTgoiZXCDo5AyQ= X-Google-Smtp-Source: ABdhPJxsP/J9XGCwUjJcprDJ7lbiUGLbMFq/EQv37a5Rd/1TTPKJOGhRPLSO9Vu4n7hyI2qVikFmFQ== X-Received: by 2002:a65:63d1:0:b0:3c6:25b2:22ba with SMTP id n17-20020a6563d1000000b003c625b222bamr8702993pgv.360.1654258551714; Fri, 03 Jun 2022 05:15:51 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id bg13-20020a17090b0d8d00b001e08461ceaesm7545215pjb.37.2022.06.03.05.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 05:15:51 -0700 (PDT) From: Miaoqian Lin To: Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader Date: Fri, 3 Jun 2022 16:15:42 +0400 Message-Id: <20220603121543.22884-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linmq006@gmail.com Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" of_find_node_by_path() returns remote device nodepointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 0afacde3df4c ("[POWERPC] spufs: allow isolated mode apps by starting the SPE loader") Signed-off-by: Miaoqian Lin Acked-by: Arnd Bergmann --- arch/powerpc/platforms/cell/spufs/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c index 34334c32b7f5..320008528edd 100644 --- a/arch/powerpc/platforms/cell/spufs/inode.c +++ b/arch/powerpc/platforms/cell/spufs/inode.c @@ -660,6 +660,7 @@ spufs_init_isolated_loader(void) return; loader = of_get_property(dn, "loader", &size); + of_node_put(dn); if (!loader) return;