| Message ID | 20220518092903.7065-1-atrajeev@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | tools/perf/test: Fix perf all PMU test to skip hv_24x7/hv_gpci tests on powerpc | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_perf | success | Successfully ran 10 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
Athira Rajeev <atrajeev@linux.vnet.ibm.com> writes: > "perf all PMU test" picks the input events from > "perf list --raw-dump pmu" list and runs "perf stat -e" > for each of the event in the list. In case of powerpc, the > PowerVM environment supports events from hv_24x7 and hv_gpci > PMU which is of example format like below: > - hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ > - hv_gpci/event,partition_id=?/ > > The value for "?" needs to be filled in depending on > system and respective event. CPM_ADJUNCT_INST needs have > core value and domain value. hv_gpci event needs partition_id. > Similarly, there are other events for hv_24x7 and hv_gpci > having "?" in event format. Hence skip these events on powerpc > platform since values like partition_id, domain is specific > to system and event. > > Fixes: 3d5ac9effcc6 ("perf test: Workload test of all PMUs") > Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > --- > tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh > index b30dba455f36..4a854b545bec 100755 > --- a/tools/perf/tests/shell/stat_all_pmu.sh > +++ b/tools/perf/tests/shell/stat_all_pmu.sh > @@ -5,6 +5,16 @@ > set -e > > for p in $(perf list --raw-dump pmu); do > + # In powerpc, skip the events for hv_24x7 and hv_gpci. > + # These events needs input values to be filled in for > + # core, chip, patition id based on system. > + # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ > + # hv_gpci/event,partition_id=?/ > + # Hence skip these events for ppc. > + if lscpu |grep ppc && echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then My system doesn't have lscpu installed, why not use `uname -m`. But why check for ppc at all, the name of the pmu seems unique enough - no one else is going to call their pmu something so odd :) cheers
> On 18-May-2022, at 6:35 PM, Michael Ellerman <mpe@ellerman.id.au> wrote: > > Athira Rajeev <atrajeev@linux.vnet.ibm.com> writes: >> "perf all PMU test" picks the input events from >> "perf list --raw-dump pmu" list and runs "perf stat -e" >> for each of the event in the list. In case of powerpc, the >> PowerVM environment supports events from hv_24x7 and hv_gpci >> PMU which is of example format like below: >> - hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ >> - hv_gpci/event,partition_id=?/ >> >> The value for "?" needs to be filled in depending on >> system and respective event. CPM_ADJUNCT_INST needs have >> core value and domain value. hv_gpci event needs partition_id. >> Similarly, there are other events for hv_24x7 and hv_gpci >> having "?" in event format. Hence skip these events on powerpc >> platform since values like partition_id, domain is specific >> to system and event. >> >> Fixes: 3d5ac9effcc6 ("perf test: Workload test of all PMUs") >> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> >> --- >> tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh >> index b30dba455f36..4a854b545bec 100755 >> --- a/tools/perf/tests/shell/stat_all_pmu.sh >> +++ b/tools/perf/tests/shell/stat_all_pmu.sh >> @@ -5,6 +5,16 @@ >> set -e >> >> for p in $(perf list --raw-dump pmu); do >> + # In powerpc, skip the events for hv_24x7 and hv_gpci. >> + # These events needs input values to be filled in for >> + # core, chip, patition id based on system. >> + # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ >> + # hv_gpci/event,partition_id=?/ >> + # Hence skip these events for ppc. >> + if lscpu |grep ppc && echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then > > My system doesn't have lscpu installed, why not use `uname -m`. > > But why check for ppc at all, the name of the pmu seems unique enough - > no one else is going to call their pmu something so odd :) Thanks Michael for the review. Yes, I can directly use pmu name :) Will address this change in V2 Thanks Athira > > cheers
diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh index b30dba455f36..4a854b545bec 100755 --- a/tools/perf/tests/shell/stat_all_pmu.sh +++ b/tools/perf/tests/shell/stat_all_pmu.sh @@ -5,6 +5,16 @@ set -e for p in $(perf list --raw-dump pmu); do + # In powerpc, skip the events for hv_24x7 and hv_gpci. + # These events needs input values to be filled in for + # core, chip, patition id based on system. + # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ + # hv_gpci/event,partition_id=?/ + # Hence skip these events for ppc. + if lscpu |grep ppc && echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then + echo "Skipping: Event '$p' in powerpc" + continue + fi echo "Testing $p" result=$(perf stat -e "$p" true 2>&1) if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
"perf all PMU test" picks the input events from "perf list --raw-dump pmu" list and runs "perf stat -e" for each of the event in the list. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below: - hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/ - hv_gpci/event,partition_id=?/ The value for "?" needs to be filled in depending on system and respective event. CPM_ADJUNCT_INST needs have core value and domain value. hv_gpci event needs partition_id. Similarly, there are other events for hv_24x7 and hv_gpci having "?" in event format. Hence skip these events on powerpc platform since values like partition_id, domain is specific to system and event. Fixes: 3d5ac9effcc6 ("perf test: Workload test of all PMUs") Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> --- tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++ 1 file changed, 10 insertions(+)