| Message ID | 20220223135820.2252470-1-anders.roxell@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] powerpc: lib: sstep: fix 'sthcx' instruction | expand |
Excerpts from Anders Roxell's message of February 23, 2022 11:58 pm: > Looks like there been a copy paste mistake when added the instruction > 'stbcx' twice and one was probably meant to be 'sthcx'. > Changing to 'sthcx' from 'stbcx'. > > Cc: <stable@vger.kernel.org> # v4.13+ > Fixes: 350779a29f11 ("powerpc: Handle most loads and stores in instruction emulation code") > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Good catch. Reviewed-by: Nicholas Piggin <npiggin@gmail.com> > --- > arch/powerpc/lib/sstep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c > index bd3734d5be89..d2d29243fa6d 100644 > --- a/arch/powerpc/lib/sstep.c > +++ b/arch/powerpc/lib/sstep.c > @@ -3389,7 +3389,7 @@ int emulate_loadstore(struct pt_regs *regs, struct instruction_op *op) > __put_user_asmx(op->val, ea, err, "stbcx.", cr); > break; > case 2: > - __put_user_asmx(op->val, ea, err, "stbcx.", cr); > + __put_user_asmx(op->val, ea, err, "sthcx.", cr); > break; > #endif > case 4: > -- > 2.34.1 > >
diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c index bd3734d5be89..d2d29243fa6d 100644 --- a/arch/powerpc/lib/sstep.c +++ b/arch/powerpc/lib/sstep.c @@ -3389,7 +3389,7 @@ int emulate_loadstore(struct pt_regs *regs, struct instruction_op *op) __put_user_asmx(op->val, ea, err, "stbcx.", cr); break; case 2: - __put_user_asmx(op->val, ea, err, "stbcx.", cr); + __put_user_asmx(op->val, ea, err, "sthcx.", cr); break; #endif case 4:
Looks like there been a copy paste mistake when added the instruction 'stbcx' twice and one was probably meant to be 'sthcx'. Changing to 'sthcx' from 'stbcx'. Cc: <stable@vger.kernel.org> # v4.13+ Fixes: 350779a29f11 ("powerpc: Handle most loads and stores in instruction emulation code") Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- arch/powerpc/lib/sstep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)