| Message ID | 20211207110228.698956-1-anders.roxell@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | powerpc: platforms: cell: pervasive: fix clang -Wimplicit-fallthrough | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
On Tue, Dec 7, 2021 at 12:02 PM Anders Roxell <anders.roxell@linaro.org> wrote: > > Clang warns: > > arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case SRR1_WAKEEE: > ^ > arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through > case SRR1_WAKEEE: > ^ > break; > 1 error generated. > > Clang is more pedantic than GCC, which does not warn when failing > through to a case that is just break or return. Clang's version > is more in line with the kernel's own stance in deprecated.rst. > Add athe missing break to silence the warning. > > Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset") > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Thanks for the fix! Reviewed-by: Arnd Bergmann <arnd@arndb.de>
On Tue, Dec 07, 2021 at 12:02:28PM +0100, Anders Roxell wrote: > Clang warns: > > arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case SRR1_WAKEEE: > ^ > arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through > case SRR1_WAKEEE: > ^ > break; > 1 error generated. > > Clang is more pedantic than GCC, which does not warn when failing > through to a case that is just break or return. Clang's version > is more in line with the kernel's own stance in deprecated.rst. > Add athe missing break to silence the warning. ^ small typo, probably not worth a resend > > Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset") > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > arch/powerpc/platforms/cell/pervasive.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/cell/pervasive.c b/arch/powerpc/platforms/cell/pervasive.c > index 5b9a7e9f144b..dff8d5e7ab82 100644 > --- a/arch/powerpc/platforms/cell/pervasive.c > +++ b/arch/powerpc/platforms/cell/pervasive.c > @@ -78,6 +78,7 @@ static int cbe_system_reset_exception(struct pt_regs *regs) > switch (regs->msr & SRR1_WAKEMASK) { > case SRR1_WAKEDEC: > set_dec(1); > + break; > case SRR1_WAKEEE: > /* > * Handle these when interrupts get re-enabled and we take > -- > 2.33.0 >
Anders Roxell <anders.roxell@linaro.org> writes: > Clang warns: > > arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case SRR1_WAKEEE: > ^ > arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through > case SRR1_WAKEEE: > ^ > break; > 1 error generated. > > Clang is more pedantic than GCC, which does not warn when failing > through to a case that is just break or return. Clang's version > is more in line with the kernel's own stance in deprecated.rst. > Add athe missing break to silence the warning. > > Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset") > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > arch/powerpc/platforms/cell/pervasive.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/cell/pervasive.c b/arch/powerpc/platforms/cell/pervasive.c > index 5b9a7e9f144b..dff8d5e7ab82 100644 > --- a/arch/powerpc/platforms/cell/pervasive.c > +++ b/arch/powerpc/platforms/cell/pervasive.c > @@ -78,6 +78,7 @@ static int cbe_system_reset_exception(struct pt_regs *regs) > switch (regs->msr & SRR1_WAKEMASK) { > case SRR1_WAKEDEC: > set_dec(1); > + break; > case SRR1_WAKEEE: > /* > * Handle these when interrupts get re-enabled and we take Thanks. I have definitely fixed this somewhere before, but I guess I never sent it upstream, or it's still lying in a git stash of mine. cheers
On Tue, 7 Dec 2021 12:02:28 +0100, Anders Roxell wrote: > Clang warns: > > arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] > case SRR1_WAKEEE: > ^ > arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through > case SRR1_WAKEEE: > ^ > break; > 1 error generated. > > [...] Applied to powerpc/next. [1/1] powerpc: platforms: cell: pervasive: fix clang -Wimplicit-fallthrough https://git.kernel.org/powerpc/c/e89257e28e844f5d1d39081bb901d9f1183a7705 cheers
diff --git a/arch/powerpc/platforms/cell/pervasive.c b/arch/powerpc/platforms/cell/pervasive.c index 5b9a7e9f144b..dff8d5e7ab82 100644 --- a/arch/powerpc/platforms/cell/pervasive.c +++ b/arch/powerpc/platforms/cell/pervasive.c @@ -78,6 +78,7 @@ static int cbe_system_reset_exception(struct pt_regs *regs) switch (regs->msr & SRR1_WAKEMASK) { case SRR1_WAKEDEC: set_dec(1); + break; case SRR1_WAKEEE: /* * Handle these when interrupts get re-enabled and we take
Clang warns: arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough] case SRR1_WAKEEE: ^ arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through case SRR1_WAKEEE: ^ break; 1 error generated. Clang is more pedantic than GCC, which does not warn when failing through to a case that is just break or return. Clang's version is more in line with the kernel's own stance in deprecated.rst. Add athe missing break to silence the warning. Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset") Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- arch/powerpc/platforms/cell/pervasive.c | 1 + 1 file changed, 1 insertion(+)