| Message ID | 20210118093145.10134-1-sandipan@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 92a5e1fdb286851d5bd0eb966b8d075be27cf5ee |
| Headers | show |
| Series | selftests/powerpc: Fix exit status of pkey tests | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (41d8cb7ece7c81e4eb897ed7ec7d3c3d72fd0af4) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 12 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
Sandipan Das <sandipan@linux.ibm.com> writes: > Since main() does not return a value explicitly, the > return values from FAIL_IF() conditions are ignored > and the tests can still pass irrespective of failures. > This makes sure that we always explicitly return the > correct test exit status. > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> > Reported-by: Eirik Fuller <efuller@redhat.com> > Fixes: 1addb6444791 ("selftests/powerpc: Add test for execute-disabled pkeys") > Fixes: c27f2fd1705a ("selftests/powerpc: Add test for pkey siginfo verification") > Signed-off-by: Sandipan Das <sandipan@linux.ibm.com> > --- > tools/testing/selftests/powerpc/mm/pkey_exec_prot.c | 2 +- > tools/testing/selftests/powerpc/mm/pkey_siginfo.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c b/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c > index 9e5c7f3f498a..0af4f02669a1 100644 > --- a/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c > +++ b/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c > @@ -290,5 +290,5 @@ static int test(void) > > int main(void) > { > - test_harness(test, "pkey_exec_prot"); > + return test_harness(test, "pkey_exec_prot"); > } > diff --git a/tools/testing/selftests/powerpc/mm/pkey_siginfo.c b/tools/testing/selftests/powerpc/mm/pkey_siginfo.c > index 4f815d7c1214..2db76e56d4cb 100644 > --- a/tools/testing/selftests/powerpc/mm/pkey_siginfo.c > +++ b/tools/testing/selftests/powerpc/mm/pkey_siginfo.c > @@ -329,5 +329,5 @@ static int test(void) > > int main(void) > { > - test_harness(test, "pkey_siginfo"); > + return test_harness(test, "pkey_siginfo"); > } > -- > 2.25.1
On Mon, 18 Jan 2021 15:01:45 +0530, Sandipan Das wrote: > Since main() does not return a value explicitly, the > return values from FAIL_IF() conditions are ignored > and the tests can still pass irrespective of failures. > This makes sure that we always explicitly return the > correct test exit status. Applied to powerpc/fixes. [1/1] selftests/powerpc: Fix exit status of pkey tests https://git.kernel.org/powerpc/c/92a5e1fdb286851d5bd0eb966b8d075be27cf5ee cheers
diff --git a/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c b/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c index 9e5c7f3f498a..0af4f02669a1 100644 --- a/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c +++ b/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c @@ -290,5 +290,5 @@ static int test(void) int main(void) { - test_harness(test, "pkey_exec_prot"); + return test_harness(test, "pkey_exec_prot"); } diff --git a/tools/testing/selftests/powerpc/mm/pkey_siginfo.c b/tools/testing/selftests/powerpc/mm/pkey_siginfo.c index 4f815d7c1214..2db76e56d4cb 100644 --- a/tools/testing/selftests/powerpc/mm/pkey_siginfo.c +++ b/tools/testing/selftests/powerpc/mm/pkey_siginfo.c @@ -329,5 +329,5 @@ static int test(void) int main(void) { - test_harness(test, "pkey_siginfo"); + return test_harness(test, "pkey_siginfo"); }
Since main() does not return a value explicitly, the return values from FAIL_IF() conditions are ignored and the tests can still pass irrespective of failures. This makes sure that we always explicitly return the correct test exit status. Reported-by: Eirik Fuller <efuller@redhat.com> Fixes: 1addb6444791 ("selftests/powerpc: Add test for execute-disabled pkeys") Fixes: c27f2fd1705a ("selftests/powerpc: Add test for pkey siginfo verification") Signed-off-by: Sandipan Das <sandipan@linux.ibm.com> --- tools/testing/selftests/powerpc/mm/pkey_exec_prot.c | 2 +- tools/testing/selftests/powerpc/mm/pkey_siginfo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)