Message ID | 20201130034406.288047-1-ravi.bangoria@linux.ibm.com (mailing list archive) |
---|---|
State | Accepted |
Commit | f3e90408019b353fd1fcd338091fb8d3c4a1c1a5 |
Headers | show |
Series | powerpc/xmon: Fix build failure for 8xx | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (2551450071df2dabd7134e548ac209688ac6741d) |
snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
On Mon, 30 Nov 2020 09:14:06 +0530, Ravi Bangoria wrote: > With CONFIG_PPC_8xx and CONFIG_XMON set, kernel build fails with > > arch/powerpc/xmon/xmon.c:1379:12: error: 'find_free_data_bpt' defined > but not used [-Werror=unused-function] > > Fix it by enclosing find_free_data_bpt() inside #ifndef CONFIG_PPC_8xx. Applied to powerpc/next. [1/1] powerpc/xmon: Fix build failure for 8xx https://git.kernel.org/powerpc/c/f3e90408019b353fd1fcd338091fb8d3c4a1c1a5 cheers
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 55c43a6c9111..5559edf36756 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -1383,6 +1383,7 @@ static long check_bp_loc(unsigned long addr) return 1; } +#ifndef CONFIG_PPC_8xx static int find_free_data_bpt(void) { int i; @@ -1394,6 +1395,7 @@ static int find_free_data_bpt(void) printf("Couldn't find free breakpoint register\n"); return -1; } +#endif static void print_data_bpts(void) {
With CONFIG_PPC_8xx and CONFIG_XMON set, kernel build fails with arch/powerpc/xmon/xmon.c:1379:12: error: 'find_free_data_bpt' defined but not used [-Werror=unused-function] Fix it by enclosing find_free_data_bpt() inside #ifndef CONFIG_PPC_8xx. Reported-by: kernel test robot <lkp@intel.com> Fixes: 30df74d67d48 ("powerpc/watchpoint/xmon: Support 2nd DAWR") Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> --- arch/powerpc/xmon/xmon.c | 2 ++ 1 file changed, 2 insertions(+)