From patchwork Thu Nov 26 13:38:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1406718 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4ChgSD2XWyz9s0b for ; Fri, 27 Nov 2020 01:41:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MpLT1rTc; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4ChgSB1gL6zDrD2 for ; Fri, 27 Nov 2020 01:41:30 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=lee.jones@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MpLT1rTc; dkim-atps=neutral Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Chf4g6YCszDrKh for ; Fri, 27 Nov 2020 00:39:31 +1100 (AEDT) Received: by mail-wr1-x441.google.com with SMTP id z7so2187687wrn.3 for ; Thu, 26 Nov 2020 05:39:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=MpLT1rTcOQFXj5o4p45U25gq5Wthd5hRlOe6Ee20BztH8fDINAFaP0ZGPZrw/fdu38 SQDpyQIFeHvBMZPN84C6jFq3J/b9fMFZUIqyfyvASKnB4KKLD2TTzAPoMoOaBwcjGw0W Q/dLgkJXs8gJC3AhstDCm/oTI4DLuAkMXHGatvyRdaPI6XbX5O5rP642oQxh5iZCK86S gBKa8VwBXCPDpUt90nGEOfBD1oM7WZIuQofLaxEdI4/vzc2IhjdS4Y7G3j7IaZBOT7q2 4ENAa5iQyd+BgkiP2sMF01e4mBpRVZiTs7Wn2xKv4duAzKRegKdJkcE929j47H1/FM7t Sh4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=eeRsR0PVcdHn7Ae7AunYPwCzrMOhlJppuP7W3ElLGa1q6bwP5DZE2avAI+7PdIiqKL NsmNipOeP8EkAvNr0zslCBRHr6NiYdDLoKy4wiYzzLjuCJBD7UvZMZBxko7Zt+w6kavG JH7H3bZfLdSwTeE8zIXtdS0jeqCeRJbT5dDtlPxGWwyB3WM0J6CXO1A+Fn8cfhXqRyuB CIysRlJ6z/PZn+waeysKpYmdyoT6zz1trZjkGVHSdpXbU1jzisUtEGbjRU2o9YGbuT5x dJeox7zMlTp1veEaijMDOhfKCxWGli3u1Ofjyp80vKoKBpwsBnwDB4cxUWzxQhnmmqwW GUXg== X-Gm-Message-State: AOAM5304ZlM58RHjsFpUgiDsZaDiU7neJpl2UmYHKAPbjwk4mSO9Ds19 bR5C64jcgiOSsCmYRDzijh3Mag== X-Google-Smtp-Source: ABdhPJy76iTnF7RZ2IDKEHoxBDI4A4RdHy3hLm2gVUChhl9eVgcpueWg4kEabKQmMRsE+zIvq6jEcQ== X-Received: by 2002:adf:e551:: with SMTP id z17mr3940424wrm.374.1606397946311; Thu, 26 Nov 2020 05:39:06 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id s133sm7035825wmf.38.2020.11.26.05.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:39:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Thu, 26 Nov 2020 13:38:51 +0000 Message-Id: <20201126133853.3213268-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133853.3213268-1-lee.jones@linaro.org> References: <20201126133853.3213268-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geoff Levand , linux-kernel@vger.kernel.org, Jens Osterkamp , netdev@vger.kernel.org, Paul Mackerras , Utz Bacher , Jakub Kicinski , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter or member 'txqueue' not described in 'gelic_net_tx_timeout' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter or member 'napi' not described in 'gelic_ether_setup_netdev_ops' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_probe' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_remove' Cc: Geoff Levand Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index d9a5722f561b5..f886e23f8ed0a 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int budget) return packets_done; } -/** +/* * gelic_card_interrupt - event handler for gelic_net */ static irqreturn_t gelic_card_interrupt(int irq, void *ptr) @@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct *work) /** * gelic_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ @@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = { /** * gelic_ether_setup_netdev_ops - initialization of net_device operations * @netdev: net_device structure + * @napi: napi structure * * fills out function pointers in the net_device structure */ @@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card *card) dev_info(ctodev(card), "internal vlan %s\n", card->vlan_required? "enabled" : "disabled"); } -/** +/* * ps3_gelic_driver_probe - add a device to the control of this driver */ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) @@ -1787,10 +1789,9 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) return result; } -/** +/* * ps3_gelic_driver_remove - remove a device from the control of this driver */ - static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev) { struct gelic_card *card = ps3_system_bus_get_drvdata(dev);