| Message ID | 20200602041208.128913-1-ravi.bangoria@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ef3534a94fdbdeab4c89d18d0164be2ad5d6dbb7 |
| Headers | show |
| Series | hw_breakpoint: Fix build warnings with clang | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (00ec79b0b767994422c43792d73ff1327714a73f) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 4 checks, 19 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Le 02/06/2020 à 06:12, Ravi Bangoria a écrit : > kbuild test robot reported few build warnings with hw_breakpoint code > when compiled with clang[1]. Fix those. > > [1]: https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > Note: Prepared on top of powerpc/next. > > arch/powerpc/include/asm/hw_breakpoint.h | 3 --- > include/linux/hw_breakpoint.h | 4 ++++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/include/asm/hw_breakpoint.h b/arch/powerpc/include/asm/hw_breakpoint.h > index f42a55eb77d2..cb424799da0d 100644 > --- a/arch/powerpc/include/asm/hw_breakpoint.h > +++ b/arch/powerpc/include/asm/hw_breakpoint.h > @@ -70,9 +70,6 @@ extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, > unsigned long val, void *data); > int arch_install_hw_breakpoint(struct perf_event *bp); > void arch_uninstall_hw_breakpoint(struct perf_event *bp); > -int arch_reserve_bp_slot(struct perf_event *bp); > -void arch_release_bp_slot(struct perf_event *bp); > -void arch_unregister_hw_breakpoint(struct perf_event *bp); > void hw_breakpoint_pmu_read(struct perf_event *bp); > extern void flush_ptrace_hw_breakpoint(struct task_struct *tsk); > > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h > index 6058c3844a76..521481f0d320 100644 > --- a/include/linux/hw_breakpoint.h > +++ b/include/linux/hw_breakpoint.h > @@ -80,6 +80,10 @@ extern int dbg_reserve_bp_slot(struct perf_event *bp); > extern int dbg_release_bp_slot(struct perf_event *bp); > extern int reserve_bp_slot(struct perf_event *bp); > extern void release_bp_slot(struct perf_event *bp); > +extern int hw_breakpoint_weight(struct perf_event *bp); > +extern int arch_reserve_bp_slot(struct perf_event *bp); > +extern void arch_release_bp_slot(struct perf_event *bp); > +extern void arch_unregister_hw_breakpoint(struct perf_event *bp); Please no new 'extern'. In the old days 'extern' keyword was used, but new code shall not introduce new unnecessary usage of 'extern' keyword. See report from Checkpatch below: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: [1]: https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #40: FILE: include/linux/hw_breakpoint.h:83: +extern int hw_breakpoint_weight(struct perf_event *bp); CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #41: FILE: include/linux/hw_breakpoint.h:84: +extern int arch_reserve_bp_slot(struct perf_event *bp); CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #42: FILE: include/linux/hw_breakpoint.h:85: +extern void arch_release_bp_slot(struct perf_event *bp); CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #43: FILE: include/linux/hw_breakpoint.h:86: +extern void arch_unregister_hw_breakpoint(struct perf_event *bp); total: 0 errors, 1 warnings, 4 checks, 19 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. the.patch has style problems, please review. NOTE: Ignored message types: ARCH_INCLUDE_LINUX BIT_MACRO COMPARISON_TO_NULL DT_SPLIT_BINDING_PATCH EMAIL_SUBJECT FILE_PATH_CHANGES GLOBAL_INITIALISERS LINE_SPACING MULTIPLE_ASSIGNMENTS NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Christophe
Christophe Leroy <christophe.leroy@csgroup.eu> writes: > Le 02/06/2020 à 06:12, Ravi Bangoria a écrit : >> kbuild test robot reported few build warnings with hw_breakpoint code >> when compiled with clang[1]. Fix those. >> >> [1]: https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ >> This should have mentioned that some of the errors were recently introduced by your commit. >> Reported-by: kbuild test robot <lkp@intel.com> >> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >> --- >> Note: Prepared on top of powerpc/next. >> >> arch/powerpc/include/asm/hw_breakpoint.h | 3 --- >> include/linux/hw_breakpoint.h | 4 ++++ >> 2 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/hw_breakpoint.h b/arch/powerpc/include/asm/hw_breakpoint.h >> index f42a55eb77d2..cb424799da0d 100644 >> --- a/arch/powerpc/include/asm/hw_breakpoint.h >> +++ b/arch/powerpc/include/asm/hw_breakpoint.h >> @@ -70,9 +70,6 @@ extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, >> unsigned long val, void *data); >> int arch_install_hw_breakpoint(struct perf_event *bp); >> void arch_uninstall_hw_breakpoint(struct perf_event *bp); >> -int arch_reserve_bp_slot(struct perf_event *bp); >> -void arch_release_bp_slot(struct perf_event *bp); >> -void arch_unregister_hw_breakpoint(struct perf_event *bp); >> void hw_breakpoint_pmu_read(struct perf_event *bp); >> extern void flush_ptrace_hw_breakpoint(struct task_struct *tsk); >> >> diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h >> index 6058c3844a76..521481f0d320 100644 >> --- a/include/linux/hw_breakpoint.h >> +++ b/include/linux/hw_breakpoint.h >> @@ -80,6 +80,10 @@ extern int dbg_reserve_bp_slot(struct perf_event *bp); >> extern int dbg_release_bp_slot(struct perf_event *bp); >> extern int reserve_bp_slot(struct perf_event *bp); >> extern void release_bp_slot(struct perf_event *bp); >> +extern int hw_breakpoint_weight(struct perf_event *bp); >> +extern int arch_reserve_bp_slot(struct perf_event *bp); >> +extern void arch_release_bp_slot(struct perf_event *bp); >> +extern void arch_unregister_hw_breakpoint(struct perf_event *bp); > > Please no new 'extern'. In the old days 'extern' keyword was used, but > new code shall not introduce new unnecessary usage of 'extern' keyword. > See report from Checkpatch below: > > WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description > (prefer a maximum 75 chars per line) > #9: > [1]: > https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ > > CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files > #40: FILE: include/linux/hw_breakpoint.h:83: > +extern int hw_breakpoint_weight(struct perf_event *bp); I fixed it up when applying. cheers
On 6/2/20 4:30 PM, Michael Ellerman wrote: > Christophe Leroy <christophe.leroy@csgroup.eu> writes: >> Le 02/06/2020 à 06:12, Ravi Bangoria a écrit : >>> kbuild test robot reported few build warnings with hw_breakpoint code >>> when compiled with clang[1]. Fix those. >>> >>> [1]: https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ >>> > > This should have mentioned that some of the errors were recently > introduced by your commit. Sure, will take care next time. > >>> Reported-by: kbuild test robot <lkp@intel.com> >>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> >>> --- >>> Note: Prepared on top of powerpc/next. >>> >>> arch/powerpc/include/asm/hw_breakpoint.h | 3 --- >>> include/linux/hw_breakpoint.h | 4 ++++ >>> 2 files changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/powerpc/include/asm/hw_breakpoint.h b/arch/powerpc/include/asm/hw_breakpoint.h >>> index f42a55eb77d2..cb424799da0d 100644 >>> --- a/arch/powerpc/include/asm/hw_breakpoint.h >>> +++ b/arch/powerpc/include/asm/hw_breakpoint.h >>> @@ -70,9 +70,6 @@ extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, >>> unsigned long val, void *data); >>> int arch_install_hw_breakpoint(struct perf_event *bp); >>> void arch_uninstall_hw_breakpoint(struct perf_event *bp); >>> -int arch_reserve_bp_slot(struct perf_event *bp); >>> -void arch_release_bp_slot(struct perf_event *bp); >>> -void arch_unregister_hw_breakpoint(struct perf_event *bp); >>> void hw_breakpoint_pmu_read(struct perf_event *bp); >>> extern void flush_ptrace_hw_breakpoint(struct task_struct *tsk); >>> >>> diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h >>> index 6058c3844a76..521481f0d320 100644 >>> --- a/include/linux/hw_breakpoint.h >>> +++ b/include/linux/hw_breakpoint.h >>> @@ -80,6 +80,10 @@ extern int dbg_reserve_bp_slot(struct perf_event *bp); >>> extern int dbg_release_bp_slot(struct perf_event *bp); >>> extern int reserve_bp_slot(struct perf_event *bp); >>> extern void release_bp_slot(struct perf_event *bp); >>> +extern int hw_breakpoint_weight(struct perf_event *bp); >>> +extern int arch_reserve_bp_slot(struct perf_event *bp); >>> +extern void arch_release_bp_slot(struct perf_event *bp); >>> +extern void arch_unregister_hw_breakpoint(struct perf_event *bp); >> >> Please no new 'extern'. In the old days 'extern' keyword was used, but >> new code shall not introduce new unnecessary usage of 'extern' keyword. >> See report from Checkpatch below: >> >> WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description >> (prefer a maximum 75 chars per line) >> #9: >> [1]: >> https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ >> >> CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files >> #40: FILE: include/linux/hw_breakpoint.h:83: >> +extern int hw_breakpoint_weight(struct perf_event *bp); > > I fixed it up when applying. Thanks Michael. Ravi
On Tue, 2 Jun 2020 09:42:08 +0530, Ravi Bangoria wrote: > kbuild test robot reported few build warnings with hw_breakpoint code > when compiled with clang[1]. Fix those. > > [1]: https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ Applied to powerpc/next. [1/1] hw-breakpoints: Fix build warnings with clang https://git.kernel.org/powerpc/c/ef3534a94fdbdeab4c89d18d0164be2ad5d6dbb7 cheers
diff --git a/arch/powerpc/include/asm/hw_breakpoint.h b/arch/powerpc/include/asm/hw_breakpoint.h index f42a55eb77d2..cb424799da0d 100644 --- a/arch/powerpc/include/asm/hw_breakpoint.h +++ b/arch/powerpc/include/asm/hw_breakpoint.h @@ -70,9 +70,6 @@ extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused, unsigned long val, void *data); int arch_install_hw_breakpoint(struct perf_event *bp); void arch_uninstall_hw_breakpoint(struct perf_event *bp); -int arch_reserve_bp_slot(struct perf_event *bp); -void arch_release_bp_slot(struct perf_event *bp); -void arch_unregister_hw_breakpoint(struct perf_event *bp); void hw_breakpoint_pmu_read(struct perf_event *bp); extern void flush_ptrace_hw_breakpoint(struct task_struct *tsk); diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h index 6058c3844a76..521481f0d320 100644 --- a/include/linux/hw_breakpoint.h +++ b/include/linux/hw_breakpoint.h @@ -80,6 +80,10 @@ extern int dbg_reserve_bp_slot(struct perf_event *bp); extern int dbg_release_bp_slot(struct perf_event *bp); extern int reserve_bp_slot(struct perf_event *bp); extern void release_bp_slot(struct perf_event *bp); +extern int hw_breakpoint_weight(struct perf_event *bp); +extern int arch_reserve_bp_slot(struct perf_event *bp); +extern void arch_release_bp_slot(struct perf_event *bp); +extern void arch_unregister_hw_breakpoint(struct perf_event *bp); extern void flush_ptrace_hw_breakpoint(struct task_struct *tsk);
kbuild test robot reported few build warnings with hw_breakpoint code when compiled with clang[1]. Fix those. [1]: https://lore.kernel.org/linuxppc-dev/202005192233.oi9CjRtA%25lkp@intel.com/ Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> --- Note: Prepared on top of powerpc/next. arch/powerpc/include/asm/hw_breakpoint.h | 3 --- include/linux/hw_breakpoint.h | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-)