diff mbox series

[v6,15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting

Message ID 20200514111741.97993-16-ravi.bangoria@linux.ibm.com (mailing list archive)
State Accepted
Commit 514db915e7b33e7eaf8e40192b93380f79b319b5
Headers show
Series powerpc/watchpoint: Preparation for more than one watchpoint | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch warning Failed to apply on branch powerpc/merge (93369d50dc0f266ee67adcc6053c96700236d8be)
snowpatch_ozlabs/apply_patch warning Failed to apply on branch powerpc/next (1f12096aca212af8fad3ef58d5673cde691a1452)
snowpatch_ozlabs/apply_patch warning Failed to apply on branch linus/master (24085f70a6e1b0cb647ec92623284641d8270637)
snowpatch_ozlabs/apply_patch warning Failed to apply on branch powerpc/fixes (249c9b0cd193d983c3a0b00f3fd3b92333bfeebe)
snowpatch_ozlabs/apply_patch warning Failed to apply on branch linux-next (c9529331c7a22b8eb7eb03e1e0e221d0f58b43de)
snowpatch_ozlabs/apply_patch fail Failed to apply to any branch

Commit Message

Ravi Bangoria May 14, 2020, 11:17 a.m. UTC 
Xmon allows overwriting breakpoints because it's supported by only
one DAWR. But with multiple DAWRs, overwriting becomes ambiguous
or unnecessary complicated. So let's not allow it.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Reviewed-by: Michael Neuling <mikey@neuling.org>
---
 arch/powerpc/xmon/xmon.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 30b3e3d99c0d..094bf4715f2c 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1399,6 +1399,10 @@  bpt_cmds(void)
 			printf("Hardware data breakpoint not supported on this cpu\n");
 			break;
 		}
+		if (dabr.enabled) {
+			printf("Couldn't find free breakpoint register\n");
+			break;
+		}
 		mode = 7;
 		cmd = inchar();
 		if (cmd == 'r')