| Message ID | 20200330143153.32800-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | powerpc/44x: Make AKEBONO depends on NET | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (c6624071c338732402e8c726df6a4074473eaa0e) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | warning | Please consider tagging this patch for stable! |
YueHaibing <yuehaibing@huawei.com> writes: > Fix Kconfig warnings: > > WARNING: unmet direct dependencies detected for NETDEVICES > Depends on [n]: NET [=n] > Selected by [y]: > - AKEBONO [=y] && PPC_47x [=y] > > WARNING: unmet direct dependencies detected for ETHERNET > Depends on [n]: NETDEVICES [=y] && NET [=n] > Selected by [y]: > - AKEBONO [=y] && PPC_47x [=y] > > AKEBONO select NETDEVICES and ETHERNET unconditionally, It shouldn't do that, that's the job of a defconfig. It might want to enable NET_VENDOR_IBM iff the config already has NET and other dependencies enabled. So the patch below might work? cheers diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 25ebe634a661..32aac4f40f1b 100644 --- a/arch/powerpc/platforms/44x/Kconfig +++ b/arch/powerpc/platforms/44x/Kconfig @@ -207,9 +207,7 @@ config AKEBONO select PPC4xx_HSTA_MSI select I2C select I2C_IBM_IIC - select NETDEVICES - select ETHERNET - select NET_VENDOR_IBM + imply NET_VENDOR_IBM select IBM_EMAC_EMAC4 if IBM_EMAC select USB if USB_SUPPORT select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > If NET is not set, build fails. Add this dependcy to fix this. > > Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/powerpc/platforms/44x/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig > index 25ebe634a661..394f662d7df2 100644 > --- a/arch/powerpc/platforms/44x/Kconfig > +++ b/arch/powerpc/platforms/44x/Kconfig > @@ -199,6 +199,7 @@ config FSP2 > config AKEBONO > bool "IBM Akebono (476gtr) Support" > depends on PPC_47x > + depends on NET > select SWIOTLB > select 476FPE > select PPC4xx_PCI_EXPRESS > -- > 2.17.1
On 2020/3/31 8:58, Michael Ellerman wrote: > YueHaibing <yuehaibing@huawei.com> writes: >> Fix Kconfig warnings: >> >> WARNING: unmet direct dependencies detected for NETDEVICES >> Depends on [n]: NET [=n] >> Selected by [y]: >> - AKEBONO [=y] && PPC_47x [=y] >> >> WARNING: unmet direct dependencies detected for ETHERNET >> Depends on [n]: NETDEVICES [=y] && NET [=n] >> Selected by [y]: >> - AKEBONO [=y] && PPC_47x [=y] >> >> AKEBONO select NETDEVICES and ETHERNET unconditionally, > > It shouldn't do that, that's the job of a defconfig. > > It might want to enable NET_VENDOR_IBM iff the config already has NET > and other dependencies enabled. > > So the patch below might work? Yes, It works for me, Thanks! Tested-by: YueHaibing <yuehaibing@huawei.com> # build-tested > > cheers > > diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig > index 25ebe634a661..32aac4f40f1b 100644 > --- a/arch/powerpc/platforms/44x/Kconfig > +++ b/arch/powerpc/platforms/44x/Kconfig > @@ -207,9 +207,7 @@ config AKEBONO > select PPC4xx_HSTA_MSI > select I2C > select I2C_IBM_IIC > - select NETDEVICES > - select ETHERNET > - select NET_VENDOR_IBM > + imply NET_VENDOR_IBM > select IBM_EMAC_EMAC4 if IBM_EMAC > select USB if USB_SUPPORT > select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > > > >> If NET is not set, build fails. Add this dependcy to fix this. >> >> Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> arch/powerpc/platforms/44x/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig >> index 25ebe634a661..394f662d7df2 100644 >> --- a/arch/powerpc/platforms/44x/Kconfig >> +++ b/arch/powerpc/platforms/44x/Kconfig >> @@ -199,6 +199,7 @@ config FSP2 >> config AKEBONO >> bool "IBM Akebono (476gtr) Support" >> depends on PPC_47x >> + depends on NET >> select SWIOTLB >> select 476FPE >> select PPC4xx_PCI_EXPRESS >> -- >> 2.17.1 > > . >
Why would a board select a network driver? That is what defconfig files are for! I thin kthe select should just go away.
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 25ebe634a661..394f662d7df2 100644 --- a/arch/powerpc/platforms/44x/Kconfig +++ b/arch/powerpc/platforms/44x/Kconfig @@ -199,6 +199,7 @@ config FSP2 config AKEBONO bool "IBM Akebono (476gtr) Support" depends on PPC_47x + depends on NET select SWIOTLB select 476FPE select PPC4xx_PCI_EXPRESS
Fix Kconfig warnings: WARNING: unmet direct dependencies detected for NETDEVICES Depends on [n]: NET [=n] Selected by [y]: - AKEBONO [=y] && PPC_47x [=y] WARNING: unmet direct dependencies detected for ETHERNET Depends on [n]: NETDEVICES [=y] && NET [=n] Selected by [y]: - AKEBONO [=y] && PPC_47x [=y] AKEBONO select NETDEVICES and ETHERNET unconditionally, If NET is not set, build fails. Add this dependcy to fix this. Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/powerpc/platforms/44x/Kconfig | 1 + 1 file changed, 1 insertion(+)