| Message ID | 20200108130926.45808-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] soc: fsl: qe: remove set but not used variable 'mm_gc' | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (20862247a368dbb75d6e97d82345999adaacf3cc) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Wed, Jan 8, 2020 at 7:12 AM YueHaibing <yuehaibing@huawei.com> wrote: > > drivers/soc/fsl/qe/gpio.c: In function qe_pin_request: > drivers/soc/fsl/qe/gpio.c:163:26: warning: variable mm_gc set but not used [-Wunused-but-set-variable] > > commit 1e714e54b5ca ("powerpc: qe_lib-gpio: use gpiochip data pointer") > left behind this unused variable. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied for next. Thanks. Btw, I find another patch from Chen Zhou fixing the same problem sent earlier. I will add his signed-off-by to the commit for credit too. Regards, Leo > --- > drivers/soc/fsl/qe/gpio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c > index 12bdfd9..ed75198 100644 > --- a/drivers/soc/fsl/qe/gpio.c > +++ b/drivers/soc/fsl/qe/gpio.c > @@ -160,7 +160,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index) > { > struct qe_pin *qe_pin; > struct gpio_chip *gc; > - struct of_mm_gpio_chip *mm_gc; > struct qe_gpio_chip *qe_gc; > int err; > unsigned long flags; > @@ -186,7 +185,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index) > goto err0; > } > > - mm_gc = to_of_mm_gpio_chip(gc); > qe_gc = gpiochip_get_data(gc); > > spin_lock_irqsave(&qe_gc->lock, flags); > -- > 2.7.4 > >
diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c index 12bdfd9..ed75198 100644 --- a/drivers/soc/fsl/qe/gpio.c +++ b/drivers/soc/fsl/qe/gpio.c @@ -160,7 +160,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index) { struct qe_pin *qe_pin; struct gpio_chip *gc; - struct of_mm_gpio_chip *mm_gc; struct qe_gpio_chip *qe_gc; int err; unsigned long flags; @@ -186,7 +185,6 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index) goto err0; } - mm_gc = to_of_mm_gpio_chip(gc); qe_gc = gpiochip_get_data(gc); spin_lock_irqsave(&qe_gc->lock, flags);
drivers/soc/fsl/qe/gpio.c: In function qe_pin_request: drivers/soc/fsl/qe/gpio.c:163:26: warning: variable mm_gc set but not used [-Wunused-but-set-variable] commit 1e714e54b5ca ("powerpc: qe_lib-gpio: use gpiochip data pointer") left behind this unused variable. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/soc/fsl/qe/gpio.c | 2 -- 1 file changed, 2 deletions(-)