| Message ID | 20190411042752.22039-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0235854e1c25069d14512a35ea5cd05372e31fd6 |
| Headers | show |
| Series | MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (8c2ffd9174779014c3fe1f96d9dc3641d9175f00) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 24 lines checked |
On Thu, Apr 11, 2019 at 06:27:52AM +0200, Lukas Bulwahn wrote: > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com > to @linux.ibm.com in commit 1dfddcdb95c4 > ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but > some still remained. > > We update the remaining email addresses in MAINTAINERS, hopefully finally > catching all cases for good. > > Fixes: 1dfddcdb95c4 ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com") > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> For whatever it is worth: Acked-by: Paul E. McKenney <paulmck@linux.ibm.com> > --- > > Tyrel, please take this patch. Thanks. > > MAINTAINERS | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2359e12e4c41..454b3cf36aa4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7439,14 +7439,14 @@ F: drivers/crypto/vmx/ghash* > F: drivers/crypto/vmx/ppc-xlate.pl > > IBM Power PCI Hotplug Driver for RPA-compliant PPC64 platform > -M: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > +M: Tyrel Datwyler <tyreld@linux.ibm.com> > L: linux-pci@vger.kernel.org > L: linuxppc-dev@lists.ozlabs.org > S: Supported > F: drivers/pci/hotplug/rpaphp* > > IBM Power IO DLPAR Driver for RPA-compliant PPC64 platform > -M: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > +M: Tyrel Datwyler <tyreld@linux.ibm.com> > L: linux-pci@vger.kernel.org > L: linuxppc-dev@lists.ozlabs.org > S: Supported > @@ -10388,7 +10388,7 @@ F: arch/arm/mach-mmp/ > > MMU GATHER AND TLB INVALIDATION > M: Will Deacon <will.deacon@arm.com> > -M: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> > +M: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> > M: Andrew Morton <akpm@linux-foundation.org> > M: Nick Piggin <npiggin@gmail.com> > M: Peter Zijlstra <peterz@infradead.org> > -- > 2.17.1 >
On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote: > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com > to @linux.ibm.com in commit 1dfddcdb95c4 > ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but > some still remained. > > We update the remaining email addresses in MAINTAINERS, hopefully finally > catching all cases for good. Perhaps update all the similar addresses in other files too $ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l 315
Joe Perches <joe@perches.com> writes: > On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote: >> Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com >> to @linux.ibm.com in commit 1dfddcdb95c4 >> ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but >> some still remained. >> >> We update the remaining email addresses in MAINTAINERS, hopefully finally >> catching all cases for good. > > Perhaps update all the similar addresses in other files too > > $ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l > 315 A good number of them are no longer valid. So I'm not sure it's worth updating them en masse to addresses that won't ever work. We have git now, we don't need email addresses in files, they're just prone to bitrot like this. Should we just change them all like so? -arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <jwboyer@linux.vnet.ibm.com> +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM) To indicate the author was at IBM when they wrote it? Or should we try and update them with current addresses? Though then the authors might start getting mails they don't want. cheers
On Thu, 2019-04-11 at 22:07 +1000, Michael Ellerman wrote: > Joe Perches <joe@perches.com> writes: > > On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote: > > > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com > > > to @linux.ibm.com in commit 1dfddcdb95c4 > > > ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but > > > some still remained. > > > > > > We update the remaining email addresses in MAINTAINERS, hopefully finally > > > catching all cases for good. > > > > Perhaps update all the similar addresses in other files too > > > > $ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l > > 315 > > A good number of them are no longer valid. So I'm not sure it's worth > updating them en masse to addresses that won't ever work. > > We have git now, we don't need email addresses in files, they're just > prone to bitrot like this. > > Should we just change them all like so? > > -arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <jwboyer@linux.vnet.ibm.com> > +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM) > > To indicate the author was at IBM when they wrote it? If that's desired, perhaps: $ git grep -P --name-only '<?[\w\.]+(?:@| at )linux\.vnet\.ibm\.com>?' | \ grep -vP '\.mailmap|MAINTAINERS' | \ xargs perl -p -i -e 's/<?[\w\.]+(?:@|\ at\ )linux\.vnet\.ibm\.com>?/(IBM)/g' > Or should we try and update them with current addresses? Though then the > authors might start getting mails they don't want. That'd be my preference. If authors get emails they don't want, then those contact emails should be removed.
On Thu, Apr 11, 2019 at 05:27:31AM -0700, Joe Perches wrote: > On Thu, 2019-04-11 at 22:07 +1000, Michael Ellerman wrote: > > Joe Perches <joe@perches.com> writes: > > > On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote: > > > > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com > > > > to @linux.ibm.com in commit 1dfddcdb95c4 > > > > ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but > > > > some still remained. > > > > > > > > We update the remaining email addresses in MAINTAINERS, hopefully finally > > > > catching all cases for good. > > > > > > Perhaps update all the similar addresses in other files too > > > > > > $ git grep --name-only 'linux\.vnet\.ibm\.com' | wc -l > > > 315 > > > > A good number of them are no longer valid. So I'm not sure it's worth > > updating them en masse to addresses that won't ever work. > > > > We have git now, we don't need email addresses in files, they're just > > prone to bitrot like this. > > > > Should we just change them all like so? > > > > -arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer <jwboyer@linux.vnet.ibm.com> > > +arch/powerpc/boot/dts/bamboo.dts: * Josh Boyer (IBM) > > > > To indicate the author was at IBM when they wrote it? > > If that's desired, perhaps: > > $ git grep -P --name-only '<?[\w\.]+(?:@| at )linux\.vnet\.ibm\.com>?' | \ > grep -vP '\.mailmap|MAINTAINERS' | \ > xargs perl -p -i -e 's/<?[\w\.]+(?:@|\ at\ )linux\.vnet\.ibm\.com>?/(IBM)/g' > > > Or should we try and update them with current addresses? Though then the > > authors might start getting mails they don't want. > > That'd be my preference. > > If authors get emails they don't want, then those contact > emails should be removed. I have updated most of mine, with one more installment of patches to go into the next merge window and another into the merge window after that. More churn than I would have expected, though. If my email address were to change again, I would instead go with the "(IBM)" approach and let the git log and MAINTAINERS file keep the contact information. Not that we get to update the git log, of course. ;-) I might not have bothered except for combining with the SPDX-tag commits. Thanx, Paul
On Thu, 2019-04-11 at 06:12 -0700, Paul E. McKenney wrote: > If my email address were > to change again, I would instead go with the "(IBM)" approach and let > the git log and MAINTAINERS file keep the contact information. Not that > we get to update the git log, of course. ;-) Add entries to .mailmap works too.
diff --git a/MAINTAINERS b/MAINTAINERS index 2359e12e4c41..454b3cf36aa4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7439,14 +7439,14 @@ F: drivers/crypto/vmx/ghash* F: drivers/crypto/vmx/ppc-xlate.pl IBM Power PCI Hotplug Driver for RPA-compliant PPC64 platform -M: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> +M: Tyrel Datwyler <tyreld@linux.ibm.com> L: linux-pci@vger.kernel.org L: linuxppc-dev@lists.ozlabs.org S: Supported F: drivers/pci/hotplug/rpaphp* IBM Power IO DLPAR Driver for RPA-compliant PPC64 platform -M: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> +M: Tyrel Datwyler <tyreld@linux.ibm.com> L: linux-pci@vger.kernel.org L: linuxppc-dev@lists.ozlabs.org S: Supported @@ -10388,7 +10388,7 @@ F: arch/arm/mach-mmp/ MMU GATHER AND TLB INVALIDATION M: Will Deacon <will.deacon@arm.com> -M: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> +M: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> M: Andrew Morton <akpm@linux-foundation.org> M: Nick Piggin <npiggin@gmail.com> M: Peter Zijlstra <peterz@infradead.org>
Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com to @linux.ibm.com in commit 1dfddcdb95c4 ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but some still remained. We update the remaining email addresses in MAINTAINERS, hopefully finally catching all cases for good. Fixes: 1dfddcdb95c4 ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com") Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- Tyrel, please take this patch. Thanks. MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)