| Message ID | 20190329154456.27152-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 32eeb5614d3bf166e84fe69bb5f3a51a48cac7a1 |
| Headers | show |
| Series | [-next] ocxl: remove set but not used variables 'tid' and 'lpid' | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch next (9e98c678c2d6ae3a17cb2de55d17f69dddaa231b) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 17 lines checked |
On 3/29/2019 9:14 PM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/misc/ocxl/link.c: In function 'xsl_fault_handler': > drivers/misc/ocxl/link.c:187:17: warning: variable 'tid' set but not used [-Wunused-but-set-variable] > drivers/misc/ocxl/link.c:187:6: warning: variable 'lpid' set but not used [-Wunused-but-set-variable] > > They are never used and can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > drivers/misc/ocxl/link.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c > index d50b861..3be07e9 100644 > --- a/drivers/misc/ocxl/link.c > +++ b/drivers/misc/ocxl/link.c > @@ -184,7 +184,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > u64 dsisr, dar, pe_handle; > struct pe_data *pe_data; > struct ocxl_process_element *pe; > - int lpid, pid, tid; > + int pid; > bool schedule = false; > > read_irq(spa, &dsisr, &dar, &pe_handle); > @@ -192,9 +192,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > > WARN_ON(pe_handle > SPA_PE_MASK); > pe = spa->spa_mem + pe_handle; > - lpid = be32_to_cpu(pe->lpid); > pid = be32_to_cpu(pe->pid); > - tid = be32_to_cpu(pe->tid); > /* We could be reading all null values here if the PE is being > * removed while an interrupt kicks in. It's not supposed to > * happen if the driver notified the AFU to terminate the
On 30/3/19 2:44 am, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/misc/ocxl/link.c: In function 'xsl_fault_handler': > drivers/misc/ocxl/link.c:187:17: warning: variable 'tid' set but not used [-Wunused-but-set-variable] > drivers/misc/ocxl/link.c:187:6: warning: variable 'lpid' set but not used [-Wunused-but-set-variable] > > They are never used and can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > --- > drivers/misc/ocxl/link.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c > index d50b861..3be07e9 100644 > --- a/drivers/misc/ocxl/link.c > +++ b/drivers/misc/ocxl/link.c > @@ -184,7 +184,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > u64 dsisr, dar, pe_handle; > struct pe_data *pe_data; > struct ocxl_process_element *pe; > - int lpid, pid, tid; > + int pid; > bool schedule = false; > > read_irq(spa, &dsisr, &dar, &pe_handle); > @@ -192,9 +192,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > > WARN_ON(pe_handle > SPA_PE_MASK); > pe = spa->spa_mem + pe_handle; > - lpid = be32_to_cpu(pe->lpid); > pid = be32_to_cpu(pe->pid); > - tid = be32_to_cpu(pe->tid); > /* We could be reading all null values here if the PE is being > * removed while an interrupt kicks in. It's not supposed to > * happen if the driver notified the AFU to terminate the >
Le 29/03/2019 à 16:44, Yue Haibing a écrit : > From: YueHaibing <yuehaibing@huawei.com> > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/misc/ocxl/link.c: In function 'xsl_fault_handler': > drivers/misc/ocxl/link.c:187:17: warning: variable 'tid' set but not used [-Wunused-but-set-variable] > drivers/misc/ocxl/link.c:187:6: warning: variable 'lpid' set but not used [-Wunused-but-set-variable] > > They are never used and can be removed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- Acked-by: Frederic Barrat <fbarrat@linux.ibm.com> > drivers/misc/ocxl/link.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c > index d50b861..3be07e9 100644 > --- a/drivers/misc/ocxl/link.c > +++ b/drivers/misc/ocxl/link.c > @@ -184,7 +184,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > u64 dsisr, dar, pe_handle; > struct pe_data *pe_data; > struct ocxl_process_element *pe; > - int lpid, pid, tid; > + int pid; > bool schedule = false; > > read_irq(spa, &dsisr, &dar, &pe_handle); > @@ -192,9 +192,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) > > WARN_ON(pe_handle > SPA_PE_MASK); > pe = spa->spa_mem + pe_handle; > - lpid = be32_to_cpu(pe->lpid); > pid = be32_to_cpu(pe->pid); > - tid = be32_to_cpu(pe->tid); > /* We could be reading all null values here if the PE is being > * removed while an interrupt kicks in. It's not supposed to > * happen if the driver notified the AFU to terminate the >
diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c index d50b861..3be07e9 100644 --- a/drivers/misc/ocxl/link.c +++ b/drivers/misc/ocxl/link.c @@ -184,7 +184,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) u64 dsisr, dar, pe_handle; struct pe_data *pe_data; struct ocxl_process_element *pe; - int lpid, pid, tid; + int pid; bool schedule = false; read_irq(spa, &dsisr, &dar, &pe_handle); @@ -192,9 +192,7 @@ static irqreturn_t xsl_fault_handler(int irq, void *data) WARN_ON(pe_handle > SPA_PE_MASK); pe = spa->spa_mem + pe_handle; - lpid = be32_to_cpu(pe->lpid); pid = be32_to_cpu(pe->pid); - tid = be32_to_cpu(pe->tid); /* We could be reading all null values here if the PE is being * removed while an interrupt kicks in. It's not supposed to * happen if the driver notified the AFU to terminate the