From patchwork Thu Mar 1 23:37:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 880178 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zsprz2XXyz9s75 for ; Fri, 2 Mar 2018 10:42:59 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="D24PaGot"; dkim-atps=neutral Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3zspry2VCvzF1V0 for ; Fri, 2 Mar 2018 10:42:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="D24PaGot"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=linux@rasmusvillemoes.dk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="D24PaGot"; dkim-atps=neutral Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zspkp6ZPSzF1nx for ; Fri, 2 Mar 2018 10:37:35 +1100 (AEDT) Received: by mail-wm0-x244.google.com with SMTP id t3so3405wmc.2 for ; Thu, 01 Mar 2018 15:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZaUHUSqLgmeb9zt7BKghCdQOKTJNG8NtyriwsxI1j6Y=; b=D24PaGotwvPlLaRui+7m5+WW6MK0RBarvgba8Z7vf2/YPm0zapDRpodjUe1ZkHwzNr 7x8ZVMFG7CHApVJs1mzbDW9tOCyRbmGB8tOowjzZd2qwwJTQ93gn9K3rxqGYdGNmmcWv y0VeodPrR7W+nrmq6hypemRD4N5BodNY5IZtQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZaUHUSqLgmeb9zt7BKghCdQOKTJNG8NtyriwsxI1j6Y=; b=snnwZ+56cHZcIhv+bur8uS8Kl6aRW2y0lBVB9VLVzWuYd+J1Ic0l9J49ovmsuELNFP sWdCWVDsLtHkLTKClFmg5Hvc1OfEO8uQeaMT9s0/kefRCC/dk4cEAcnLd/pFLSOz8lbg FAdnsoGLWm9YPiFBIdGVoaPR/1LLWohP6iCTd9OCuSzn82FkpYlHNWzkizkSv5pIUrdZ nyKyrCmCGjJADQmXkKFWXGbTwsE+52pkuMOLsJib+xpBHHTeqBCFNM7Vd7Z006jTxeWf ZOOwzzUvCqxL5mJv57+DIjs1H8HBer0hIPcbvgvWo4PNj9rQIdfl+eis4Sv5/ue/GsxW zUlg== X-Gm-Message-State: APf1xPBDPhddP1uclMSfiaBF0odw6HykgVemB+QjtuGL88Atmdkq8nL6 GOuVk2rPe4VXctsTUGj+k4DqIHfytz4= X-Google-Smtp-Source: AG47ELvG5CAzDigVDFnhL9LJ11L4TERcM+gY0LdLo1IAJ//EA89f/I3RPhi3dqZW9Rvm4ePaudojXQ== X-Received: by 10.80.224.205 with SMTP id j13mr4919957edl.304.1519947453225; Thu, 01 Mar 2018 15:37:33 -0800 (PST) Received: from prevas-ravi.waoo.dk (dhcp-5-186-126-104.cgn.ip.fibianet.dk. [5.186.126.104]) by smtp.gmail.com with ESMTPSA id e12sm4088274edi.29.2018.03.01.15.37.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Mar 2018 15:37:32 -0800 (PST) From: Rasmus Villemoes To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Subject: [RFC 3/5] powerpc/pseries: use seq_open_data in hcall_inst_seq_open Date: Fri, 2 Mar 2018 00:37:22 +0100 Message-Id: <20180301233724.20440-3-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180301233724.20440-1-linux@rasmusvillemoes.dk> References: <20180301233724.20440-1-linux@rasmusvillemoes.dk> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, Rasmus Villemoes , linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" This code should check the return value of seq_open(); if it failed, file->private_data is NULL. But we can avoid the issue entirely and simplify the code by letting seq_open_data() set the ->private member. Signed-off-by: Rasmus Villemoes --- arch/powerpc/platforms/pseries/hvCall_inst.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c index 89b7ce807e70..05990c9fe264 100644 --- a/arch/powerpc/platforms/pseries/hvCall_inst.c +++ b/arch/powerpc/platforms/pseries/hvCall_inst.c @@ -92,14 +92,7 @@ static const struct seq_operations hcall_inst_seq_ops = { static int hcall_inst_seq_open(struct inode *inode, struct file *file) { - int rc; - struct seq_file *seq; - - rc = seq_open(file, &hcall_inst_seq_ops); - seq = file->private_data; - seq->private = file_inode(file)->i_private; - - return rc; + return seq_open_data(file, &hcall_inst_seq_ops, file_inode(file)->i_private); } static const struct file_operations hcall_inst_seq_fops = {