diff mbox series

macintosh/ams-input: Use true and false for boolean values

Message ID 20180124014846.GA27664@embeddedgus (mailing list archive)
State Accepted
Commit 516c32f64f144721ca05b881737e4425932827c5
Headers show
Series macintosh/ams-input: Use true and false for boolean values | expand

Commit Message

Gustavo A. R. Silva Jan. 24, 2018, 1:48 a.m. UTC
Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/macintosh/ams/ams-input.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Hanselmann Jan. 24, 2018, 1:55 a.m. UTC | #1
On 24.01.2018 02:48, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
> 
> This issue was detected with the help of Coccinelle
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Michael Hanselmann <public@hansmi.ch>
Michael Ellerman Jan. 29, 2018, 4:13 a.m. UTC | #2
On Wed, 2018-01-24 at 01:48:46 UTC, "Gustavo A. R. Silva" wrote:
> Assign true or false to boolean variables instead of an integer value.
> 
> This issue was detected with the help of Coccinelle
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Reviewed-by: Michael Hanselmann <public@hansmi.ch>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/516c32f64f144721ca05b881737e44

cheers
diff mbox series

Patch

diff --git a/drivers/macintosh/ams/ams-input.c b/drivers/macintosh/ams/ams-input.c
index 2edae7d..fe248f6 100644
--- a/drivers/macintosh/ams/ams-input.c
+++ b/drivers/macintosh/ams/ams-input.c
@@ -91,7 +91,7 @@  static int ams_input_enable(void)
 		return error;
 	}
 
-	joystick = 1;
+	joystick = true;
 
 	return 0;
 }
@@ -104,7 +104,7 @@  static void ams_input_disable(void)
 		ams_info.idev = NULL;
 	}
 
-	joystick = 0;
+	joystick = false;
 }
 
 static ssize_t ams_input_show_joystick(struct device *dev,