Message ID | 20171103024146.17086-2-cyrilbur@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 44e2aa2b16a872fa8aa4901b3793132e6cfd293a |
Headers | show |
Series | Allow opal-async waiters to get interrupted | expand |
On Fri, 2017-11-03 at 02:41:37 UTC, Cyril Bur wrote: > BUG_ON() should be reserved in situations where we can not longer > guarantee the integrity of the system. In the case where > powernv_flash_async_op() receives an impossible op, we can still > guarantee the integrity of the system. > > Signed-off-by: Cyril Bur <cyrilbur@gmail.com> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/44e2aa2b16a872fa8aa4901b379313 cheers
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c index f5396f26ddb4..f9ec38281ff2 100644 --- a/drivers/mtd/devices/powernv_flash.c +++ b/drivers/mtd/devices/powernv_flash.c @@ -78,7 +78,9 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op, rc = opal_flash_erase(info->id, offset, len, token); break; default: - BUG_ON(1); + WARN_ON_ONCE(1); + opal_async_release_token(token); + return -EIO; } if (rc != OPAL_ASYNC_COMPLETION) {