From patchwork Mon May 29 13:26:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Murilo_Opsfelder_Ara=C3=BAjo?= X-Patchwork-Id: 768272 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wc27Z59slz9s06 for ; Tue, 30 May 2017 02:22:02 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DzLZYno7"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wc27Z48q2zDqFT for ; Tue, 30 May 2017 02:22:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DzLZYno7"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-qk0-x243.google.com (mail-qk0-x243.google.com [IPv6:2607:f8b0:400d:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wbyF86lRDzDqBJ for ; Mon, 29 May 2017 23:26:36 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DzLZYno7"; dkim-atps=neutral Received: by mail-qk0-x243.google.com with SMTP id v195so1175906qka.2 for ; Mon, 29 May 2017 06:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JsoFHSc3ew5koFliNRvV3eLrNu22McQUp8Geeu8oTxA=; b=DzLZYno7gfCNQGqwD3xy8RRk8kTiJ0v2GQn2hb4OICpI4hefpivzHK1cqqPHS/fsLo xD8jV/xHi4dtAWvtPSKjsBEngbcvhnwZ+Y27tRVw2eAlCOdNvfi3hY5t39lvHgdRveAk IR6ZkxXU7tsr7d3Clon5blp8LBlVzudGtTqABCNoSpNVk7qkLgY+dfyuadOBur3L9LdK Aim4MVQsylByPDZJljYfmETrGHCZ0Oc3oZaVK/0QnOGDCskh3cDp5JaZ74G+2VgdEr3S oa6clrUWQ84ZqEPDdCgXO45CA6ajjNK81NshyrdRPmlEdSZIdGfW0dpRMz2rRQ0o/S4h HH5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JsoFHSc3ew5koFliNRvV3eLrNu22McQUp8Geeu8oTxA=; b=qapL8IY2RpNQviAq3mhinHJFSim88rn9T14nfjk+te1SMZ12jNhjqkMMTVIyZ+K52J luoLzKnWpDg224Dj9sG9AhUosZ0z8B/Xdo/Ip341DYkeZhqzsze2J5FwCjhMcQ8zTw50 gSKVxyRITCV0qdgMMMUwFuXhM1dJhXg20DVbaWB+105+EilgZTxYKi/OvIxTBXQwSlbn /lXhjICYRLsrlAfmVzdsPalCiOFSPchytRMam/I+048paIc2QuSlw2gf7lXZkY/q5RrQ epOtL7WrBOLp4ESsgaGAacH8Syu+YIqoyTrRQ41L0gwRPrBN3XSOOd1jFITSsDT/sDKe v6/w== X-Gm-Message-State: AODbwcB9WNnS4leKC5OhwqY9mard7dgol2ed/XcJ8crFEMmZ1mq6eBzk GkscTPDrYUYqxQ== X-Received: by 10.233.232.213 with SMTP id a204mr15569234qkg.173.1496064394380; Mon, 29 May 2017 06:26:34 -0700 (PDT) Received: from kermit-br-ibm-com.ibmmodules.com ([2804:431:f725:be5c:1884:56f6:2561:a21e]) by smtp.gmail.com with ESMTPSA id t35sm6347274qta.62.2017.05.29.06.26.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 May 2017 06:26:33 -0700 (PDT) From: Murilo Opsfelder Araujo To: linux-kernel@vger.kernel.org Subject: [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Date: Mon, 29 May 2017 10:26:28 -0300 Message-Id: <20170529132628.10803-1-mopsfelder@gmail.com> X-Mailer: git-send-email 2.9.4 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 30 May 2017 02:20:45 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-watchdog@vger.kernel.org, Murilo Opsfelder Araujo , Wim Van Sebroeck , linuxppc-dev@lists.ozlabs.org, Guenter Roeck Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c, which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without setting CONFIG_PPC_RTAS throws the following errors: ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined! ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined! ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined! ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined! ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined! This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and CONFIG_PPC_RTAS was not set. Logs are here: http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/ This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just CONFIG_PPC_RTAS, removing COMPILE_TEST entirely. Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: Guenter Roeck Acked-by: Michael Ellerman --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 8b9049d..e6e31a1 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -1688,7 +1688,7 @@ config MEN_A21_WDT config WATCHDOG_RTAS tristate "RTAS watchdog" - depends on PPC_RTAS || (PPC64 && COMPILE_TEST) + depends on PPC_RTAS help This driver adds watchdog support for the RTAS watchdog.