From patchwork Thu May 4 10:41:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 758494 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wJWnx3FB0z9ryr for ; Thu, 4 May 2017 20:43:01 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="J9wX0xW0"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wJWnx27BmzDqFH for ; Thu, 4 May 2017 20:43:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="J9wX0xW0"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wJWmJ4DZXzDqBJ for ; Thu, 4 May 2017 20:41:36 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="J9wX0xW0"; dkim-atps=neutral Received: by mail-pf0-x244.google.com with SMTP id v14so1594287pfd.3 for ; Thu, 04 May 2017 03:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=1R8COCSdnVkJK3YhAWGtGR26Gtw0FpNF40NxqEK1Fj0=; b=J9wX0xW0jrUnFfrhsC1yX5BADV5Gie7mcsAZ0/cfvPU80fVwiao9N+whKBNppB3DCJ 2+AtmObIP0V/topt8zCS6+wzWTeuD6oNsERFp+H1OISwq4BfgNjKzM6tnXidTG6JWHNY B+AGIrH+3zITcWtrcjuT0GlJ884DL6YHhas6Ig3EAFAO0lJmjlhquRV6iRrbiX183ivw a0lYNPMhuLnfL4h31OvgJGMXwnWkzC2y6s33M5hAmAzuXTawKWdmzjuBmW3DikgjPerP H7MeKTH5a4ek/E24BN/HPDHGLCJriLDIeZwaBBi52mNcGk6qn3/sZLFKW9gzL100yA/k GaJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=1R8COCSdnVkJK3YhAWGtGR26Gtw0FpNF40NxqEK1Fj0=; b=MhMR1JAMxuvJQQsYgDpTyKHgdb1WnbXL06bYWEZXijVMvBNJF9c/rkZw2h4o8Twxst qbSSKrCRYPfYpY58tjL38xfoKjDK8LigXoXweJJsvWEIr1TIHgOZQHM+iLjZAFzYZ/bI qzAWtmQ9d0SMDa1H9QCBPshwN5Gzy6LlNnwvKmckUAUci34nNybuDOd1C1tulhxYJ7oa mk8VSNFFeIB9v7LVY457GgD9/V0VEp/J6nkn0A5cuhY5nTctLQgimCdYkOFucTHRETDv SyL122SK8GC7TBiVf/ZO5oiWuVBPo66xQZHojqGagVcQ6mP0fEhuxGBSwmLjXBNF89o2 o4Sg== X-Gm-Message-State: AN3rC/7ehDB+vg3dKd9roT5pS5SuDRbN/fwxdwJc45hpqQ8nSerTw7up HN1fcFtsJOVEDA== X-Received: by 10.99.240.83 with SMTP id s19mr44501978pgj.45.1493894493197; Thu, 04 May 2017 03:41:33 -0700 (PDT) Received: from roar.ozlabs.ibm.com (59-102-70-13.tpgi.com.au. [59.102.70.13]) by smtp.gmail.com with ESMTPSA id a77sm3668730pfe.33.2017.05.04.03.41.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 May 2017 03:41:32 -0700 (PDT) Date: Thu, 4 May 2017 20:41:12 +1000 From: Nicholas Piggin To: Abdul Haleem Subject: Re: [linux-next][bisected 1945bc45] build brakes for PowerPC BE configuration on LPAR Message-ID: <20170504204112.130d7735@roar.ozlabs.ibm.com> In-Reply-To: <1493889859.7355.17.camel@abdul.in.ibm.com> References: <1493889859.7355.17.camel@abdul.in.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sachinp , Stephen Rothwell , ego , linux-kernel , mahesh@linux.vnet.ibm.com, linuxppc-dev Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 04 May 2017 14:54:19 +0530 Abdul Haleem wrote: > Hi, > > linux-next build fails on BE config with next-20170424 onwards > > the patch https://lkml.org/lkml/2017/4/20/994 fixes a similar issue > with kvm guest build failure. > > arch/powerpc/kernel/exceptions-64s.S: Assembler messages: > arch/powerpc/kernel/exceptions-64s.S:395: Error: operand out of range > (0xffffffffffff8280 is not between 0x0000000000000000 and > 0x000000000000ffff) > make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1 > > Bisection resulted with the below bad commit. > > commit 1945bc4549e5cb1f9aa873ec29191aa54dc851d > Author: Nicholas Piggin > Date: Wed Apr 19 23:05:47 2017 +1000 > > powerpc/64s: Fix POWER9 machine check handler from stop state > > Reviewed-by: Gautham R. Shenoy > Reviewed-by: Mahesh J Salgaonkar > Signed-off-by: Nicholas Piggin > Signed-off-by: Michael Ellerman > > arch/powerpc/include/asm/reg.h | 1 + > arch/powerpc/kernel/exceptions-64s.S | 79 ++++++++++++++++++++++++++++++++++++++++++++----------------------------------- > arch/powerpc/kernel/idle_book3s.S | 25 +++++++++++++++++++++++++ > 3 files changed, 70 insertions(+), 35 deletions(-) > > the BE configuration file is attached. > Thanks for the report. I wouldn't reproduce it with this config. I suspect the following patch should fix it, can you test? powerpc/64s: Fix unnecessary machine check handler relocation branch Similarly to 2563a70c3b ("powerpc/64s: Remove unnecessary relocation branch from idle handler"), the machine check handler has a BRANCH_TO from relocated to relocated code, which is unnecessary. It has also caused build errors with some toolchains: arch/powerpc/kernel/exceptions-64s.S: Assembler messages: arch/powerpc/kernel/exceptions-64s.S:395: Error: operand out of range (0xffffffffffff8280 is not between 0x0000000000000000 and 0x000000000000ffff) Fixes: 1945bc4549 ("powerpc/64s: Fix POWER9 machine check handler from stop state") Signed-off-by: Nicholas Piggin --- arch/powerpc/kernel/exceptions-64s.S | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index 3840a7700285..ef72065f684c 100644 --- a/arch/powerpc/kernel/exceptions-64s.S +++ b/arch/powerpc/kernel/exceptions-64s.S @@ -391,9 +391,7 @@ EXC_COMMON_BEGIN(machine_check_handle_early) */ BEGIN_FTR_SECTION rlwinm. r11,r12,47-31,30,31 - beq- 4f - BRANCH_TO_COMMON(r10, machine_check_idle_common) -4: + bne machine_check_idle_common END_FTR_SECTION_IFSET(CPU_FTR_HVMODE | CPU_FTR_ARCH_206) #endif