From patchwork Fri Feb 3 11:45:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 723585 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vFFTD4Sl7z9s75 for ; Fri, 3 Feb 2017 22:46:56 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gAxDvHg2"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vFFTD3RnczDqFq for ; Fri, 3 Feb 2017 22:46:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gAxDvHg2"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vFFRn1HSmzDqBZ for ; Fri, 3 Feb 2017 22:45:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gAxDvHg2"; dkim-atps=neutral Received: by mail-pf0-x241.google.com with SMTP id e4so1450394pfg.0 for ; Fri, 03 Feb 2017 03:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:in-reply-to:references:organization :mime-version:content-transfer-encoding; bh=mAeF+kbfTg+etTx9+WP07Kaq0xY51sh9n3+7X/2xyP4=; b=gAxDvHg2ntXavxpG2pHQUaaK0wvfapvC0FlAzr4V/kQfjpqpZ0plJ5X6ZwpgFA37FC XdbcpGYPNzJK/g9RkeahkbxEu5h1Q3OLOtaxiY0DWt9PSONm29CavR4q8YqzCTP6oyna IhcHTFV3G30gi9XQscO08NZaL6lOuL57IUg7jpFbiFSZjcq0Tcmrm8oWkhfJvbMB/Uh0 w5TBjJRABmzwjfq5qYz+DhyzNkF6X6hT94eBSpYhjN15iuSg3H5AutFAwm3+qYW3ZV2T SFHAFG4/ez34Xj0w7LQTyd8+Mtej171etGUYDjKuufUAfhVnfJiQZzfaogxqecEymzsc q2Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=mAeF+kbfTg+etTx9+WP07Kaq0xY51sh9n3+7X/2xyP4=; b=jxpbBnlf2g7td8YkeasbQ9uyrCwgamMPONDO/7LNdqPC5FN+bKVokyjXx3BgOUcpAO zTPBjxjyx57bVpS4EyXwqWhVh3vabmq2vM6oMq+fL1YQ7vCQeDWpZyzp6uB3IMItivaO IdyNjricl0y1UgUEe0PfGvJucmaPp1HEtV8VZ7E95Lu8C+vGI6YCI54oREtvlEwiffLk whIVJIz5wvLyUpeWOEf0UTkDkXdcMHaYEoXT6SMWOPuVHBv8n2qFRutw+JPi8lXjeTTk yMxo82G1R1nY8Vot4Vre+ZYDShT7Xn/4H8ZVvcwqqxIvmpac5LswTyEu/cP6kSRlVxbU +GhA== X-Gm-Message-State: AIkVDXIstnioRkC8wKBD8SVDViR6S6gZYDbQczhbVGi5jrKmmz1Om1Bx4B6MYSNGf8oHCw== X-Received: by 10.84.217.221 with SMTP id d29mr20498093plj.47.1486122337649; Fri, 03 Feb 2017 03:45:37 -0800 (PST) Received: from roar.ozlabs.ibm.com ([203.220.153.130]) by smtp.gmail.com with ESMTPSA id s26sm67132493pge.33.2017.02.03.03.45.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Feb 2017 03:45:36 -0800 (PST) Date: Fri, 3 Feb 2017 21:45:24 +1000 From: Nicholas Piggin To: linuxppc-dev@lists.ozlabs.org, Michael Ellerman Subject: Re: [PATCH 07/10] powerpc: add NMI IPI infrastructure Message-ID: <20170203214524.3ad3729a@roar.ozlabs.ibm.com> In-Reply-To: <20161219183011.28310-8-npiggin@gmail.com> References: <20161219183011.28310-1-npiggin@gmail.com> <20161219183011.28310-8-npiggin@gmail.com> Organization: IBM X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 20 Dec 2016 04:30:08 +1000 Nicholas Piggin wrote: > +static void do_smp_send_nmi_ipi(int cpu) > +{ > + if (cpu >= 0) { > + do_message_pass(cpu, PPC_MSG_NMI_IPI); > + } else { > + unsigned int c; > + > + for_each_online_cpu(c) { > + if (c == raw_smp_processor_id()) > + continue; > + do_message_pass(cpu, PPC_MSG_NMI_IPI); Okay this has a bug in the fallback path. Needs the following incremental patch. sysrq+x works okay with this (tested in mambo), and also recovers with "x" okay. Thanks, Nick --- arch/powerpc/kernel/smp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c index 81256522985d..a9f8c70d1033 100644 --- a/arch/powerpc/kernel/smp.c +++ b/arch/powerpc/kernel/smp.c @@ -420,12 +420,12 @@ static void do_smp_send_nmi_ipi(int cpu) if (cpu >= 0) { do_message_pass(cpu, PPC_MSG_NMI_IPI); } else { - unsigned int c; + int c; for_each_online_cpu(c) { if (c == raw_smp_processor_id()) continue; - do_message_pass(cpu, PPC_MSG_NMI_IPI); + do_message_pass(c, PPC_MSG_NMI_IPI); } } }