From patchwork Thu Nov 17 09:40:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boqun Feng X-Patchwork-Id: 696049 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tKGPh379Yz9t1L for ; Thu, 17 Nov 2016 20:42:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Cc4p8I/q"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tKGPh23PXzDw8G for ; Thu, 17 Nov 2016 20:42:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Cc4p8I/q"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tKGN40TMgzDrBv for ; Thu, 17 Nov 2016 20:41:08 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Cc4p8I/q"; dkim-atps=neutral Received: by mail-pg0-x241.google.com with SMTP id e9so16829260pgc.1 for ; Thu, 17 Nov 2016 01:41:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=7YfmImkWiqPOr7ETkAS6Wud+cP6EYWAwnX/Vy85SInA=; b=Cc4p8I/qiCGXIwcNyCSJIerzq1CBulQpckXTkFRslx3Wy4UNLFPcFp3WKSfNt72Tff MW2qUSRoH9ePdsB9vCGFLAbNrq2P87UW/Jo0En53iHZ4I+RkxUMzdVIBm78i32bXpKUK 38SE78zg7hry8TwbxP6ZTDLHWUQJCcPuYu6qlpyePEru6eW8/XhNBBwZHDcc4M34Cvus KhCqlExDvaeoE3PaCp/DJ4qjYTO2iuDY+055W0oxXhDbwkG8IqtwzTG/BbgSxTNH+xfF acQxm5dEZASnsF+mflMeqBolDrdnhb1qO57pf6E76cAovx5QfU43YMTplTnzHhjVlN5v gNsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7YfmImkWiqPOr7ETkAS6Wud+cP6EYWAwnX/Vy85SInA=; b=U3UenP0+cHrgYofpiHe7R4c2ZoaHieuy6ITbDMv9lKGafOi4xhLvBdmIum0MUJ7QKI txtt3PDnpJ/ITlQAh/Rv3mbyyj2b2bTLbGvv7ZYe0tNq3NNYdYjFigLjFkQDgk0rmUo0 Yxq8OqgqahA9c5vnSNgH428+Xmv2l4NAlgVc4pIfCpST3X0PlAUkWFVqQXVaMbfXSr0u K6VQ46ZxyueqcnzIP1j2VI3NlQIJ79JZgtKqMTF1aOvs8Zaurb/eR/Cm8sh4wxl+XK9l iqQRKFDOc+EfxmZ5Hznt5oc3/JYBK22zcahnU1hvtlYp2rfz67uQGufLcuBhi6m1fxbc THhQ== X-Gm-Message-State: ABUngvcF+NpSWdMbUyWgUmOepoMLWn21n1sk/aSaRtxLAdiGyQzhosVAIbuXM6M6cHRGqA== X-Received: by 10.99.96.85 with SMTP id u82mr5654205pgb.47.1479375666365; Thu, 17 Nov 2016 01:41:06 -0800 (PST) Received: from localhost ([45.32.128.109]) by smtp.gmail.com with ESMTPSA id o26sm5191355pfk.91.2016.11.17.01.41.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Nov 2016 01:41:05 -0800 (PST) From: Boqun Feng To: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [RFC] powerpc: xmon: Add address lookup for percpu symbols Date: Thu, 17 Nov 2016 17:40:35 +0800 Message-Id: <20161117094051.21606-1-boqun.feng@gmail.com> X-Mailer: git-send-email 2.10.1 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Douglas Miller , Boqun Feng , Rashmica Gupta , Paul Mackerras , "Aneesh Kumar K.V" , Andrew Donnellan Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Currently, in xmon, there is no obvious way to get an address for a percpu symbol for a particular cpu. Having such an ability would be good for debugging the system when percpu variables got involved. Therefore, this patch introduces a new xmon command "lp" to lookup the address for percpu symbols. Usage of "lp" is similar to "ls", except that we could add a cpu number to choose the variable of which cpu we want to lookup. If no cpu number is given, lookup for current cpu. Signed-off-by: Boqun Feng --- arch/powerpc/xmon/xmon.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 760545519a0b..3556966a29a5 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -229,6 +229,7 @@ Commands:\n\ f flush cache\n\ la lookup symbol+offset of specified address\n\ ls lookup address of specified symbol\n\ + lp s [#] lookup address of percpu symbol s for current cpu, or cpu #\n\ m examine/change memory\n\ mm move a block of memory\n\ ms set a block of memory\n\ @@ -2943,7 +2944,7 @@ static void symbol_lookup(void) { int type = inchar(); - unsigned long addr; + unsigned long addr, cpu, offset; static char tmp[64]; switch (type) { @@ -2967,6 +2968,31 @@ symbol_lookup(void) catch_memory_errors = 0; termch = 0; break; + case 'p': + getstring(tmp, 64); + if (setjmp(bus_error_jmp) == 0) { + catch_memory_errors = 1; + sync(); + addr = kallsyms_lookup_name(tmp); + sync(); + } + + if (scanhex(&cpu) && cpu < num_possible_cpus()) + offset = per_cpu_offset(cpu); + else { + offset = my_cpu_offset; + cpu = raw_smp_processor_id(); + } + + if (addr) + printf("%s for cpu 0x%lx: %lx\n", tmp, cpu, + addr + offset); + else + printf("Percpu symbol '%s' not found.\n", tmp); + + catch_memory_errors = 0; + termch = 0; + break; } }