| Message ID | 20161030213451.24624-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 31/10/16 08:34, Christophe JAILLET wrote: > 'cxl_dev_context_init()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > --- > un-compiled because I don't have the required cross build environment. Builds fine here. In future, you might want to bundle all 3 of your patches either into 1 patch (while they are changes which can be done separately, it's all fixes to one type of problem in relation to one function, so personally I'm okay with that) or send it as a series, so that it's clear to everyone that they're all related fixes. Additionally, having the same patch subject line for two patches sent in short succession is a bit confusing - in future, try and avoid that. Andrew
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes: > On 31/10/16 08:34, Christophe JAILLET wrote: >> 'cxl_dev_context_init()' returns an error pointer in case of error, not >> NULL. So test it with IS_ERR. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > >> --- >> un-compiled because I don't have the required cross build environment. > > Builds fine here. > > In future, you might want to bundle all 3 of your patches either into 1 > patch (while they are changes which can be done separately, it's all > fixes to one type of problem in relation to one function, so personally > I'm okay with that) or send it as a series, so that it's clear to > everyone that they're all related fixes. > Additionally, having the same patch subject line for two patches sent in > short succession is a bit confusing - in future, try and avoid that. Yeah. I actually assumed it was two versions of the same patch. cheers
Le 30/10/2016 à 22:34, Christophe JAILLET a écrit : > 'cxl_dev_context_init()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
On Sun, 2016-10-30 at 21:34:51 UTC, Christophe Jaillet wrote: > 'cxl_dev_context_init()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> > Acked-by: Ian Munsie <imunsie@au1.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/28e323e5a0b21b3665eb6e136ca8bb cheers
diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c index 2b88ad8a2a89..e2efc6489c6e 100644 --- a/drivers/misc/cxl/api.c +++ b/drivers/misc/cxl/api.c @@ -538,7 +538,7 @@ int _cxl_cx4_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) if (remaining > 0) { new_ctx = cxl_dev_context_init(pdev); - if (!new_ctx) { + if (IS_ERR(new_ctx)) { pr_warn("%s: Failed to allocate enough contexts for MSIs\n", pci_name(pdev)); return -ENOSPC; }
'cxl_dev_context_init()' returns an error pointer in case of error, not NULL. So test it with IS_ERR. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- un-compiled because I don't have the required cross build environment. --- drivers/misc/cxl/api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)