diff mbox

ibmvfc: prevent a potential deadlock

Message ID 20160715111857.GC13153@mwanda (mailing list archive)
State Not Applicable
Headers show

Commit Message

Dan Carpenter July 15, 2016, 11:18 a.m. UTC 
My static checker complains that we need to unlock on this path.  Seems
true.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Brian King July 15, 2016, 1:38 p.m. UTC | #1 
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Martin K. Petersen July 15, 2016, 7:14 p.m. UTC | #2 
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:

Dan> My static checker complains that we need to unlock on this path.
Dan> Seems true.

Applied to 4.8/scsi-queue.
diff mbox

Patch

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index fc523c3..ab67ec4 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -4722,6 +4722,8 @@  static void ibmvfc_rport_add_thread(struct work_struct *work)
 					tgt_dbg(tgt, "Setting rport roles\n");
 					fc_remote_port_rolechg(rport, tgt->ids.roles);
 					put_device(&rport->dev);
+				} else {
+					spin_unlock_irqrestore(vhost->host->host_lock, flags);
 				}
 
 				kref_put(&tgt->kref, ibmvfc_release_tgt);