From patchwork Thu Jan 7 20:38:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 564448 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8C60D1402D8 for ; Fri, 8 Jan 2016 07:40:05 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=N6tEjA7b; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 606351A076F for ; Fri, 8 Jan 2016 07:40:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=N6tEjA7b; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com [IPv6:2607:f8b0:400e:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id B119E1A0202 for ; Fri, 8 Jan 2016 07:38:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=N6tEjA7b; dkim-atps=neutral Received: by mail-pa0-x234.google.com with SMTP id uo6so248892419pac.1 for ; Thu, 07 Jan 2016 12:38:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=A/fw2qzvms0JSNUshL2FsPaLcwDtJQvE3TSgg6C7MlA=; b=N6tEjA7bfXpUoetgXx7OWB6hNdzAEflgf4ni49/C5nV4mT33DiHBT91fxSdKdqoZug XJYDsTQizPL2OlVSSE44dEsbSrdMqOOr9txBVeaVU56PtuEjRGC6fH4wfhdmvQ7J5p30 Fdr1RmsPV79BnroxLy+UwpvLlBNpGOUyJ1/9064PQ1nkblWjpWto7LuBP0mKWOVbMITa TO+0DNB39QGPVzdqSIDhFt/hn9gHixQYJO98EhLiR3o1yE0Ng3+nJGg7kkKgs4I7QofW dhODymPh6x925rmosBYKh3aEeCvskPtNlk9VZDAglYdiGswp+XXCR9i45063Bbwzy1TA Jp7A== X-Received: by 10.66.100.135 with SMTP id ey7mr156120019pab.108.1452199122021; Thu, 07 Jan 2016 12:38:42 -0800 (PST) Received: from google.com ([2620:0:1000:1301:a0c7:6a2c:8427:c983]) by smtp.gmail.com with ESMTPSA id qj8sm20615623pac.40.2016.01.07.12.38.41 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 07 Jan 2016 12:38:41 -0800 (PST) Date: Thu, 7 Jan 2016 12:38:39 -0800 From: Brian Norris To: Joe Perches Subject: [PATCH] misc: cxl: fix build for GCC 4.6.x Message-ID: <20160107203839.GA42481@google.com> References: <20160107185406.GA65420@google.com> <1452195444.4028.21.camel@perches.com> <568EC026.2020207@suse.com> <1452196651.4028.31.camel@perches.com> <20160107201826.GA120952@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160107201826.GA120952@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Neuling , Arnd Bergmann , Anton Blanchard , linux-kernel@vger.kernel.org, Michal Marek , Ian Munsie , Olof Johansson , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" GCC 4.6.3 does not support -Wno-unused-const-variable. Instead, use the kbuild infrastructure that checks if this options exists. Also drop -Werror, since it's harmful, if forced on the user. New GCC's, or higher warning verbosities (e.g., W=1) can easily kill the build where they shouldn't. Suggested-by: Michal Marek Signed-off-by: Brian Norris --- On Thu, Jan 07, 2016 at 12:18:26PM -0800, Brian Norris wrote: > On Thu, Jan 07, 2016 at 11:57:31AM -0800, Joe Perches wrote: > > On Thu, 2016-01-07 at 20:44 +0100, Michal Marek wrote: > > > We have cc-disable-warning for this. > > > > Thanks Michal. > > Cool, thanks! I'll send a patch to use that instead. drivers/misc/cxl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/Makefile b/drivers/misc/cxl/Makefile index 6982f603fadc..0163d4d1fd1e 100644 --- a/drivers/misc/cxl/Makefile +++ b/drivers/misc/cxl/Makefile @@ -1,4 +1,4 @@ -ccflags-y := -Werror -Wno-unused-const-variable +ccflags-y := $(call cc-disable-warning, unused-const-variable) cxl-y += main.o file.o irq.o fault.o native.o cxl-y += context.o sysfs.o debugfs.o pci.o trace.o