From patchwork Fri Dec 11 12:41:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Petr Mladek X-Patchwork-Id: 555750 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E52ED1402A9 for ; Fri, 11 Dec 2015 23:47:04 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id C96F81A2D18 for ; Fri, 11 Dec 2015 23:47:04 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 831D11A1A1B for ; Fri, 11 Dec 2015 23:42:04 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 555D2AC08; Fri, 11 Dec 2015 12:42:00 +0000 (UTC) Date: Fri, 11 Dec 2015 13:41:59 +0100 From: Petr Mladek To: Geert Uytterhoeven Subject: Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Message-ID: <20151211124159.GB3729@pathway.suse.cz> References: <1449667265-17525-1-git-send-email-pmladek@suse.com> <1449667265-17525-5-git-send-email-pmladek@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux MIPS Mailing List , Daniel Thompson , Jiri Kosina , Cris , linux-s390 , Peter Zijlstra , the arch/x86 maintainers , "linux-kernel@vger.kernel.org" , Steven Rostedt , "adi-buildroot-devel@lists.sourceforge.net" , Ingo Molnar , Linux-sh list , sparclinux , Russell King , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri 2015-12-11 12:10:02, Geert Uytterhoeven wrote: > On Wed, Dec 9, 2015 at 2:21 PM, Petr Mladek wrote: > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -866,6 +866,28 @@ config LOG_CPU_MAX_BUF_SHIFT > > 13 => 8 KB for each CPU > > 12 => 4 KB for each CPU > > > > +config NMI_LOG_BUF_SHIFT > > + int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)" > > + range 10 21 > > + default 13 > > + depends on PRINTK && HAVE_NMI > > Symbol NMI_LOG_BUF_SHIFT does not exist if its dependencies are not met. Åh, the NMI buffer is enabled on arm via NEED_PRINTK_NMI. The buffer is compiled when CONFIG_PRINTK_NMI is defined. I am going to fix it the following way: Thanks a lot for report, Petr Acked-by: Arnd Bergmann Acked-by: Geert Uytterhoeven diff --git a/init/Kconfig b/init/Kconfig index efcff25a112d..61cfd96a3c96 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -870,7 +870,7 @@ config NMI_LOG_BUF_SHIFT int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)" range 10 21 default 13 - depends on PRINTK && HAVE_NMI + depends on PRINTK_NMI help Select the size of a per-CPU buffer where NMI messages are temporary stored. They are copied to the main log buffer in a safe context