From patchwork Mon Sep 8 06:13:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Turquette X-Patchwork-Id: 386793 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 91B301400D5 for ; Mon, 8 Sep 2014 16:14:51 +1000 (EST) Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by lists.ozlabs.org (Postfix) with ESMTP id 7482B1A0B6B for ; Mon, 8 Sep 2014 16:14:51 +1000 (EST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 642C71A00FA for ; Mon, 8 Sep 2014 16:14:12 +1000 (EST) Received: by mail-pa0-f51.google.com with SMTP id kx10so2342192pab.24 for ; Sun, 07 Sep 2014 23:14:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version :content-transfer-encoding:to:from:in-reply-to:cc:references :message-id:user-agent:subject:date; bh=rswn+9KXnbK5QoA6hKojfnWiqZdrJPFt27x6uHG+/zQ=; b=blLytxHROQp2zCPZAch49+x2u9AT2qZrx0Wi3FygT445kW84AAkdAt0V1PKPhiXOTc zGRrqqBOh/PCyNrhtShnPuTQEsIN4FkztKMN7wt1uV9onYVtEioKMw7063bhDQPvXPBQ MDLOWmfXakX696vwloJ+I1J8O8iI0hgZlaoW5O6T5+2GlfIQ/t4nxoEFp7eKDBASyZRP ZAT52WSUedJl5uE/Tvk8PJ4elg0k3YZTHb8gE1UL6qUG6f4MXnkqbxl10i1vZg5hNBnp 4awQ+eH+bICFz5uNv/02DBkOMzjtOUWCIvouYEMEd4x6jbXuLWCxcuOkkDRkt+XgHbns gFkQ== X-Gm-Message-State: ALoCoQn5DG2F0gWufc7XSbUV6WgSREYpEDQ0fGbL/phoFgxplcm9m1v4XqKxPXAnCNZ6HzsXWp/R X-Received: by 10.70.131.12 with SMTP id oi12mr44520083pdb.116.1410156849660; Sun, 07 Sep 2014 23:14:09 -0700 (PDT) Received: from localhost (pool-108-47-66-231.lsanca.fios.verizon.net. [108.47.66.231]) by mx.google.com with ESMTPSA id j13sm7837384pbq.42.2014.09.07.23.14.08 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 07 Sep 2014 23:14:08 -0700 (PDT) MIME-Version: 1.0 To: Tomeu Vizoso , From: Mike Turquette In-Reply-To: <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> References: <1409758148-20104-2-git-send-email-tomeu.vizoso@collabora.com> <1409758317-20564-1-git-send-email-tomeu.vizoso@collabora.com> Message-ID: <20140908061355.19023.47997@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH v9 2/6] clk: Move all drivers to use internal API Date: Sun, 07 Sep 2014 23:13:55 -0700 Cc: Ulf Hansson , Prashant Gaikwad , "Stephen Warren , Thierry Reding , tomasz.figa@gmail.com, Peter De Schrijver , rabin@rab.in, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Russell King , Shawn Guo , Sascha Hauer , David Brown , Daniel Walker , Bryan Huntsman , Paul Walmsley , Tony Lindgren , =?utf-8?q?=22_Beno=C3=AEt_Cousson?= , Kevin Hilman" , alsa-devel@alsa-project.org, Jaroslav Kysela , Paul Mackerras , Sylwester Nawrocki , linux-arch@vger.kernel.org, Boris Brezillon , Kukjin Kim , =?utf-8?b?IiBFbWlsaW8gTMOzcGV6?= , patches@opensource.wolfsonmicro.com, Michal Simek , Takashi Iwai , Santosh Shilimkar , Anatolij Gustschin , Dinh Nguyen , linux-media@vger.kernel.org, Arnd Bergmann , linux-arm-msm@vger.kernel.org, spear-devel@list.st.com, Mark Brown , linux-rpi-kernel@lists.infradead.org, Ben Dooks , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Barry Song , Tomeu Vizoso , Liam Girdwood , Kyungmin Park , Viresh Kumar , Maxime Ripard , linuxppc-dev@lists.ozlabs.org, Mauro Carvalho Chehab X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Quoting Tomeu Vizoso (2014-09-03 08:31:57) > In preparation to change the public API to return a per-user clk structure, > remove any usage of this public API from the clock implementations. > > The reason for having this in a separate commit from the one that introduces > the implementation of the new functions is to separate the changes generated > with Coccinelle from the rest, and keep the patches' size reasonable. > > Signed-off-by: Tomeu Vizoso > Tested-by: Boris Brezillon > Tested-by: Heiko Stuebner > Acked-by: Boris Brezillon Hi Tomeu, Looks like the Coccinelle script had a false-positive. asm-generic/clkdev.h was converted from clk->clk_core and this blowed up clock drivers for architectures that don't provide an asm-specific clkdev.h implementation. This fixes x86's LPSS and a Microblaze driver. I've rolled the following fix into your 2/9 patch. No action is necessary. Regards, Mike diff --git a/include/asm-generic/clkdev.h b/include/asm-generic/clkdev.h index 4320225..90a32a6 100644 --- a/include/asm-generic/clkdev.h +++ b/include/asm-generic/clkdev.h @@ -15,10 +15,10 @@ #include -struct clk_core; +struct clk; -static inline int __clk_get(struct clk_core *clk) { return 1; } -static inline void __clk_put(struct clk_core *clk) { } +static inline int __clk_get(struct clk *clk) { return 1; } +static inline void __clk_put(struct clk *clk) { } static inline struct clk_lookup_alloc *__clkdev_alloc(size_t size) {