From patchwork Sat Jul 20 20:33:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaro Koskinen X-Patchwork-Id: 260479 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 18DD92C017C for ; Sun, 21 Jul 2013 06:35:27 +1000 (EST) Received: from filtteri5.pp.htv.fi (filtteri5.pp.htv.fi [213.243.153.188]) by ozlabs.org (Postfix) with ESMTP id BD0232C0099 for ; Sun, 21 Jul 2013 06:34:50 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by filtteri5.pp.htv.fi (Postfix) with ESMTP id 794BB5A6DEE; Sat, 20 Jul 2013 23:34:15 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at pp.htv.fi Received: from smtp4.welho.com ([213.243.153.38]) by localhost (filtteri5.pp.htv.fi [213.243.153.188]) (amavisd-new, port 10024) with ESMTP id Fae0JmIw9i9W; Sat, 20 Jul 2013 23:34:10 +0300 (EEST) Received: from musicnaut.iki.fi (cs181064211.pp.htv.fi [82.181.64.211]) by smtp4.welho.com (Postfix) with SMTP id 820665BC015; Sat, 20 Jul 2013 23:34:04 +0300 (EEST) Received: by musicnaut.iki.fi (sSMTP sendmail emulation); Sat, 20 Jul 2013 23:33:46 +0300 Date: Sat, 20 Jul 2013 23:33:46 +0300 From: Aaro Koskinen To: Benjamin Herrenschmidt Subject: Re: therm_pm72 units, interface Message-ID: <20130720203346.GM14385@blackmetal.musicnaut.iki.fi> References: <1345066616.11751.2.camel@pasglop> <1358465885.2782.24.camel@pasglop> <20130719174300.GL14385@blackmetal.musicnaut.iki.fi> <1374275809.19894.562.camel@pasglop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1374275809.19894.562.camel@pasglop> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Jan Engelhardt , linuxppc-dev X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, On Sat, Jul 20, 2013 at 09:16:49AM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2013-07-19 at 20:43 +0300, Aaro Koskinen wrote: > > I booted a Xserve today with 3.11-rc1, and noticed the noise is coming > > from slots-fan (PCI fan?) which is always 99%, although the slots-temp is > > just 33. Is it on purpose the rm31 slots PID params are totally different > > from therm_pm72 slots params? It seems like they have been copied from > > pm72 "drive bay" PID params instead. > > Could be my mistake. What happens if you change them to match the old code ? I tried the change below (use SLOTS_PID_* values from therm_pm72.h), and the noise level is considerably lower. The slots-fan stays at 19%, and slots-temp rises to 42'C but not higher after running couple of hours. Signed-off-by: etc... ? diff --git a/drivers/macintosh/windfarm_rm31.c b/drivers/macintosh/windfarm_rm31.c index 0b9a79b..82fc86a 100644 --- a/drivers/macintosh/windfarm_rm31.c +++ b/drivers/macintosh/windfarm_rm31.c @@ -439,15 +439,15 @@ static void backside_setup_pid(void) /* Slots fan */ static const struct wf_pid_param slots_param = { - .interval = 5, - .history_len = 2, - .gd = 30 << 20, - .gp = 5 << 20, - .gr = 0, - .itarget = 40 << 16, - .additive = 1, - .min = 300, - .max = 4000, + .interval = 1, + .history_len = 20, + .gd = 0, + .gp = 0, + .gr = 0x00100000, + .itarget = 3200000, + .additive = 0, + .min = 20, + .max = 100, }; static void slots_fan_tick(void)