From patchwork Fri Dec 9 01:27:46 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Breeds X-Patchwork-Id: 130273 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 509621008A1 for ; Fri, 9 Dec 2011 12:27:56 +1100 (EST) Received: from thor.bakeyournoodle.com (ibmaus65.lnk.telstra.net [165.228.126.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPSA id 368151007DA; Fri, 9 Dec 2011 12:27:47 +1100 (EST) Date: Fri, 9 Dec 2011 12:27:46 +1100 From: Tony Breeds To: Jeremy Fitzhardinge Subject: linux-next bad Kconfig for drivers/hid Message-ID: <20111209012746.GC20353@thor.bakeyournoodle.com> Mail-Followup-To: Jeremy Fitzhardinge , Jiri Kosina , Benjamin Herrenschmidt , LinuxPPC-dev , Linux Kernel ML MIME-Version: 1.0 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Jiri Kosina , LinuxPPC-dev , Linux Kernel ML X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Commit 4f5ca836bef3 (HID: hid-input: add support for HID devices reporting Battery Strength) went into linux-next on Dec 1st since then a ppc6xx_defconfig has been failing with: --- drivers/built-in.o: In function `hidinput_cleanup_battery': /scratch/tony/working/drivers/hid/hid-input.c:351: undefined reference to `power_supply_unregister' drivers/built-in.o: In function `hidinput_setup_battery': /scratch/tony/working/drivers/hid/hid-input.c:338: undefined reference to `power_supply_register' make[1]: *** [.tmp_vmlinux1] Error 1 --- http://kisskb.ellerman.id.au/kisskb/buildresult/5012563/ vs http://kisskb.ellerman.id.au/kisskb/buildresult/5017366/ The defconfig in question doens't mention either option (CONFIG_POWER_SUPPLY or CONFIG_HID_BATTERY_STRENGTH) and kbuild is genertaing CONFIG_HID_BATTERY_STRENGTH=y CONFIG_POWER_SUPPLY=m which clearly isn't going to work. The following change to HID_BATTERY_STRENGTH Kconfig "works" but seems a little gross. Any chance we can get a fix into linux-next? Yours Tony diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 5ed64f6..d2a94e6 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -33,7 +33,7 @@ config HID config HID_BATTERY_STRENGTH bool - depends on POWER_SUPPLY + depends on POWER_SUPPLY=y default y config HIDRAW