| Message ID | 20100205135546.GJ12001@hansolo.jdub.homelinux.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Fri, 2010-02-05 at 08:55 -0500, Josh Boyer wrote: > This works around the PCIe bridge setup on the iMac iSight boxen. Is this still needed ? I though I had fixed the root cause (incorrect setup of the bridge) a while back... Cheers, Ben. > --- > > --- linux/arch/powerpc/platforms/powermac/pci.c~ 2008-03-22 19:08:07.000000000 +0000 > +++ linux/arch/powerpc/platforms/powermac/pci.c 2008-03-23 09:10:46.000000000 +0000 > @@ -1271,6 +1271,12 @@ void pmac_pci_fixup_pciata(struct pci_de > } > } > DECLARE_PCI_FIXUP_EARLY(PCI_ANY_ID, PCI_ANY_ID, pmac_pci_fixup_pciata); > +#else /* CONFIG_PPC64 */ > +static void __devinit imac_transparent_bridge(struct pci_dev *dev) > +{ > + dev->transparent = 1; > +} > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_APPLE, 0x005b, imac_transparent_bridge); > #endif /* CONFIG_PPC32 */ > > /* > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev
On Sat, Feb 06, 2010 at 07:57:46AM +1100, Benjamin Herrenschmidt wrote: >On Fri, 2010-02-05 at 08:55 -0500, Josh Boyer wrote: >> This works around the PCIe bridge setup on the iMac iSight boxen. > >Is this still needed ? I though I had fixed the root cause (incorrect >setup of the bridge) a while back... I honestly have no clue, and I have no means of actually testing this. I have an iMac running Fedora, but not the iSight version. If you think it's fixed then I can just drop the patch from the Fedora kernel and we can wait for either silence or bug reports :) josh
On Fri, 2010-02-05 at 20:03 -0500, Josh Boyer wrote: > On Sat, Feb 06, 2010 at 07:57:46AM +1100, Benjamin Herrenschmidt wrote: > >On Fri, 2010-02-05 at 08:55 -0500, Josh Boyer wrote: > >> This works around the PCIe bridge setup on the iMac iSight boxen. > > > >Is this still needed ? I though I had fixed the root cause (incorrect > >setup of the bridge) a while back... > > I honestly have no clue, and I have no means of actually testing this. I have > an iMac running Fedora, but not the iSight version. If you think it's fixed > then I can just drop the patch from the Fedora kernel and we can wait for > either silence or bug reports :) I -think- it is but users of those machines are hard to find :-) Cheers, Ben.
On Fri, 2010-02-05 at 20:03 -0500, Josh Boyer wrote: > On Sat, Feb 06, 2010 at 07:57:46AM +1100, Benjamin Herrenschmidt wrote: > >On Fri, 2010-02-05 at 08:55 -0500, Josh Boyer wrote: > >> This works around the PCIe bridge setup on the iMac iSight boxen. > > > >Is this still needed ? I though I had fixed the root cause (incorrect > >setup of the bridge) a while back... > > I honestly have no clue, and I have no means of actually testing this. I have > an iMac running Fedora, but not the iSight version. If you think it's fixed > then I can just drop the patch from the Fedora kernel and we can wait for > either silence or bug reports :) I'll dig out the machine and test. Some time next month would be the current estimate.
--- linux/arch/powerpc/platforms/powermac/pci.c~ 2008-03-22 19:08:07.000000000 +0000 +++ linux/arch/powerpc/platforms/powermac/pci.c 2008-03-23 09:10:46.000000000 +0000 @@ -1271,6 +1271,12 @@ void pmac_pci_fixup_pciata(struct pci_de } } DECLARE_PCI_FIXUP_EARLY(PCI_ANY_ID, PCI_ANY_ID, pmac_pci_fixup_pciata); +#else /* CONFIG_PPC64 */ +static void __devinit imac_transparent_bridge(struct pci_dev *dev) +{ + dev->transparent = 1; +} +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_APPLE, 0x005b, imac_transparent_bridge); #endif /* CONFIG_PPC32 */ /*