| Message ID | 200912220757.44591.roman.fietze@telemotive.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Grant Likely |
| Headers | show |
Hi Roman. I'm finally getting some time to look at these with a bit more detail. On Mon, Dec 21, 2009 at 11:57 PM, Roman Fietze <roman.fietze@telemotive.de> wrote: > > Signed-off-by: Roman Fietze <roman.fietze@telemotive.de> > --- > arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > index 929d017..4c84aa5 100644 > --- a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > +++ b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c > @@ -165,7 +165,7 @@ static void mpc52xx_lpbfifo_kick(struct mpc52xx_lpbfifo_request *req) > > bit_fields = req->cs << 24 | 0x000008; > if (!write) > - bit_fields |= 0x010000; /* read mode */ > + bit_fields |= 0x010000; /* read mode */ > out_be32(lpbfifo.regs + LPBFIFO_REG_CONTROL, bit_fields); > > /* Kick it off */ > @@ -279,7 +279,7 @@ static irqreturn_t mpc52xx_lpbfifo_irq(int irq, void *dev_id) > else > do_callback = 1; > > - out: > +out: The label 1 space indentation is intentional so coax diff into choosing the right line for the function name. There are plenty of examples of this in the kernel. The rest of the changes are valid, but unimportant. It's not worth the effort. In most cases I don't bother fixing whitespace unless they style violations are so gratuitous that it is hard to read the code otherwise, or if I'm already touching the offending line. g.
diff --git a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c index 929d017..4c84aa5 100644 --- a/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c +++ b/arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c @@ -165,7 +165,7 @@ static void mpc52xx_lpbfifo_kick(struct mpc52xx_lpbfifo_request *req) bit_fields = req->cs << 24 | 0x000008; if (!write) - bit_fields |= 0x010000; /* read mode */ + bit_fields |= 0x010000; /* read mode */ out_be32(lpbfifo.regs + LPBFIFO_REG_CONTROL, bit_fields); /* Kick it off */ @@ -279,7 +279,7 @@ static irqreturn_t mpc52xx_lpbfifo_irq(int irq, void *dev_id) else do_callback = 1; - out: +out: /* Clear the IRQ */ out_8(lpbfifo.regs + LPBFIFO_REG_BYTES_DONE_STATUS, 0x01); @@ -379,11 +379,11 @@ void mpc52xx_lpbfifo_poll(void) int write = req->flags & MPC52XX_LPBFIFO_FLAG_WRITE; /* - * For more information, see comments on the "Fat Lady" + * For more information, see comments on the "Fat Lady" */ if (dma && write) mpc52xx_lpbfifo_irq(0, NULL); - else + else mpc52xx_lpbfifo_bcom_irq(0, NULL); } EXPORT_SYMBOL(mpc52xx_lpbfifo_poll); @@ -491,12 +491,12 @@ mpc52xx_lpbfifo_probe(struct of_device *op, const struct of_device_id *match) lpbfifo.dev = &op->dev; return 0; - err_bcom_tx: +err_bcom_tx: free_irq(bcom_get_task_irq(lpbfifo.bcom_rx_task), &lpbfifo); - err_bcom_rx_irq: +err_bcom_rx_irq: bcom_gen_bd_rx_release(lpbfifo.bcom_rx_task); - err_bcom_rx: - err_irq: +err_bcom_rx: +err_irq: iounmap(lpbfifo.regs); lpbfifo.regs = NULL; @@ -516,7 +516,7 @@ static int __devexit mpc52xx_lpbfifo_remove(struct of_device *op) /* Release the bestcomm transmit task */ free_irq(bcom_get_task_irq(lpbfifo.bcom_tx_task), &lpbfifo); bcom_gen_bd_tx_release(lpbfifo.bcom_tx_task); - + /* Release the bestcomm receive task */ free_irq(bcom_get_task_irq(lpbfifo.bcom_rx_task), &lpbfifo); bcom_gen_bd_rx_release(lpbfifo.bcom_rx_task);
Signed-off-by: Roman Fietze <roman.fietze@telemotive.de> --- arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-)