| Message ID | 20091018112429.GP4808@kryten (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Paul Mackerras |
| Headers | show |
* Anton Blanchard <anton@samba.org> wrote: > If CONFIG_PPC_ISERIES isn't defined we end up with iseries_check_pending_irqs > and do_work at the same address. perf ends up picking > iseries_check_pending_irqs which creates confusing backtraces. Hide it. > > Signed-off-by: Anton Blanchard <anton@samba.org> Just to confirm - these 3 symbol fixes are for the PowerPC tree, not for the perf events tree, right? There's nothing perf specific about the fixes - kgdb, systemtap and other debugging/instrumentation frameworks will benefit from more precise symbol generation too. Ingo
Hi Ingo, > Just to confirm - these 3 symbol fixes are for the PowerPC tree, not for > the perf events tree, right? There's nothing perf specific about the > fixes - kgdb, systemtap and other debugging/instrumentation frameworks > will benefit from more precise symbol generation too. Yeah, while they were written to fix perf backtrace issues they are definitely not perf specific. Hopefully Ben will queue them up in his tree for the next merge window :) Anton
On Tue, 2009-10-20 at 14:50 +1100, Anton Blanchard wrote: > Hi Ingo, > > > Just to confirm - these 3 symbol fixes are for the PowerPC tree, not for > > the perf events tree, right? There's nothing perf specific about the > > fixes - kgdb, systemtap and other debugging/instrumentation frameworks > > will benefit from more precise symbol generation too. > > Yeah, while they were written to fix perf backtrace issues they are > definitely not perf specific. Hopefully Ben will queue them up in his > tree for the next merge window :) Right, I'm overdue for a powerpc-next but with some family issues last couple of week and KS/JLS this week, it' a bit hard :-) Ben.
Index: linux.trees.git/arch/powerpc/kernel/entry_64.S =================================================================== --- linux.trees.git.orig/arch/powerpc/kernel/entry_64.S 2009-10-16 11:06:10.000000000 +1100 +++ linux.trees.git/arch/powerpc/kernel/entry_64.S 2009-10-16 11:06:28.000000000 +1100 @@ -551,7 +551,7 @@ restore: BEGIN_FW_FTR_SECTION ld r5,SOFTE(r1) FW_FTR_SECTION_ELSE - b iseries_check_pending_irqs + b .Liseries_check_pending_irqs ALT_FW_FTR_SECTION_END_IFCLR(FW_FEATURE_ISERIES) 2: TRACE_AND_RESTORE_IRQ(r5); @@ -623,7 +623,7 @@ ALT_FW_FTR_SECTION_END_IFCLR(FW_FEATURE_ #endif /* CONFIG_PPC_BOOK3E */ -iseries_check_pending_irqs: +.Liseries_check_pending_irqs: #ifdef CONFIG_PPC_ISERIES ld r5,SOFTE(r1) cmpdi 0,r5,0
If CONFIG_PPC_ISERIES isn't defined we end up with iseries_check_pending_irqs and do_work at the same address. perf ends up picking iseries_check_pending_irqs which creates confusing backtraces. Hide it. Signed-off-by: Anton Blanchard <anton@samba.org> --