From patchwork Wed Oct 7 15:15:57 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 35304 X-Patchwork-Delegate: grant.likely@secretlab.ca Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 10BA4B7BB9 for ; Thu, 8 Oct 2009 02:21:17 +1100 (EST) X-Greylist: delayed 302 seconds by postgrey-1.32 at bilbo; Thu, 08 Oct 2009 02:21:09 EST Received: from draco.sysmic.org (sysmic.org [88.191.45.54]) by ozlabs.org (Postfix) with ESMTP id 5977EB7B96 for ; Thu, 8 Oct 2009 02:21:09 +1100 (EST) Received: by draco.sysmic.org (Postfix, from userid 65534) id 76FDF322F8; Wed, 7 Oct 2009 17:16:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on draco X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.2.5 Received: from aquila.localnet (cev75-4-82-247-117-217.fbx.proxad.net [82.247.117.217]) (Authenticated sender: jezz) by draco.sysmic.org (Postfix) with ESMTPSA id 9EF04322F0; Wed, 7 Oct 2009 17:15:57 +0200 (CEST) To: Grant Likely Subject: Nested function in drivers/of/of_mdio.c From: =?iso-8859-1?q?J=E9r=F4me_Pouiller?= Organization: Freelance Date: Wed, 7 Oct 2009 17:15:57 +0200 MIME-Version: 1.0 Message-Id: <200910071715.57249.jezz@sysmic.org> Cc: netdev , linuxppc , Andy Fleming , "David S. Miller" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Dear, I have a problem with commit 8bc487d150b939e69830c39322df4ee486efe381 in file drivers/of/of_mdio.c in function of_phy_find_device. As you see, this function define match() as a nested function. My compiler (powerpc-e500-linux-gnu-gcc-3.4.1) raise an error during link due to this nested definition: drivers/built-in.o(.text+0x5e2a4): In function `of_phy_find_device': /home/jezz/linux-next/drivers/of/of_mdio.c:107: undefined reference to `__trampoline_setup' I am sure I could solve problem by rebuilding my toolchain. Nevertheless, I think nested function definition is not perfectly supported by all compilers. Also, I suggest to place function match() outside of scope of of_phy_find_device as in following patch. What do you think about it? Best regards, diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index bacaa53..c7b2e26 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -97,6 +97,10 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) } EXPORT_SYMBOL(of_mdiobus_register); +static int match(struct device *dev, void *phy_np) +{ + return dev_archdata_get_node(&dev->archdata) == phy_np; +} /** * of_phy_find_device - Give a PHY node, find the phy_device * @phy_np: Pointer to the phy's device tree node @@ -106,11 +110,6 @@ EXPORT_SYMBOL(of_mdiobus_register); struct phy_device *of_phy_find_device(struct device_node *phy_np) { struct device *d; - int match(struct device *dev, void *phy_np) - { - return dev_archdata_get_node(&dev->archdata) == phy_np; - } - if (!phy_np) return NULL;