From patchwork Fri Sep 25 13:31:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamalesh Babulal X-Patchwork-Id: 34273 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 17DB4B7E20 for ; Fri, 25 Sep 2009 23:31:54 +1000 (EST) Received: by ozlabs.org (Postfix) id B85F4B7BA9; Fri, 25 Sep 2009 23:31:47 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com [202.81.31.147]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e23smtp05.au.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 7F17EB7B9B for ; Fri, 25 Sep 2009 23:31:47 +1000 (EST) Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246]) by e23smtp05.au.ibm.com (8.14.3/8.13.1) with ESMTP id n8PDT46X008338 for ; Fri, 25 Sep 2009 23:29:04 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8PDTaH91712328 for ; Fri, 25 Sep 2009 23:29:36 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id n8PDViFu012280 for ; Fri, 25 Sep 2009 23:31:45 +1000 Received: from linux.vnet.ibm.com (ChanaKya-009124158082.in.ibm.com [9.124.158.82]) by d23av01.au.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with SMTP id n8PDVhWC012262; Fri, 25 Sep 2009 23:31:43 +1000 Date: Fri, 25 Sep 2009 19:01:43 +0530 From: Kamalesh Babulal To: Stephen Rothwell Subject: linux-next: 20090925 - hvc driver build breaks with !HVC_CONSOLE Message-ID: <20090925133143.GD6831@linux.vnet.ibm.com> References: <20090925133830.1ba29584.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090925133830.1ba29584.sfr@canb.auug.org.au> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org, LKML X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Kamalesh Babulal List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Hi Stephen, next-20090925 randconfig build breaks on hvcs driver on powerpc, with HVC_CONSOLE=n. ERROR: ".hvc_put_chars" [drivers/char/hvcs.ko] undefined! ERROR: ".hvc_get_chars" [drivers/char/hvcs.ko] undefined! adding the dependency of HVC_CONSOLE helped Signed-off-by: Kamalesh Babulal --- drivers/char/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Kamalesh diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index a2a0e67..2583231 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -682,7 +682,7 @@ config VIRTIO_CONSOLE config HVCS tristate "IBM Hypervisor Virtual Console Server support" - depends on PPC_PSERIES + depends on PPC_PSERIES && HVC_CONSOLE help Partitionable IBM Power5 ppc64 machines allow hosting of firmware virtual consoles from one Linux partition by