From patchwork Fri Jul 31 16:47:00 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Vasquez X-Patchwork-Id: 30432 Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 2EA8EB7BB3 for ; Sat, 1 Aug 2009 02:59:30 +1000 (EST) Received: by ozlabs.org (Postfix) id 23AABDDDA2; Sat, 1 Aug 2009 02:59:30 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (bilbo.ozlabs.org [203.10.76.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "bilbo.ozlabs.org", Issuer "CAcert Class 3 Root" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 21CBEDDDA0 for ; Sat, 1 Aug 2009 02:59:30 +1000 (EST) Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by bilbo.ozlabs.org (Postfix) with ESMTP id 3F9AAB7E57 for ; Sat, 1 Aug 2009 02:59:13 +1000 (EST) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 5513EB7BAA for ; Sat, 1 Aug 2009 02:59:06 +1000 (EST) Received: by ozlabs.org (Postfix) id 445BCDDDA2; Sat, 1 Aug 2009 02:59:06 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org X-Greylist: delayed 723 seconds by postgrey-1.31 at ozlabs; Sat, 01 Aug 2009 02:59:05 EST Received: from avexch1.qlogic.com (avexch1.qlogic.com [198.70.193.115]) by ozlabs.org (Postfix) with ESMTP id D950FDDDA0 for ; Sat, 1 Aug 2009 02:59:05 +1000 (EST) Received: from plap4.qlogic.com ([10.1.7.214]) by avexch1.qlogic.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 31 Jul 2009 09:46:52 -0700 Received: by plap4.qlogic.com (Postfix, from userid 501) id 4CD48B3EEB7; Fri, 31 Jul 2009 09:47:00 -0700 (PDT) Date: Fri, 31 Jul 2009 09:47:00 -0700 From: Andrew Vasquez To: Andi Kleen Subject: Re: [PATCH 1/3] Support for PCI Express reset type Message-ID: <20090731164700.GC23800@n5105in79bv1s.qlogic.org> References: <4A721FB1.4040903@us.ibm.com> <87hbws3jvx.fsf@basil.nowhere.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87hbws3jvx.fsf@basil.nowhere.org> Organization: QLogic Corporation User-Agent: Mutt/1.5.18 (2008-05-17) X-OriginalArrivalTime: 31 Jul 2009 16:46:52.0398 (UTC) FILETIME=[8168E0E0:01CA11FE] Cc: "linuxppc-dev@ozlabs.org" , Paul Mackerras , Richard Lary , "linux-pci@vger.kernel.org" , "linasvepstas@gmail.com" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org On Fri, 31 Jul 2009, Andi Kleen wrote: > Mike Mason writes: > > > > These patches supersede the previously submitted patch that > > implemented a fundamental reset bit field. > > > > Please review and let me know of any concerns. > > Any plans to implement that for x86 too? Right now it seems to be a PPC > specific hack. Are there any non-PPC platforms which support EEH slot-reset? > And where is the driver that is using it? That would be the qla2xxx (FC/FCoE storage) and qlge (10gb NIC ) drivers. Changes to the drivers could look something like: once the infrastructure changes were hashed out. -- av Index: b/drivers/net/qlge/qlge_main.c =================================================================== --- a/drivers/net/qlge/qlge_main.c +++ b/drivers/net/qlge/qlge_main.c @@ -4289,6 +4289,9 @@ static int __devinit qlge_probe(struct p return err; } + /* Set EEH reset type to fundamental for this device */ + pdev->needs_freset = 1; + qdev = netdev_priv(ndev); SET_NETDEV_DEV(ndev, &pdev->dev); ndev->features = (0 Index: b/drivers/scsi/qla2xxx/qla_os.c =================================================================== --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1773,6 +1773,10 @@ qla2x00_probe_one(struct pci_dev *pdev, /* Set ISP-type information. */ qla2x00_set_isp_flags(ha); + /* Set EEH reset type to fundamental if required by hba */ + if (IS_QLA24XX(ha) || IS_QLA25XX(ha) || IS_QLA81XX(ha)) + pdev->needs_freset = 1; + /* Configure PCI I/O space */ ret = qla2x00_iospace_config(ha); if (ret)