From patchwork Tue Apr 21 19:04:14 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 26279 Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4594AB6F56 for ; Wed, 22 Apr 2009 05:29:18 +1000 (EST) Received: by ozlabs.org (Postfix) id A0497DFBA6; Wed, 22 Apr 2009 05:16:13 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 9D204DFBA5 for ; Wed, 22 Apr 2009 05:16:13 +1000 (EST) X-Original-To: Linuxppc-dev@ozlabs.org Delivered-To: Linuxppc-dev@ozlabs.org Received: from mail-bw0-f219.google.com (mail-bw0-f219.google.com [209.85.218.219]) by ozlabs.org (Postfix) with ESMTP id 8DFC8DE35D for ; Wed, 22 Apr 2009 05:00:54 +1000 (EST) Received: by bwz19 with SMTP id 19so2449354bwz.9 for ; Tue, 21 Apr 2009 12:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version :content-disposition:message-id:content-type :content-transfer-encoding; bh=AE4DKcTxRVZQK7KHdAMrHqGka3NhLhjHlFcu+F3PPaA=; b=PozUExcGrYi22TQ/KPbEW9Tvl352QYv3cLMhVhxbqKbnpCNDhsr44TZVL3OXSnTGXJ pCsY2yWFySn+16wGQgbuAYAMA/1yIbR/9gk4s9F45fRyGgP7F4COw3kNNYcNWhHJNA0T 97Q3gfGvXYNbozy16WLu48O0ZvxngEfdTtg0Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=sunYzM+R7YNwSBDqkGxc8YFO8wjmDzz+/QewJoeLDOOcm0u+kPY1XTIO7VUrzJsSX5 BXYc4TrksS7422wVVbIXq6wMvX9kNGwJHwlG9Kvch5K9FrghJbk4mH1SlOkIk+zposO4 VQM/Yga+QHqsov/PBskLl4qSwsnd33gXHGnr4= Received: by 10.103.247.14 with SMTP id z14mr3993812mur.70.1240340451518; Tue, 21 Apr 2009 12:00:51 -0700 (PDT) Received: from localhost.localdomain (chello089077051219.chello.pl [89.77.51.219]) by mx.google.com with ESMTPS id 7sm17999986mup.28.2009.04.21.12.00.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 21 Apr 2009 12:00:50 -0700 (PDT) From: Bartlomiej Zolnierkiewicz To: subrata@linux.vnet.ibm.com Subject: Re: [BUILD FAILURE 05/12] Next April 21 : PPC64 randconfig [drivers/macintosh/mediabay.o] Date: Tue, 21 Apr 2009 21:04:14 +0200 User-Agent: KMail/1.11.1 (Linux/2.6.29-next-20090403; KDE/4.2.1; i686; ; ) References: <1240339875.9110.137.camel@subratamodak.linux.ibm.com> In-Reply-To: <1240339875.9110.137.camel@subratamodak.linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200904212104.14665.bzolnier@gmail.com> Cc: sachinp , Stephen Rothwell , Adrian Bunk , linux-kernel , Stefan Bader , Linuxppc-dev , linux-next , Paul Mackerras , Marcelo Tosatti , Alexander Beregalov X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org On Tuesday 21 April 2009 20:51:15 Subrata Modak wrote: > Reported this earlier on 14th April: > http://lkml.org/lkml/2009/4/14/490, > > Is there a solution available ? Perfect timing. I was just going through overdue reports. > CC drivers/macintosh/mediabay.o > In file included from drivers/macintosh/mediabay.c:21: > include/linux/ide.h:610: error: field ‘sense_rq’ has incomplete type > make[2]: *** [drivers/macintosh/mediabay.o] Error 1 > make[1]: *** [drivers/macintosh] Error 2 > make: *** [drivers] Error 2 > --- From: Bartlomiej Zolnierkiewicz Subject: [PATCH] mediabay: fix build for CONFIG_BLOCK=n On Tuesday 14 April 2009 20:31:21 Subrata Modak wrote: > Observed the following build error: > --- > CC drivers/macintosh/mediabay.o > In file included from drivers/macintosh/mediabay.c:21: > include/linux/ide.h:605: error: field ‘request_sense_rq’ has incomplete > type > make[2]: *** [drivers/macintosh/mediabay.o] Error 1 > make[1]: *** [drivers/macintosh] Error 2 > make: *** [drivers] Error 2 > --- mediabay shouldn't include unconditionally so remove the superfluous include from mediabay.c ( will pull in for CONFIG_BLK_DEV_IDE_PMAC=y). Reported-by: Subrata Modak Cc: Paul Mackerras Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/macintosh/mediabay.c | 1 - 1 file changed, 1 deletion(-) Index: b/drivers/macintosh/mediabay.c =================================================================== --- a/drivers/macintosh/mediabay.c +++ b/drivers/macintosh/mediabay.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include #include