| Message ID | 20081118113848.945650506@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 7947cf0dd4b6a2bb06c57971502fb81c76a66f2d |
| Delegated to: | Paul Mackerras |
| Headers | show |
Hendrik Brueckner writes: > From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> > > The test to check for a new winsize runs out-of-sync with the underlying > tty. After a tty has been released and initialized again, the winsize might > differ between the tty and the hp struct. > The solution is to simply remove the check and always schedule the resize work. Looks OK. Is this going to go in via the s390 tree, or should I put it in the powerpc tree? Paul.
Hi Paul, On Wed, Dec 03, 2008 at 08:17:13PM +1100, Paul Mackerras wrote: > Looks OK. Is this going to go in via the s390 tree, or should I put > it in the powerpc tree? The patch should go via the powerpc tree. Thanks and regards, Hendrik
differ between the tty and the hp struct. The solution is to simply remove the check and always schedule the resize work. Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> --- drivers/char/hvc_console.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/char/hvc_console.c +++ b/drivers/char/hvc_console.c @@ -689,10 +689,8 @@ EXPORT_SYMBOL_GPL(hvc_poll); */ void hvc_resize(struct hvc_struct *hp, struct winsize ws) { - if ((hp->ws.ws_row != ws.ws_row) || (hp->ws.ws_col != ws.ws_col)) { - hp->ws = ws; - schedule_work(&hp->tty_resize); - } + hp->ws = ws; + schedule_work(&hp->tty_resize); } /*
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com> The test to check for a new winsize runs out-of-sync with the underlying tty. After a tty has been released and initialized again, the winsize might