From patchwork Wed Dec 6 08:37:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christian Zigotzky X-Patchwork-Id: 845065 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysBr86P0Gz9s4s for ; Wed, 6 Dec 2017 19:39:52 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xenosoft.de header.i=@xenosoft.de header.b="lEYIAflG"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ysBr84jfvzF0Hh for ; Wed, 6 Dec 2017 19:39:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xenosoft.de header.i=@xenosoft.de header.b="lEYIAflG"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (helo) smtp.helo=mo6-p00-ob.smtp.rzone.de (client-ip=2a01:238:20a:202:5300::11; helo=mo6-p00-ob.smtp.rzone.de; envelope-from=chzigotzky@xenosoft.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xenosoft.de header.i=@xenosoft.de header.b="lEYIAflG"; dkim-atps=neutral Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysBp02rf1zF0H6 for ; Wed, 6 Dec 2017 19:37:57 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1512549472; s=domk; d=xenosoft.de; h=Content-Language:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:X-RZG-CLASS-ID:X-RZG-AUTH: Accept-Language:Auto-Submitted:Cc:Date:From:Message-ID:References: Reply-To:Resent-Cc:Resent-Date:Resent-From:Resent-To:Sender:Subject: To:Content-Alternative:Content-Description:Content-Disposition: Content-Duration:Content-Features:Content-ID:Content-Language: Content-Location:Content-MD5:Content-Transfer-Encoding:Content-Type: MIME-Version; bh=YVLCzsj3WxpNs7El1OhnUSHzxw6M9iypaIZNsALhrjA=; b=lEYIAflGKeLSMToMNyzlnjNcenxjS28vBcFwJuI4u8cNaZx5eeifLBntYPLvRScpFK Z972r9C1Wfo7p325PnsmuINAWBmC3tBRZud4gQl1KWw3omvqM4EOktgFedLycXgldeQN 1B/Ky9Rst1Lwn1fQRAqFLHxPVUrl8XiBjzjYI= X-RZG-AUTH: :L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySf+VvAflxJtIT5kwmqA== X-RZG-CLASS-ID: mo00 Received: from [192.168.1.139] (ppp-188-174-94-1.dynamic.mnet-online.de [188.174.94.1]) by smtp.strato.de (RZmta 42.12 DYNA|AUTH) with ESMTPSA id d01626tB68beNgZ (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 6 Dec 2017 09:37:40 +0100 (CET) Subject: [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus From: Christian Zigotzky To: Olof Johansson , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Darren Stevens , Bjorn Helgaas , linuxppc-dev References: <87tvxl15qx.fsf@concordia.ellerman.id.au> <4cfe3cc0-7fe3-9774-7d20-1b7fcb7aa910@xenosoft.de> <28b43e1a-3643-9edb-7123-be1cb0dc846a@xenosoft.de> <527175f7-8a13-37a1-9f0a-0b918aeebd64@xenosoft.de> <20171130224243.GB19640@bhelgaas-glaptop.roam.corp.google.com> <406ba7c4-7305-4069-227f-81afed202e47@xenosoft.de> <20171201232716.GA18780@bhelgaas-glaptop.roam.corp.google.com> <6d2505ab-a985-bdb0-ad3a-e7659cc2c54d@xenosoft.de> <20171202230052.34y2ivxgpgr3osct@localhost> <4CEE49CE-68F3-457F-B302-54BA8550F36A@xenosoft.de> Message-ID: <1d5276c3-1d29-114a-c868-6f022eee58e7@xenosoft.de> Date: Wed, 6 Dec 2017 09:37:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <4CEE49CE-68F3-457F-B302-54BA8550F36A@xenosoft.de> Content-Language: de-LU X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 03 December 2017 10:43AM, Christian Zigotzky wrote: > > On 3. Dec 2017, at 00:02, Olof Johansson wrote: >> >>> On Sat, Dec 2, 2017 at 3:00 PM, Olof Johansson wrote: >>> >>> The below patch, together with Bjorn's, should do it. Christian, can you test >>> and report back? >>> >>> I'm guessing it won't do any harm to set this on non-X1000 platforms. My >>> test system is currently powered down so I can't check. >>> >>> >>> From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001 >>> From: Olof Johansson >>> Date: Sat, 2 Dec 2017 14:56:36 -0800 >>> Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS >>> >>> Needed on Amiga X1000 with SB600. >>> >>> Reported-by: Christian Zigotzky >>> Cc: Bjorn Helgaas >>> Signed-off-by: Olof Johansson >>> --- >>> arch/powerpc/platforms/pasemi/pci.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c >>> index 5ff6108..ea54ed2 100644 >>> --- a/arch/powerpc/platforms/pasemi/pci.c >>> +++ b/arch/powerpc/platforms/pasemi/pci.c >>> @@ -224,6 +224,8 @@ void __init pas_pci_init(void) >>>                return; >>>        } >>> >>> +       pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS): >> >> Typo, should be ';', not ':'. I obviously didn't even try compiling this. :) >> >> >> -Olof > > Hi Olof, > > Thanks a lot for your patch! I will test it on Wednesday. > > Cheers, > Christian Hi Olof, I tested your patch today. Unfortunately the kernel 4.15-rc2 doesn't compile with your patch. Error messages:                        ^~~~~~~~~ arch/powerpc/platforms/pasemi/pci.c: In function ‘pas_pci_init’: arch/powerpc/platforms/pasemi/pci.c:298:2: error: implicit declaration of function ‘pci_set_flag’ [-Werror=implicit-function-declaration]   pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS);   ^~~~~~~~~~~~ cc1: some warnings being treated as errors --- I figured out that we need 'pci_set_flags' instead of 'pci_set_flag'. I modified your patch and after that the kernel compiles. Please find attached the new patch. Cheers, Christian arch/powerpc/platforms/pasemi/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c index 5ff6108..ea54ed2 100644 --- a/arch/powerpc/platforms/pasemi/pci.c +++ b/arch/powerpc/platforms/pasemi/pci.c @@ -224,6 +224,8 @@ void __init pas_pci_init(void) return; } + pci_set_flags(PCI_SCAN_ALL_PCIE_DEVS); + for (np = NULL; (np = of_get_next_child(root, np)) != NULL;) if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np)) of_node_get(np);