| Message ID | 1647485088-16068-1-git-send-email-baihaowen@meizu.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | macintosh: smu: Fix warning comparing pointer to 0 | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | warning | sparse (ppc64, ubuntu-21.04, ppc64) found 3 issues. |
Le 17/03/2022 à 03:44, Haowen Bai a écrit : > Avoid pointer type value compared with 0 to make code clear. > > Signed-off-by: Haowen Bai <baihaowen@meizu.com> This change is already awaiting at https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210825061838.69746-1-deng.changcheng@zte.com.cn/ Thanks Christophe > --- > drivers/macintosh/smu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c > index a4fbc3f..d72d073 100644 > --- a/drivers/macintosh/smu.c > +++ b/drivers/macintosh/smu.c > @@ -1087,7 +1087,7 @@ static int smu_open(struct inode *inode, struct file *file) > unsigned long flags; > > pp = kzalloc(sizeof(struct smu_private), GFP_KERNEL); > - if (pp == 0) > + if (!pp) > return -ENOMEM; > spin_lock_init(&pp->lock); > pp->mode = smu_file_commands; > @@ -1254,7 +1254,7 @@ static __poll_t smu_fpoll(struct file *file, poll_table *wait) > __poll_t mask = 0; > unsigned long flags; > > - if (pp == 0) > + if (!pp) > return 0; > > if (pp->mode == smu_file_commands) { > @@ -1277,7 +1277,7 @@ static int smu_release(struct inode *inode, struct file *file) > unsigned long flags; > unsigned int busy; > > - if (pp == 0) > + if (!pp) > return 0; > > file->private_data = NULL;
diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index a4fbc3f..d72d073 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c @@ -1087,7 +1087,7 @@ static int smu_open(struct inode *inode, struct file *file) unsigned long flags; pp = kzalloc(sizeof(struct smu_private), GFP_KERNEL); - if (pp == 0) + if (!pp) return -ENOMEM; spin_lock_init(&pp->lock); pp->mode = smu_file_commands; @@ -1254,7 +1254,7 @@ static __poll_t smu_fpoll(struct file *file, poll_table *wait) __poll_t mask = 0; unsigned long flags; - if (pp == 0) + if (!pp) return 0; if (pp->mode == smu_file_commands) { @@ -1277,7 +1277,7 @@ static int smu_release(struct inode *inode, struct file *file) unsigned long flags; unsigned int busy; - if (pp == 0) + if (!pp) return 0; file->private_data = NULL;
Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- drivers/macintosh/smu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)