Message ID | 1647484837-14352-1-git-send-email-baihaowen@meizu.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | macintosh: via-cuda: Fix warning comparing pointer to 0 | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_sparse | warning | sparse (pmac32, ubuntu-21.04, ppc64) found 3 issues. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
Hi, Le 17/03/2022 à 03:40, Haowen Bai a écrit : > Avoid pointer type value compared with 0 to make code clear. We already have this change waiting in the queue, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220214010558.130201-1-yang.lee@linux.alibaba.com/ Thanks Christophe > > Signed-off-by: Haowen Bai <baihaowen@meizu.com> > --- > drivers/macintosh/via-cuda.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/macintosh/via-cuda.c b/drivers/macintosh/via-cuda.c > index cd267392..05a3cd9 100644 > --- a/drivers/macintosh/via-cuda.c > +++ b/drivers/macintosh/via-cuda.c > @@ -236,10 +236,10 @@ int __init find_via_cuda(void) > const u32 *reg; > int err; > > - if (vias != 0) > + if (vias) > return 1; > vias = of_find_node_by_name(NULL, "via-cuda"); > - if (vias == 0) > + if (!vias) > return 0; > > reg = of_get_property(vias, "reg", NULL); > @@ -517,7 +517,7 @@ cuda_write(struct adb_request *req) > req->reply_len = 0; > > spin_lock_irqsave(&cuda_lock, flags); > - if (current_req != 0) { > + if (current_req) { > last_req->next = req; > last_req = req; > } else {
diff --git a/drivers/macintosh/via-cuda.c b/drivers/macintosh/via-cuda.c index cd267392..05a3cd9 100644 --- a/drivers/macintosh/via-cuda.c +++ b/drivers/macintosh/via-cuda.c @@ -236,10 +236,10 @@ int __init find_via_cuda(void) const u32 *reg; int err; - if (vias != 0) + if (vias) return 1; vias = of_find_node_by_name(NULL, "via-cuda"); - if (vias == 0) + if (!vias) return 0; reg = of_get_property(vias, "reg", NULL); @@ -517,7 +517,7 @@ cuda_write(struct adb_request *req) req->reply_len = 0; spin_lock_irqsave(&cuda_lock, flags); - if (current_req != 0) { + if (current_req) { last_req->next = req; last_req = req; } else {
Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- drivers/macintosh/via-cuda.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)