Message ID | 1647484554-13258-1-git-send-email-baihaowen@meizu.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 2f59562c140d3119328f869126e8e593a99a392f |
Headers | show |
Series | macintosh: adb: Fix warning comparing pointer to 0 | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
snowpatch_ozlabs/github-powerpc_sparse | warning | sparse (pmac32, ubuntu-21.04, ppc64) found 2 issues. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On Thu, 17 Mar 2022 10:35:54 +0800, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > > Applied to powerpc/next. [1/1] macintosh: adb: Fix warning comparing pointer to 0 https://git.kernel.org/powerpc/c/2f59562c140d3119328f869126e8e593a99a392f cheers
diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c index 73b3961..996f310 100644 --- a/drivers/macintosh/adb.c +++ b/drivers/macintosh/adb.c @@ -478,7 +478,7 @@ adb_register(int default_id, int handler_id, struct adb_ids *ids, if ((adb_handler[i].original_address == default_id) && (!handler_id || (handler_id == adb_handler[i].handler_id) || try_handler_change(i, handler_id))) { - if (adb_handler[i].handler != 0) { + if (adb_handler[i].handler) { pr_err("Two handlers for ADB device %d\n", default_id); continue; @@ -673,7 +673,7 @@ static int adb_open(struct inode *inode, struct file *file) goto out; } state = kmalloc(sizeof(struct adbdev_state), GFP_KERNEL); - if (state == 0) { + if (!state) { ret = -ENOMEM; goto out; }
Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- drivers/macintosh/adb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)