From patchwork Fri Oct 5 04:12:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 979305 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42RHBj66nsz9s3Z for ; Fri, 5 Oct 2018 14:41:01 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bzTluJeC"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42RHBj4STCzF3JT for ; Fri, 5 Oct 2018 14:41:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bzTluJeC"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::544; helo=mail-pg1-x544.google.com; envelope-from=frowand.list@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bzTluJeC"; dkim-atps=neutral Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42RGc21cHwzF3Fk for ; Fri, 5 Oct 2018 14:14:26 +1000 (AEST) Received: by mail-pg1-x544.google.com with SMTP id r9-v6so4130653pgv.6 for ; Thu, 04 Oct 2018 21:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CpxCZytTE2DMCbEh/CJMp/oXOlBJtuApwHXbU+m9rIM=; b=bzTluJeC/Tmbyz4ERw1iVHsYT8vdIdsZoU6Lpdmg0uJmxQ+mzOXuMhZj8PKrSpRMuA qGlt7DeoV6k4xW2CfE9DkiMVKseaAx2Oy0lnwLetYxnpxxqjuWazNovCZn3Wrp/3nC64 H4sYwh66s9070KUJMi2Iaun6XsvhtWE1WHXXNWLyu5MgDkmWb4g8sUYr70qZrQEhBGFd yqAS3M7p1fERdirBM4Ct0LIARet26yKDMxhrJjNUXVVSIRofQOffseBiweV3X9JH5jKJ xeUlLMWLzb6h0o1DZb/+mXGwVQDQmb5OY2XJ18H8O+R/N5qQT9sTLl/cmc2MQ5u5eKp3 OY3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CpxCZytTE2DMCbEh/CJMp/oXOlBJtuApwHXbU+m9rIM=; b=Up0jA7xOnJmwiq28c5aOXxUVWJOBcF/jqFS74aJhmY0oULdXQob4lU5hlU0Q1L9Uu3 eyl17U9al3LzRnxQ388N0unGzmERARsQjXxXJCw7+W0Ks7uQo/M7dST1PtmaMaLVQyaH N2G9ol9WWIZxs0M1LwC27C15fHy9M1oHI91uWVXV6PuFp1xKq+oXqHLmRUN0Ip+6p7E6 HxYqn9K56dJv2KEBCcNAVIq/3/vF1w9Z3xf4eTKLmpjYhjE7yUI5MuvC1BJLesN/k6S8 NHXHoOfetZj6pO1wFKTH+brXCmABjQNbAyyGACilII7c/BovBA4cJoCiAnllB+HEWeGp MOmw== X-Gm-Message-State: ABuFfohftXTSP4F6qY0WVGTZLYoXmXdpzID9/PUpfaQFWiHbKTCid0x/ nG/HlE6DMasOfN/D/37iWZTL8wZs X-Google-Smtp-Source: ACcGV60XDvqIPx+3U41poUeNqK5p8QfF/qqKJ7ruL10hXJmIq3qiAHQ1HUQ+5E6K57ZDMhbs4aCsww== X-Received: by 2002:a63:2483:: with SMTP id k125-v6mr8451738pgk.287.1538712864682; Thu, 04 Oct 2018 21:14:24 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id n63-v6sm277975pfn.9.2018.10.04.21.14.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 04 Oct 2018 21:14:24 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Subject: [PATCH 10/16] of: overlay: make all pr_debug() and pr_err() messages unique Date: Thu, 4 Oct 2018 21:12:41 -0700 Message-Id: <1538712767-30394-11-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1538712767-30394-1-git-send-email-frowand.list@gmail.com> References: <1538712767-30394-1-git-send-email-frowand.list@gmail.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Frank Rowand Make overlay.c debug and error messages unique so that they can be unambiguously found by grep. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index e6fb3ffe9d93..f89383331b88 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -513,7 +513,7 @@ static int build_changeset_symbols_node(struct overlay_changeset *ovcs, for_each_property_of_node(overlay_symbols_node, prop) { ret = add_changeset_property(ovcs, target, prop, 1); if (ret) { - pr_debug("Failed to apply prop @%pOF/%s, err=%d\n", + pr_debug("Failed to apply symbols prop @%pOF/%s, err=%d\n", target->np, prop->name, ret); return ret; } @@ -557,7 +557,8 @@ static int build_changeset(struct overlay_changeset *ovcs) ret = build_changeset_next_level(ovcs, &target, fragment->overlay); if (ret) { - pr_debug("apply failed '%pOF'\n", fragment->target); + pr_debug("fragment apply failed '%pOF'\n", + fragment->target); return ret; } } @@ -570,7 +571,8 @@ static int build_changeset(struct overlay_changeset *ovcs) ret = build_changeset_symbols_node(ovcs, &target, fragment->overlay); if (ret) { - pr_debug("apply failed '%pOF'\n", fragment->target); + pr_debug("symbols fragment apply failed '%pOF'\n", + fragment->target); return ret; } } @@ -879,7 +881,7 @@ static int of_overlay_apply(const void *fdt, struct device_node *tree, ret = __of_changeset_apply_notify(&ovcs->cset); if (ret) - pr_err("overlay changeset entry notify error %d\n", ret); + pr_err("overlay apply changeset entry notify error %d\n", ret); /* notify failure is not fatal, continue */ list_add_tail(&ovcs->ovcs_list, &ovcs_list); @@ -1138,7 +1140,7 @@ int of_overlay_remove(int *ovcs_id) ret = __of_changeset_revert_notify(&ovcs->cset); if (ret) - pr_err("overlay changeset entry notify error %d\n", ret); + pr_err("overlay remove changeset entry notify error %d\n", ret); /* notify failure is not fatal, continue */ *ovcs_id = 0;