| Message ID | 1537963772-15309-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cd5ff94577e004e0a4457e70d0ef3a030f4010b8 |
| Headers | show |
| Series | powerpc: xive: Move a dereference below a NULL test | expand |
On Wed, 2018-09-26 at 12:09:32 UTC, zhong jiang wrote: > It is safe to move dereference below a NULL test. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/cd5ff94577e004e0a4457e70d0ef3a cheers
diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c index 959a2a6..9824074 100644 --- a/arch/powerpc/sysdev/xive/common.c +++ b/arch/powerpc/sysdev/xive/common.c @@ -1010,12 +1010,13 @@ static void xive_ipi_eoi(struct irq_data *d) { struct xive_cpu *xc = __this_cpu_read(xive_cpu); - DBG_VERBOSE("IPI eoi: irq=%d [0x%lx] (HW IRQ 0x%x) pending=%02x\n", - d->irq, irqd_to_hwirq(d), xc->hw_ipi, xc->pending_prio); - /* Handle possible race with unplug and drop stale IPIs */ if (!xc) return; + + DBG_VERBOSE("IPI eoi: irq=%d [0x%lx] (HW IRQ 0x%x) pending=%02x\n", + d->irq, irqd_to_hwirq(d), xc->hw_ipi, xc->pending_prio); + xive_do_source_eoi(xc->hw_ipi, &xc->ipi_data); xive_do_queue_eoi(xc); }
It is safe to move dereference below a NULL test. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- arch/powerpc/sysdev/xive/common.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)