| Message ID | 1533392700-24621-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 81d7b08b3cec79a43411e7175401b369090dba29 |
| Headers | show |
| Series | powpc:feature: of_node_put is not needed after iterator. | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | success | Test checkpatch on branch next |
| snowpatch_ozlabs/build-ppc64le | success | Test build-ppc64le on branch next |
| snowpatch_ozlabs/build-ppc64be | success | Test build-ppc64be on branch next |
| snowpatch_ozlabs/build-ppc64e | success | Test build-ppc64e on branch next |
| snowpatch_ozlabs/build-ppc32 | success | Test build-ppc32 on branch next |
On 08/04/2018 07:25 AM, zhong jiang wrote: > for_each_node_by_name iterators only exit normally when the loop > cursor is NULL, So there is no point to call of_node_put. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> > --- > arch/powerpc/platforms/powermac/feature.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c > index 3f82cb2..4eb8cb3 100644 > --- a/arch/powerpc/platforms/powermac/feature.c > +++ b/arch/powerpc/platforms/powermac/feature.c > @@ -2889,10 +2889,8 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ > /* On all machines, switch modem & serial ports off */ > for_each_node_by_name(np, "ch-a") > initial_serial_shutdown(np); > - of_node_put(np); > for_each_node_by_name(np, "ch-b") > initial_serial_shutdown(np); > - of_node_put(np); > } > > void __init >
On Sat, 2018-08-04 at 14:25:00 UTC, zhong jiang wrote: > for_each_node_by_name iterators only exit normally when the loop > cursor is NULL, So there is no point to call of_node_put. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/81d7b08b3cec79a43411e7175401b3 cheers
diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c index 3f82cb2..4eb8cb3 100644 --- a/arch/powerpc/platforms/powermac/feature.c +++ b/arch/powerpc/platforms/powermac/feature.c @@ -2889,10 +2889,8 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ /* On all machines, switch modem & serial ports off */ for_each_node_by_name(np, "ch-a") initial_serial_shutdown(np); - of_node_put(np); for_each_node_by_name(np, "ch-b") initial_serial_shutdown(np); - of_node_put(np); } void __init
for_each_node_by_name iterators only exit normally when the loop cursor is NULL, So there is no point to call of_node_put. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- arch/powerpc/platforms/powermac/feature.c | 2 -- 1 file changed, 2 deletions(-)