From patchwork Thu Mar 9 14:36:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madalin Bucur X-Patchwork-Id: 737008 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vfClj2cgVz9s76 for ; Fri, 10 Mar 2017 01:42:09 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vfClj1mkfzDqnP for ; Fri, 10 Mar 2017 01:42:09 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0062.outbound.protection.outlook.com [104.47.32.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vfCfV1YRlzDqZ6 for ; Fri, 10 Mar 2017 01:37:37 +1100 (AEDT) Received: from BN3PR03CA0110.namprd03.prod.outlook.com (10.174.66.28) by BN6PR03MB2947.namprd03.prod.outlook.com (10.175.126.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Thu, 9 Mar 2017 14:37:31 +0000 Received: from BY2FFO11FD043.protection.gbl (2a01:111:f400:7c0c::179) by BN3PR03CA0110.outlook.office365.com (2603:10b6:400:4::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.12 via Frontend Transport; Thu, 9 Mar 2017 14:37:31 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD043.mail.protection.outlook.com (10.1.14.228) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.947.7 via Frontend Transport; Thu, 9 Mar 2017 14:37:31 +0000 Received: from fsr-fed2164-101.ea.freescale.net (fsr-fed2164-101.ea.freescale.net [10.171.73.197]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v29EbC5j031838; Thu, 9 Mar 2017 07:37:29 -0700 From: Madalin Bucur To: Subject: [net-next v2 03/10] fsl/fman: remove wrong free Date: Thu, 9 Mar 2017 16:36:58 +0200 Message-ID: <1489070225-7891-4-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1489070225-7891-1-git-send-email-madalin.bucur@nxp.com> References: <1489070225-7891-1-git-send-email-madalin.bucur@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131335438511384403; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39450400003)(39410400002)(39400400002)(39850400002)(39840400002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(9170700003)(81166006)(8656002)(38730400002)(6916009)(110136004)(2950100002)(189998001)(2351001)(6666003)(85426001)(105606002)(54906002)(48376002)(50466002)(77096006)(8936002)(2906002)(3450700001)(69596002)(47776003)(106466001)(76176999)(305945005)(5660300001)(50986999)(104016004)(356003)(4326008)(36756003)(53936002)(86362001)(8676002)(5003940100001)(50226002)(33646002)(43066003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2947; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD043; 1:YjnYOD/eJ+YRWS9jcQMY1QwQD7x73Kr7x/YDaFYZUNAlTePfVmrXynwc/Mo60Ehg7EY1WZ8YvD5N9yNku6Q+AD2U0fRbgxAJyNP2KY++V3VVfMCSGYcQzkH9DVuKaqm6fM2ttZ43L0YO4kNLuaSW80RugQXVXpDPQFnE49cumYOgwNaSX2fwWVdMLenAWnbF6xVLQbOsavSLuFghBq5/1t4ixBNsUtKjpqxJPIvXH5sVI+RPgDgETdYQMM0OfW0FxVe6iJuhJ+pmEU7I0Ige2/+JeYEnQZEGMKKeGvKyNTgrEdWVoYAJYtpO6LsAw5TLa5yxs5WMNorrMR6mUuy9j/84gmhNx/IotMd0ZbYfcaa+aQORrl9bsfxLGiGIzMYY6zQXYJIp6l+IyeI9C9UcfQuuWyNyIZ8GGM0EC9KnXasDgytoSxMSwItFCadOtFaoLec6g6jItvIvDrjGrw1q3DSLgWQ+aPMtYLr6FV+py/XYeb1dTE40kD3dxn51OJ2u2FJcbevewLPhuHUguWIbEfzlq/wjvCE0pcqEeVGJtJzMp3rYdTtP2PEMuqgUlZl8Fg5A2x8KuY9OOWNX5z1/Qtx3YmGaOp5RQRw49b5m12DmqsEVgudPxIh8J9Y6WT4bMFFml5HP8e2+s3ujFk0vwfQ7CGz4/SPP3JQi/Sbjc+V0tJhz89KU2Scy4BJw8ZJY3JnpTWrcUW81qnF3kSAASQ== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: df2a8a4d-ca38-49f8-c5f2-08d466f9d158 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BN6PR03MB2947; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2947; 3:GMxhrqDDpgZGMlsw5jie+a+AQkxiOoJi4pwLffcVamJkJQGTAlqWbVSkxLEvofbNLTg57Kg83v/g70oPKyAE0xsjanVpwv1pnNM8AyR2bohUco4/AyIQzUeNOpew71yyHQcaEA5Xq04CQZuZSx4bA4JTFSwp1JPhSZw9/2rTq5Du+XP5tlVCShuWgnz8lsQe7QPZhQlCnOPFXjQpryl0b6yJBWHZN0yVwEZPaH+90cU0PE8reoB/lJCI+rS7erUqexlyX/UY6gm94QAwUmB723sqvqzTFwQMYXqU2tHIynO6zRBwBSyRkl8KECtLQgCQdwz6BEiUmUd/86jvUbg3G2bBqApLMdYr+G7PQn7qZxA+2yE9+QpuxYV1gOGgU+ir; 25:XcJnZbTEOHYvJwUtsUwFNaP6BrgFE74D3Hd/sZ4fJeWxLKDQe4q94MiJb4NKSH5h9f0BdjGx1OOI4xrrOKK/pU4jQ63GvSNtt5YqVGK7hqHKHvDz1Q3dWy3tBlCJhox+73ph+EvOmAA9WoWW/aVUREltnHheuUofcJE6IbS+W6WSniA5aS6jUD5QMbGE5t9Z0FiVkx1V+d8rA9FRyy/Olzo2g6gHY8zWizqgLWQmoIC3GOIMSEmNo5am14B5Lxs/06lLxzRkZIc0ik8AVZILKsWhBtbDv/lc2XTRhIWqj40DU4AnCEvGDP39mqvb8N8ytTEYJfy+9v0Q39busCcdZn1yU15FKr4wXgDA9nhpt/QwIMOAW9fRLb/AmodqVgIg95rlQc7s9fhPtcnHOLQoX5Ul0hFd7hirkKJhz18VDQDvraqCI2TQgYSEnJaUy/vnHQ6U1b5FHDZ5LhHIDbOQig== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2947; 31:LH8O0yR5fBD/DE8gpmSZLIBUHvtpGtUC0zYQgL8Zfzgc+k7rbxBb6PHZc3K0bzMK3obFpPABX0RQCwgTpX/3NGWcjOBQFMIsoQCdsPWpRELHrLlX4FXo6KKV6H2QrgK60099SDheXyOUtAibdnw9lXkObiRs5noJgX9t541S9D7xCcoH4BvHvdMTffpcI6Oe2+iZWGIRAtp/MuAeUUXW94T2fbB2ei7eOrwXn28jYB6y9dqfRzFVCDWbe+hqKRAaMDVAxkZ50TjkvqGnTkDqNQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(8121501046)(5005006)(13024025)(13015025)(13017025)(13018025)(13023025)(10201501046)(3002001)(6055026)(6096035)(20161123565025)(20161123563025)(20161123561025)(20161123556025)(20161123559025); SRVR:BN6PR03MB2947; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2947; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2947; 4:UNdUl7YQgj+pzTk7eIA6ZcJ2seYrUXF1nC6aoSa2Xko2/UFQOqUl/AN8OSxA7yRRmTtgJTuCRbXfIKZFy+HTukXE5MGQTLR8n85Wfr+cxEJ3dJFqOmwLT8BInSLGlDn+VvZ536SHOrmgLWOF8cFVWSoffp+lksgjsnylMW1aG8NwDOYm8fwXBi34vrG59qL75YHaUsM2GeNe1nx4sgOXxvBDP3XDH2iMitnOkjp0NuPcM2LChJoBb0QOV3R3pZmZ/06ALGJubAiUtI+vAITolx6riSn1PwOxelZAK6ec5diY1vMqCnARd0I8uXkM7U64mPk9iUDdL+dZXsVqN1dg0w/GQ3qY1BosYziAfgUF7d8mpi2ykcLOA75GqwtLAopn/IYDlc3zpNvR1/eeo8q8Y6UKo/ul/BDNbyk/SqGlb5sn35eX0pfbeOYCVSQ6HhFpm59aGzJDAJgq5WIP0JSbGaSO+EmHjo+RGoTYr8SsUheqdwsBBEFZGmrjf+E1frdS5t3jM6kQTDoctUvSNSdxzgPcDA9Bn2wBGUuBDmYYhl9JrMFA6g5Xy5cKP7i5BWFhAa3lmaXtiaB2lYnk8XUUj5RErWCM/zLuhP+U0gI6Nqy0DEcyT9H0xXq5PYdS2Z4C4AB0ZNDk0ALfmOoW2oBm29RRAPGrT+7Hd1bivHZhZMp3fRXTumSdx0YTkb+CeQIl9cLvVQADWN/xLnywVCT2JGaoUmcah/8m3fwHeHBvObIiFBm69i/u0SdvdFippZzrBkxpsUG/sn+UeQs27MSfKA== X-Forefront-PRVS: 0241D5F98C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR03MB2947; 23:PwggjTv1XAsQ4RRN+kbxezbJH4vQou1eeasTa1Q5N?= =?us-ascii?Q?GHWHmfbYnvd8CsDBv/9ZzprXVNJrE6XhUBRGg8HSCq2iax5vir6arPz4SeKZ?= =?us-ascii?Q?fkQbengpQu716ozOUzKPJ+YhoKpxiM1inMHtYmGS+Txl+EwoR0yde2uc0+bk?= =?us-ascii?Q?nrDkGwBehR4tGv2DjOPuY2Peey1yOJC+7RJM8wZns8jbhxgSas5doWZsFNf6?= =?us-ascii?Q?Pn7jMxlcr95lICcLJSDScFOe2LW7drwFn6NfZBlsAaeMocLRdX/oqrt3qg8x?= =?us-ascii?Q?yziSmrn9geyFGfz3GNkUXXmjTlOjsRE5MlUiQXC8goMj3nXGMh/MrRTh1s1O?= =?us-ascii?Q?IrBvejrQvjpp1z2Nu9IbWSakuohXL9PJL+S8xM1OkdcuOpc9hCiykzQMGVCs?= =?us-ascii?Q?sJ+5BnIF5GnOtTxMhLatyE9ORwsOVdZlNgrjcBEhPWb3PjqCzF43QEAVmRyT?= =?us-ascii?Q?zZnZhfM8okqhSrSm4vhPr8IFs8XLTqJiklQ5zcrqsuphxRcITOKK2n/Weem5?= =?us-ascii?Q?urPkyajzAEsyyJ4vVYshSyK05okYGWyCKzbM/hj1m4XPPuzsrykcbiPuhMsm?= =?us-ascii?Q?DZxTRxsGs9g+rrVdc3+ItQaDoUwpve56Twm2EtHqjWFcwuFzhf4U0XhwS0xi?= =?us-ascii?Q?1DQQXHfQoJHCsDmscFF5HzIod/sxZQUrPSDuztYGwywgq+QYWDSGqXRZND1X?= =?us-ascii?Q?XKRDkLSIgLjK887vqHHQo5Jk+0ThXNu/mgSAZUHXb422chDA/IcEganXlgDH?= =?us-ascii?Q?rAAC/nRtRIcM5mGAkwl8jcagQpx9DqhVLUHCOLSH7A4/h1Aij4NwAVYXUtwX?= =?us-ascii?Q?9rbYu53P8tI3Tf7tcMXC9zIHYCCnWXvnJ5v4eiJC+RuOHv5Aw3q83QwIR3La?= =?us-ascii?Q?QZKH/dvbg08DOs1f4I8/uLvhC+aNe2bHEJ8fIBF5Ip4FHfSuW8v5RiMaVxXo?= =?us-ascii?Q?zd7VQ+DOPFJjt8ZBdqb+EvzyEvTQ0o6bEQkwcRpwgNF3NBmgcowsF3i/Wlq6?= =?us-ascii?Q?BcckzxaOjbmSxAkxk1Zf6Xf41Q+63Fmxyg0p2Xm5brYQM10wTbGE35kNAE9U?= =?us-ascii?Q?4D1Y9/X9ytw3By242d7VXlsR0OKrco/AhMZL3o1WuFup127wP+7qAiGKDXgy?= =?us-ascii?Q?rWi7iOwL0fTibRfjNWsN2ABQV679uGKLWosPBSBlAlTNxSvP41goNVFJ+sEt?= =?us-ascii?Q?EaRTL8ZHwSwkSfu+JZJNfw1IyrEOviNipLxIELZxOzFb1sUMBGf20QYHUUvo?= =?us-ascii?Q?CS5Xq6tMEpk+NdlyhTAPSXJ3LsaitQZGp57LMKrKw5an/63Aoa0mTKJP+n+0?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2947; 6:qRTrGwfDr4aoaH/qPX5O0OnR/wCG0xqbqV+wuBR0HW3KzRkeAAl4UbP2chzVbNpVy2IifVm5ISRfN86aVVvlvQHvLpnC9inNNKtUnH+7xdmwDhYv0cVPnZWkNv5YutvpNT9UWrmdoySgdDxH5ZJrxhVEQ1/NXpRTlhpiBG0kuCM85RfHzgBoHnDUH8SnPMabZs2GG10K44KJTAkW0sC9jR8ZAFIcy7soAmFcGZGF+TGgD2FJN+85Mjlm67d5C5IZTEjpIU6DctMuBumMNXYaKVPZMCLsKX9ZzPrW3/yUal12zmvQv02hnjv215sjL6nJut+9ycJQb4D1t/IrJhWZuLJyJyKP9f1vv4OUCkK+u1JEMwPt3wEN6sIPU13CZYxVkFga8liiY5I7Pmw3IOzW5UpqnPVnbNamCDM9ck9vqJ8=; 5:napQKNRYTCLAtympbVYqf/FpDppsa7ydCTxYgs1AbgsBCNG6A+ybkMECaupYNKig7jjI4Pl/fyeLBJwjfUXS47Jvan+ca0TvUfd4oZ1btCuQJcp1oBfYdaf/UJljYI6cLCt05zKobLNbmOrdiDQl0ksGirDHObDf8m/A/jiwL2yXWtT3HetSK/z4f4vB3Etb; 24:hPavhHp7APGcAW8AQcXBCvjxNHFj7T1Jtej9vgNAZuPt5ZiaQAVsYmuYRs/DNYlM/ZkDVxItclHsqoxi+yX0nZnySva0/FfXfHjiC5uwhN8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2947; 7:xdVVJ+qeuL1SU6FBoZIXeQPrFhqu/zD060lFGd7pZpYmMVXATH7GAB7oflOc6QjGwIsSi+ZSX/rYXyHInHrgh3iAXBTfpRd2jkJd6ZU0ueZ18TtHPYKdtQsZPj44dnaGeGiM7ElvODS9Xih1jGcGnVhB6uN42Y84wYYob3arJPwz6ZwO6Hb6qvBE6jNX0CUNWgP1M/h2NBMTgLT8yGvd36mo7G7bSAzrjB+tn4lGF62+BI3ySFFCaHDGZM3qfEdMfPDWn8g7hQwPUHcXczw1LzcPxKECP4AynCeCWaBkm/FhjjxhyvEj4I37uId/kBlnPz3YDxyKstVcudReARuGpQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2017 14:37:31.0136 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2947 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: madalin.bucur@nxp.com Cc: Madalin Bucur , linux-kernel@vger.kernel.org, camelia.groza@nxp.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, dan.carpenter@oracle.com Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Reported-by: Dan Carpenter Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_port.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c index f314348..57bf44f 100644 --- a/drivers/net/ethernet/freescale/fman/fman_port.c +++ b/drivers/net/ethernet/freescale/fman/fman_port.c @@ -1312,7 +1312,7 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params) /* Allocate the FM driver's parameters structure */ port->cfg = kzalloc(sizeof(*port->cfg), GFP_KERNEL); if (!port->cfg) - goto err_params; + return -EINVAL; /* Initialize FM port parameters which will be kept by the driver */ port->port_type = port->dts_params.type; @@ -1393,8 +1393,6 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params) err_port_cfg: kfree(port->cfg); -err_params: - kfree(port); return -EINVAL; } EXPORT_SYMBOL(fman_port_config);