From patchwork Tue Feb 21 11:52:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madalin Bucur X-Patchwork-Id: 730457 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vSJtH24Ztz9s03 for ; Tue, 21 Feb 2017 22:58:31 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vSJtH0hkJzDqPc for ; Tue, 21 Feb 2017 22:58:31 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0087.outbound.protection.outlook.com [104.47.36.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vSJmZ0YvvzDqHv for ; Tue, 21 Feb 2017 22:53:33 +1100 (AEDT) Received: from CY1PR03CA0018.namprd03.prod.outlook.com (10.174.128.28) by MWHPR03MB2958.namprd03.prod.outlook.com (10.175.136.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Tue, 21 Feb 2017 11:53:29 +0000 Received: from BL2FFO11OLC006.protection.gbl (2a01:111:f400:7c09::174) by CY1PR03CA0018.outlook.office365.com (2603:10b6:600::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13 via Frontend Transport; Tue, 21 Feb 2017 11:53:29 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC006.mail.protection.outlook.com (10.173.160.95) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.919.10 via Frontend Transport; Tue, 21 Feb 2017 11:53:29 +0000 Received: from fsr-fed2164-101.ea.freescale.net (fsr-fed2164-101.ea.freescale.net [10.171.73.197]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v1LBr3ug009568; Tue, 21 Feb 2017 04:53:22 -0700 From: Madalin Bucur To: Subject: [PATCH 3/9] fsl/fman: remove wrong free Date: Tue, 21 Feb 2017 13:52:48 +0200 Message-ID: <1487677974-13678-4-git-send-email-madalin.bucur@nxp.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1487677974-13678-1-git-send-email-madalin.bucur@nxp.com> References: <1487677974-13678-1-git-send-email-madalin.bucur@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131321516092748638; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(336005)(39380400002)(39410400002)(39850400002)(39400400002)(39860400002)(39840400002)(39450400003)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(4326007)(86362001)(47776003)(189998001)(77096006)(81166006)(8936002)(8676002)(81156014)(54906002)(8656002)(5003940100001)(626004)(53936002)(97736004)(2906002)(305945005)(104016004)(85426001)(110136004)(6666003)(2950100002)(6916009)(2351001)(3450700001)(43066003)(50986999)(68736007)(36756003)(38730400002)(76176999)(356003)(33646002)(50226002)(48376002)(106466001)(50466002)(5660300001)(105606002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2958; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC006; 1:KqPaxzt8OLWv1IGrdCI3JE+45gBDfpzvAtkcKcFhVnBKP9tG6DEo/MVecU8qZT2e3BFhAwWQ0W+p9qzrOD12xB+3tsk8IAFsdR4Qg/YvHiH8pretc8UhvlDdcMSa7MzQLOmuIxdU6g0qkGeQZ22Rnx1M6Y+R9TW/UoVFYYrAjQB4RgFUa8f4VemjHZ7jDJlaNq7YqpPQOq1V2QDaelprWU+xrUfBjtQ7SwYC5C2wSzrjWaE+F8XQwlpHymrxuwPnXKJC8yxR9i3izmUXXO5dqXdVwduneWpyJJ+LR7Qr3A7SSHg4Tj10IWCTRSxD94xLGpBcBD2Rt4JmX5eHV2rOph45QOhUErY5UwSBQ8obG8gjeKPxfOV7ijazN7fEUMp8jBho2WddimirZYMPkhyqLvJnY2k0znxm/qYVaKBPRzjAa79euVsLHYW+aj02p1YW5rEgKVyBGvLlhiGypm0m3KAeXcXLoG+wLIxQBY5npMa8n1E+NM2wdh+UCFC6KXYIkEtBETQccWt65QgnKckY95Qjo1+pOg1cZlEz1JgdOB1jBqXaRvR19zbQIsdnTgsbenLvejNWveIGbFd+GDDtZKq5siSk6JwJWPBqtIJqSqP5JDGbcdU2JbbD5kzpch2DVx2t0ZLPfVld3fMe3qmgFrHDv19mgClGRS3OxesDRtOXFkdfpRsdAHWmnumJx+Ua50qmu0v809qqQmWJnyRTNQ== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: acb15b77-107f-4109-9200-08d45a504087 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:MWHPR03MB2958; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2958; 3:YOcmwecLSpC3dRyUMWdjAqGbqayE11iQmxNd9p0y+19eaYNsgQTj157FmvprFT54e3LP8hC7FcSec8CqHvAcV08fAgkzNXC6qneCAE+CTc32Bkc0xd7aEsuqV/g3U1tslL7SSvyi7Hjfwrde0KZSLxJWQXFMUuGJ35pRE4Qy67soGyFygGl5nxNqu4VBlEtzV84DguPq1WgJp+nvjBT/OklO1/bAeHc9X9dVwhT9Vs7xlc8k4Zxsioq3KDR0tzY3Jwp3uLxbGjMma87xWjEgQF2E9J93tl8ZjVf6oxTqtig4/kh2oL1a6GxUeIElUEC+NwEwbIDgHQn4TYVLt6n412xCOXBjddvD+JI8Ra9HE3nwpXcrSdSzTe8D5vM5cDtL; 25:HDdzjUcZDlWslybiUKRaIBdeLaq37I3kgkx/PHVRFJPkvqPd1KPh22j+LLMuFg3pk9ngOT54/UD5BfDOq9G+l3lOrGDPNlVMzVZy01j3M6pMnLUNwdMFJIaOWnRWoPvUSDR2it1Pi0D7cdOJ+mCiToI0dyrhbJkeQXZeYXKBZYrMdNrUx2nMybzA2LF8LPsaJk1jD0seU2Kr50lKOGjj7Axz1I11fHaQxO8Kgtla/UxbucKOroXpzGShwhiJhL6iTmgbuHFD1kB30h1qfBXgbzDb9WiXZpD5z4uBMXLdlaEAJiZhLQrtJHvLIQRO8+7GH80R9E68PH7YrNpftKwj0CKB89jCbWTm+craINFBMDJD+5U1qG0oTbGITX2VBTbxUJI/2F9KPVH27/OV5WRPGQJBYfeE5w9SatisiFHBQFcuSkOeAYl6BPJSlqUeBLHTs6xZeDLimtbcHfxIEBT+xg== X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2958; 31:m9WxKhRY/sYHn3CJ17eEYH+hvXEId41jUViFswo4t3ke4iPzxnE/yTWk10Ir04P6PPmZZ+LVL0/F4ri7Bke9XVkuiMCq4WcnLO+MkkUhnvK8Ig8iuraqItN/7K9aepey5LEgNJp1V7uwjwTFK+gE9K3ycCc2XecLmkx6oSG2BbUjBQzVBlLh+VA6GATwv+nPPMhPKFOXK4jLnldVF+FLGGzP5HKoPkHO/Cx3Iyl5eAZgHQXjS162rL3xX1ihOkLuf1varbjgzKYL7irBaSkL2TPdmsKwLJi3Eq/GMRBtLR8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(13018025)(8121501046)(13015025)(13017025)(13023025)(13024025)(3002001)(10201501046)(6055026)(6096035)(20161123563025)(20161123565025)(20161123559025)(20161123561025)(20161123556025); SRVR:MWHPR03MB2958; BCL:0; PCL:0; RULEID:(400006); SRVR:MWHPR03MB2958; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2958; 4:c41JURU5zpAvmi2u7JNpOsjMsr7Ykq5XPrL/iX9UO0ARg3oSioREYmMuhw8b7cd5g++dkJpCGMBa1BuUU9TnXzYUPMqb7aMSzJwsNI0R042dZ6BIA4wALYt2LOywpyu5MWcz6yXxkREGz+MzALzoItuBvlc4GG/zhR1blFOUDdrUrTR9RFjcDAU6vol9TfwFQjtHWfy0551fHcpOTlD6ZVvV4qJPnCJTTteU/EfBX6UQ9LDsntBFRJ2IwOXHzK/ero3FXAZD37RyD4htg01jXq3fYMDZEAxKCnDWcQygJJcSpqJ/KSYYHYglSt5ivyaelGu3C4lkrDi9iyCP8KxbmZv3LsqeMkJOKmW222UvhTsHQUA1/YtiWJWO9WbbP15fUZpcFzuJH8JqlxI0d/AMMMBBlCMswxKKlQi3tWnKjsbmaT+/4n1EmMKz5ZhZ28J1lkrBPZg05+AX46Fi+bOb+HAvVW8Ns2LLa/xGhI3r9xneEXaqZd0RJHTvtAspmhJNn5OxhMOPQkQ0MbTwhPDGFfmvmK/3t6xswKqnc1HpJbgJeg47DAO9wL2FPbthkC+RMBLLCquw/yZF1TDPHF9otRbA2fTCIP83t7fT8IbeQcVTKBy0WLXJj2vfjJura7oe6SZVt0SWkjTMonkg974E//1CdTyGNH8otdezyN2Tbo0MOyjGBD/OTeNIShT12onGauyj3R2liLXxCfCyQ5MWWG3yWVOV990k3jwboN5fGRWho6X2YOB4DGj2vxOicu+15RwIbltIiibYcRuzwmVw7Q== X-Forefront-PRVS: 0225B0D5BC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR03MB2958; 23:cxnQ4yKMddhnT08YQzWbPRtejEgplUs0wLiKRzIoJ?= =?us-ascii?Q?Aqi9DrgFjEiE9Ci8QWOJFuJkfnY0/eZWn8056rEz3Rjx69c9/rxQ0AhBDVjC?= =?us-ascii?Q?LWbBPxzZORoDvV27KQBqo5lTWTtSSO7KPuN6OfU6hKjOE7uG3Ok2vovkZRCp?= =?us-ascii?Q?6DjFMiKPfNURz75M9oJ6B/Q1mve6eucHUFRT/bTpD7MlH1Zag6G+8Op37GsE?= =?us-ascii?Q?b6S+JTPbLApMejcjgVQapz5sCvXOXMn73i9s6j4EOz0qpaaZ+ocoBeGy/RyW?= =?us-ascii?Q?PhwlzuPUJvbzaugI4UsBsrFXk7wan8NQl3GHuMIYgxGciuFZbVr60YsAlHKa?= =?us-ascii?Q?o+FSwffCGQZnDbTGntSuKDwUYy+Kp4XghTQMWXYr1MmogI8l++H1I+scfND9?= =?us-ascii?Q?6rszauzp+s6jPFymwFaQ8RNpbtFj5JoG0+nUpfQ61eCwTZuCUVF684LkQgaY?= =?us-ascii?Q?WL2HTO5Duv893VDaIrBLVBEskt4/nxJ9Q3GnxEt2ALpaJZ/NzNj50+9J7xd/?= =?us-ascii?Q?Bb9Ty5v2jRiJLIeq8jTRxb8pwzOZbH/z/xDENO6hrMzZTMkXhxtIDT01bPq1?= =?us-ascii?Q?Vhx//Z3q1XbeQaZs6m/XEYTiqxlASeTNsCFl9WkZXlGSN66VbzpRJIR4IlGB?= =?us-ascii?Q?HuNIEvBgzw2QQwvj1leDFRzTmHM3ip+rzvLK6vJ6pYFqI03KtMNLg0giZWha?= =?us-ascii?Q?6jbJ3y4UJnpxSMg2DzuQbEdYOHbeawEbtROSWB6zPO5we8eNNAVDFa0qDyrZ?= =?us-ascii?Q?jkScyxq4L3b2QgYjvs3jp604xH+/w+Q+SLrP/LWUNdmk4lzyaytWmYXFGsvi?= =?us-ascii?Q?eQbXk3FwariqHwm/9rJfrIXusI6MLlZb21G/SBuPgAx50p5wJS6axFaomIAf?= =?us-ascii?Q?tXCIos/joJDGnGfyG7dffQWqHverKwKiWowwlnmXoULcVjiWYx9xLTMwDiNY?= =?us-ascii?Q?dyE1DVgC28vQso45MaWTTne4tg3CnhuyZ7VFdNqxoobudn5b/jZ3PbWHH/Un?= =?us-ascii?Q?C+3nc/ipLJ3y8C1Of/vHVHJS4audDgwqCE0kdC877tYEbGqCZKYMnKAARRF+?= =?us-ascii?Q?gSnwenw7DB676+lYbMfOv7l2EF9CxNHnZHJZ8NIHEq3fPtDosHQrfHMZwtui?= =?us-ascii?Q?09KN4GBGyIBbOoh4qLS1FMC4ADFBU9sHuvLW4N1tQz6HKn2jZh1fQNE0lJy1?= =?us-ascii?Q?8NSNYR8mXTSk+RtgRbj8c8xjwzoqOfFdnBN+k0qoN5lbYRRnBop+jUlWjUrg?= =?us-ascii?Q?Bo2I1DI4U3lZD7rMmdioDPjC6PcKDxXNCadZsDjNq6BLL5CYHWFRTyqPHLjS?= =?us-ascii?Q?bBODUSyf1V9HTyT8wEj5IqlfT3pcUgCtlVJleL1hWMb?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2958; 6:9uPVFD77vcsvYHizZvguhNK90wWmiwzFE4RJ1rWG7mSoxN1It9E+VB1qsH/KcdRjTo7gb5FoY8fvaN2Srx+wjpEwhDIwa9eq1r8OBty4liucOv4+wXO0MhyXbvjtdumLvM1FePNmj0oKfUkV/bXTKJH9FENXinclKyUSRCSSRtwFMNmXs/anzZrsn+QNZUG2yTw3paVe6lSvLSXjawJaX5LaA55einQpPAs6cb2tABQP8Z3poNjVjZc8z3fqzxmru3IIBjxDqXV2jfm0IYniuCtLVH1loi0yCaD78VeBlDvZY3Os2zrzwFxyrdMHjg5Na7K9IVxncoU/z29BjzVSlMM/Q11gtklkuWOJAO091y/B1/X4xjKirssADmq+ME288VZsLdSP6jvrqQfiW+LgE8B3/s64sHM6MbQPpzbAs5E=; 5:c8NhqqKVLAgy0td5gvsPe3WsD8wEORFs4il1ca0PM0bmbnHT7qHN6L+4qR9CFk7ykSPJGLS1raVm6FZ3iLBqb/WZDGYAbRQONpD5FUC/qMrrwezW+Oz2U5CCXaWpW7WX9k/FhqT6/Z/gtU4xYrGz0EGCanG7EfxRTU+o2kmI0kajvkkbOg+MeX96l5+vXWFM; 24:6XdvRZuAh287VsXVHo47aT+HAEInRlxdMAaM8t4SWeqZ9wyOXyau1gXCVkF0beuQNhry6NTffNNYjMZIKTjBalFWYexUg4GP4XuYrpD8jnU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2958; 7:dXUsKKTsyP2lAfA4a3pJJ7GAcRhhQHG0ChfzjZSqb5ZUJqkwTiFzIYtXeSWYe9grx/l8eLk8tIB3LFtMc4YJ3SO7gKwoG/CKNKHih5G1holXw3CasRIvQQCASBsJN55L4ltphKqKY06Kw4FiTkNGvYVLcWBaI0sz6ST75G4S2kVNjq0Cp8bwKDHVnjaO7a54m+jVBn42q8MtEz3EseSBJLt+BhFE1DCR64GDG2NxBUFgivUh9CisY1sRU0cEi0bZ5KmOrqv7wN8fpPuko/YTtgaP5gbabC6OfWTU40QkJohPM3W9jhg5ZNpNAOa5K+M/esgHNqfPRM1TNyjQgL7CYQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2017 11:53:29.0876 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2958 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: madalin.bucur@nxp.com Cc: camelia.groza@nxp.com, Madalin Bucur , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Reported-by: Dan Carpenter Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_port.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c index f314348..57bf44f 100644 --- a/drivers/net/ethernet/freescale/fman/fman_port.c +++ b/drivers/net/ethernet/freescale/fman/fman_port.c @@ -1312,7 +1312,7 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params) /* Allocate the FM driver's parameters structure */ port->cfg = kzalloc(sizeof(*port->cfg), GFP_KERNEL); if (!port->cfg) - goto err_params; + return -EINVAL; /* Initialize FM port parameters which will be kept by the driver */ port->port_type = port->dts_params.type; @@ -1393,8 +1393,6 @@ int fman_port_config(struct fman_port *port, struct fman_port_params *params) err_port_cfg: kfree(port->cfg); -err_params: - kfree(port); return -EINVAL; } EXPORT_SYMBOL(fman_port_config);