From patchwork Fri Feb 3 09:54:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 723541 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vFC7F0Qyqz9s3s for ; Fri, 3 Feb 2017 21:01:13 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="MzoiFVRj"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vFC7D6TXpzDqxF for ; Fri, 3 Feb 2017 21:01:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="MzoiFVRj"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vFBzk0vW0zDqHW for ; Fri, 3 Feb 2017 20:54:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="MzoiFVRj"; dkim-atps=neutral Received: by mail-wm0-x230.google.com with SMTP id r141so19479604wmg.1 for ; Fri, 03 Feb 2017 01:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fxGR1YG5KpKkqh3+63hx/c4j58cqgelrl1xhilCE+Bc=; b=MzoiFVRjvVvNmiC9y62EytGbecxeAj2N8/3xkth42FdxddZ5zv66h24XRcmsLCSbWW vfDgmVkw+CLOQNklRdmD6+IMW6mBupC18FjPo9+/oEP/k4bqJWGWl9GXTcXj+krhCXRE VZUtx3bzw1A6FVpOaLgN/WAd4spu5HAQ8LH+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fxGR1YG5KpKkqh3+63hx/c4j58cqgelrl1xhilCE+Bc=; b=gUlbx/VxhvLL6hjqTN6lHM9nyqitFKwH5/CddqyIc3U4zO8ZocWJh9Sg43sx2bnGAI 4PKlg7xnbNUnX+2Eq3c0H8OEunn2hNJl1Hdh1gX7JGCTQnX2EvUswNrY4isJlrfL1cnk xhv//Zl87bLnfmX4Vxu07EraB26kM5iiCjfcFQu99/cHfEvEXcP5GtTAx7gOh0UuQr1X jrqTAZdDJFVZbHRjTITlLzXsP0/VEuTvg9tKTKTU8GZL/zvIEurfm3+zQc53E05sR1lm 1djqhz/dYa+y0SbkdnhdxovdbUAJFM7Bnf4iewBQa/LLXhi2hoM/0Sy3OJsdWjQa6Aki d4Uw== X-Gm-Message-State: AMke39lW05bmG2u8W5PqpLeMs0Mif+sCdcXaX1Kud1ibqn97aA+TUqxXGxmlLMKuaqTYmn51 X-Received: by 10.28.20.209 with SMTP id 200mr619358wmu.64.1486115679238; Fri, 03 Feb 2017 01:54:39 -0800 (PST) Received: from localhost.localdomain ([105.130.17.13]) by smtp.gmail.com with ESMTPSA id l67sm2144562wmf.1.2017.02.03.01.54.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Feb 2017 01:54:38 -0800 (PST) From: Ard Biesheuvel To: linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, jeyu@redhat.com, rusty@rustcorp.com.au, mmarek@suse.com, mpe@ellerman.id.au Subject: [PATCH v5 3/3] module: unify absolute krctab definitions for 32-bit and 64-bit Date: Fri, 3 Feb 2017 09:54:07 +0000 Message-Id: <1486115647-27680-4-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1486115647-27680-1-git-send-email-ard.biesheuvel@linaro.org> References: <1486115647-27680-1-git-send-email-ard.biesheuvel@linaro.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, arnd@arndb.de, Ard Biesheuvel Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The previous patch introduced a separate inline asm version of the krcrctab declaration template for use with 64-bit architectures, which cannot refer to ELF symbols using 32-bit quantities. This declaration should be equivalent to the C one for 32-bit architectures, but this needs to be checked first, so unify them in a separate patch. Signed-off-by: Ard Biesheuvel --- ... which can simply be dropped if it turns out to break anything. include/linux/export.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/include/linux/export.h b/include/linux/export.h index 7473fba6a60c..1a1dfdb2a5c6 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -49,13 +49,6 @@ extern struct module __this_module; " .weak " VMLINUX_SYMBOL_STR(__crc_##sym) " \n" \ " .long " VMLINUX_SYMBOL_STR(__crc_##sym) " - . \n" \ " .previous \n"); -#elif !defined(CONFIG_64BIT) -#define __CRC_SYMBOL(sym, sec) \ - extern __visible void *__crc_##sym __attribute__((weak)); \ - static const unsigned long __kcrctab_##sym \ - __used \ - __attribute__((section("___kcrctab" sec "+" #sym), used)) \ - = (unsigned long) &__crc_##sym; #else #define __CRC_SYMBOL(sym, sec) \ asm(" .section \"___kcrctab" sec "+" #sym "\", \"a\" \n" \