| Message ID | 1481868864-27283-1-git-send-email-kamalesh@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 16/12/16 17:14, Kamalesh Babulal wrote: > commit 425595a7fc20 ("livepatch: reuse module loader code > to write relocations") offloads livepatch module relocation > write to arch specific module loader code. > > Remove unused klp_write_module_reloc() function stub. > > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> > --- > arch/powerpc/include/asm/livepatch.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h > index a402f7f..47a03b9 100644 > --- a/arch/powerpc/include/asm/livepatch.h > +++ b/arch/powerpc/include/asm/livepatch.h > @@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void) > return 0; > } > > -static inline int klp_write_module_reloc(struct module *mod, unsigned long > - type, unsigned long loc, unsigned long value) > -{ > - /* This requires infrastructure changes; we need the loadinfos. */ > - return -ENOSYS; > -} > - Makes sense Acked-by: Balbir Singh <bsingharora@gmail.com>
On Fri 2016-12-16 11:44:24, Kamalesh Babulal wrote: > commit 425595a7fc20 ("livepatch: reuse module loader code > to write relocations") offloads livepatch module relocation > write to arch specific module loader code. > > Remove unused klp_write_module_reloc() function stub. Yup, the function is not longer used. > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
On Fri, Dec 16, 2016 at 11:44:24AM +0530, Kamalesh Babulal wrote: > commit 425595a7fc20 ("livepatch: reuse module loader code > to write relocations") offloads livepatch module relocation > write to arch specific module loader code. > > Remove unused klp_write_module_reloc() function stub. > > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
On Fri, 16 Dec 2016, Kamalesh Babulal wrote: > commit 425595a7fc20 ("livepatch: reuse module loader code > to write relocations") offloads livepatch module relocation > write to arch specific module loader code. > > Remove unused klp_write_module_reloc() function stub. > > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> > --- > arch/powerpc/include/asm/livepatch.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h > index a402f7f..47a03b9 100644 > --- a/arch/powerpc/include/asm/livepatch.h > +++ b/arch/powerpc/include/asm/livepatch.h > @@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void) > return 0; > } > > -static inline int klp_write_module_reloc(struct module *mod, unsigned long > - type, unsigned long loc, unsigned long value) > -{ > - /* This requires infrastructure changes; we need the loadinfos. */ > - return -ENOSYS; > -} > - > static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip) > { > regs->nip = ip; Applied, thanks.
diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h index a402f7f..47a03b9 100644 --- a/arch/powerpc/include/asm/livepatch.h +++ b/arch/powerpc/include/asm/livepatch.h @@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void) return 0; } -static inline int klp_write_module_reloc(struct module *mod, unsigned long - type, unsigned long loc, unsigned long value) -{ - /* This requires infrastructure changes; we need the loadinfos. */ - return -ENOSYS; -} - static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip) { regs->nip = ip;
commit 425595a7fc20 ("livepatch: reuse module loader code to write relocations") offloads livepatch module relocation write to arch specific module loader code. Remove unused klp_write_module_reloc() function stub. Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> --- arch/powerpc/include/asm/livepatch.h | 7 ------- 1 file changed, 7 deletions(-)