From patchwork Mon Nov 28 18:25:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 700121 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tSGFl6HQNz9vFY for ; Tue, 29 Nov 2016 05:59:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Kvs/iG+t"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tSGFl50QlzDwVs for ; Tue, 29 Nov 2016 05:59:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Kvs/iG+t"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tSG1g4LH1zDw1k for ; Tue, 29 Nov 2016 05:49:27 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Kvs/iG+t"; dkim-atps=neutral Received: by mail-lf0-x241.google.com with SMTP id o20so10386120lfg.3 for ; Mon, 28 Nov 2016 10:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Y7whHaEPV4PsFfKm/cH8de7J7V7nk3AmRV+7RWhBOx0=; b=Kvs/iG+tgjDC9I17x1EQ6eNaNfVCY9q2KCPsTyEzalbrx6sf+rm3DByc5m5gB6ylAS boazVo4YKVdUUGWGDI2pPBriH5L60ehfr/vajDhMGihwFm5jKD8Zy7VJAg2Cm7tArYgM otkHHCYL7DrsT//eZ5ccF/GaZlftCS/Uudi6zO4u9tgQ9no9QILSiAOrTwhXvfQ/uODk 0BASBuzA4Y/zuinyKd5/L3QP4/lzB5sUxTo5rmBAx7TBadDLIoYivD/auRSHrBy57hNL KMV2A5JgHWzl8lWrXeEsO2qSLx5XjHlasl8YKn6zhprtoyUpy7YUJqwj7F5cTUqYPcDf JLNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Y7whHaEPV4PsFfKm/cH8de7J7V7nk3AmRV+7RWhBOx0=; b=mikdNJ+ib1DXB4DLx1KeGfRG/tENUsBSYtBU8lyQB5Q2mnwtOoE4FTbRZQAlAOa4uf dDJSw9jFFdKVY1adc0YFJ9iykICXLktz/e7aM81Vqt6XU3kNpRQupE5/pYrLLJhBVcOk wiTCkQJ381BQUHWXJub3AYIuvdKFldEQ4IkGmLgxXBphG7OJTwBPwZ2kzoaCDXI3YYuD YKAyNRMXPsWteZ7txra3xepQVyRPqscjRMZLfzSkeQQbZDwvEs1hhJIhJ2DC9mCB9vLI LqEkR59Z5mk/ZSWg5TQjoHWYLTeVam3aUMecSKkF93Ocbxkd75k05kVwec9dmXloVtuS qfhg== X-Gm-Message-State: AKaTC02S7fZnFCGX7Dau8cXXpB7zF2hqSyA1aK5u8Ub4AKVowjsBxhtlUgNEt2+hxPjbkQ== X-Received: by 10.25.198.16 with SMTP id w16mr8561676lff.44.1480358964473; Mon, 28 Nov 2016 10:49:24 -0800 (PST) Received: from xi.terra (c-04aadb54.07-184-6d6c6d4.cust.bredbandsbolaget.se. [84.219.170.4]) by smtp.gmail.com with ESMTPSA id f124sm12981613lff.34.2016.11.28.10.49.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Nov 2016 10:49:23 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.87) (envelope-from ) id 1cBQeA-0007Kv-QG; Mon, 28 Nov 2016 19:27:22 +0100 From: Johan Hovold To: "David S. Miller" Subject: [PATCH net 12/16] net: ethernet: mediatek: fix fixed-link phydev leaks Date: Mon, 28 Nov 2016 19:25:05 +0100 Message-Id: <1480357509-28074-13-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1480357509-28074-1-git-send-email-johan@kernel.org> References: <1480357509-28074-1-git-send-email-johan@kernel.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , devicetree@vger.kernel.org, Frank Rowand , Felix Fietkau , Florian Fainelli , Claudiu Manoil , Mugunthan V N , Grygorii Strashko , linuxppc-dev@lists.ozlabs.org, Johan Hovold , Rob Herring , linux-mediatek@lists.infradead.org, Lars Persson , Matthias Brugger , linux-omap@vger.kernel.org, John Crispin , Thomas Petazzoni , Fugang Duan , Sergei Shtylyov , Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vitaly Bordug , nios2-dev@lists.rocketboards.org, Vince Bridgers Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Make sure to deregister and free any fixed-link PHY registered using of_phy_register_fixed_link() on initialisation errors and on uninit. Fixes: 0c72c50f6f93 ("net-next: mediatek: add fixed-phy support") Signed-off-by: Johan Hovold --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 4a62ffd7729d..86a89cbd3ec9 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -318,6 +318,8 @@ static int mtk_phy_connect(struct net_device *dev) return 0; err_phy: + if (of_phy_is_fixed_link(mac->of_node)) + of_phy_deregister_fixed_link(mac->of_node); of_node_put(np); dev_err(eth->dev, "%s: invalid phy\n", __func__); return -EINVAL; @@ -1923,6 +1925,8 @@ static void mtk_uninit(struct net_device *dev) struct mtk_eth *eth = mac->hw; phy_disconnect(dev->phydev); + if (of_phy_is_fixed_link(mac->of_node)) + of_phy_deregister_fixed_link(mac->of_node); mtk_irq_disable(eth, MTK_QDMA_INT_MASK, ~0); mtk_irq_disable(eth, MTK_PDMA_INT_MASK, ~0); }