From patchwork Tue Nov 1 15:26:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 689974 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3t7b5n2zqDz9t3N for ; Wed, 2 Nov 2016 02:40:13 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=NsULVexa; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3t7b5n1xntzDvYY for ; Wed, 2 Nov 2016 02:40:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=NsULVexa; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3t7Zp42H13zDt53 for ; Wed, 2 Nov 2016 02:26:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=NsULVexa; dkim-atps=neutral Received: by mail-lf0-x242.google.com with SMTP id p100so4603349lfg.2 for ; Tue, 01 Nov 2016 08:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=dREUSPs1o/A9A2y6n53ElDMNERpMegunATpxLE7qouk=; b=NsULVexamzcFty9fMqxdSR8hG+OA7Xkn5at9BNn0Aih76DCwl/JW8w3Ix7PqV3i9hJ gaNbanL8OSCrfm95noLlfq+R1A0XaDXWeljnQH76udK7bLoL1XqSK1nrENAjYIo4t+h9 vn2Awcb5ZeNUTb+AsEujrI91FbZq1K1JVZrNPBUeZdSK77Jn9a3YeI+XF9j0uXubgr1k q9thLyFyw0aUyXP+UVdocuREpPhVpe+qR/+LSJN77g8UzH71FK1BLznf0lor9bqf8Ewc 487MsEoX/VSBROYMA41pbWUmFGwPd5y1evtrnb31gpiRSGV+rKUQ87npll+PwQx8AB5x yItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=dREUSPs1o/A9A2y6n53ElDMNERpMegunATpxLE7qouk=; b=MhZ6P6/lWa1KbePwXWS3tuv8/HXWjlth1LtBDIJiM8x5oyriyRV3TalpKAS30MNin+ t5d15GzCa9ToMGLHDxIQ9DOepY8sIgx4+ihlycn6F10tjwbhEzciosJFneiBWRd2frjL 3M4dAo33sEYRRQ5Fl/MAcUS4aWuomoMIamIfrGHr6eZpYwmsW2J+Im7P5uGaniBH+3/+ HQbjoWL55rlThyhb/3nUHBj5Vm5aKbhMKN9U0oG0dYf8XGhP6CZIUjVMzicuJnMajTDN s63+GL4TXhu2I6OxuM21KTpTiA7SvR3G4v/d+k0cjaKayjfMQPIkoumLpKQgQSDIPGGX eqNA== X-Gm-Message-State: ABUngveWQHmK04ThW02lgrFxdoM5Q0CmUOoLfYQZxsjc+CpHeue8ffmP4f8gUmQwwEnYnA== X-Received: by 10.25.170.198 with SMTP id t189mr3504508lfe.129.1478013992098; Tue, 01 Nov 2016 08:26:32 -0700 (PDT) Received: from xi.terra (c-04aadb54.07-184-6d6c6d4.cust.bredbandsbolaget.se. [84.219.170.4]) by smtp.gmail.com with ESMTPSA id f68sm5536718lfg.18.2016.11.01.08.26.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 08:26:31 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.87) (envelope-from ) id 1c1axL-0007Wq-6b; Tue, 01 Nov 2016 16:26:31 +0100 From: Johan Hovold To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Subject: [PATCH 3/4] powerpc/vio: clarify vio_find_node reference counting Date: Tue, 1 Nov 2016 16:26:02 +0100 Message-Id: <1478013963-28871-3-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1478013963-28871-1-git-send-email-johan@kernel.org> References: <1478013963-28871-1-git-send-email-johan@kernel.org> X-Mailman-Approved-At: Wed, 02 Nov 2016 02:33:49 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, Johan Hovold Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Add comment clarifying that vio_find_node() takes a reference to the embedded struct device which needs to be dropped after use. Signed-off-by: Johan Hovold --- arch/powerpc/kernel/vio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c index b3813ddb2fb4..2c8fb3ec989e 100644 --- a/arch/powerpc/kernel/vio.c +++ b/arch/powerpc/kernel/vio.c @@ -1648,6 +1648,9 @@ static struct vio_dev *vio_find_name(const char *name) /** * vio_find_node - find an already-registered vio_dev * @vnode: device_node of the virtual device we're looking for + * + * Takes a reference to the embedded struct device which needs to be dropped + * after use. */ struct vio_dev *vio_find_node(struct device_node *vnode) {